Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <2222edd1-4eb1-4b06-87ef-df2d4f591931@oracle.com>
Date:   Fri, 13 Oct 2023 10:29:26 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH] vdpa_sim: implement .reset_map support
Content-Language: en-US
To:     Stefano Garzarella <sgarzare@redhat.com>
Cc:     jasowang@redhat.com, mst@redhat.com, eperezma@redhat.com,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
References: <1697185420-27213-1-git-send-email-si-wei.liu@oracle.com>
 <4o4yuuezigilikolv2paxb7icrsm3gdnj5aeoe47uotzju7xve@s5vqaafrppdv>
From:   Si-Wei Liu <si-wei.liu@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <4o4yuuezigilikolv2paxb7icrsm3gdnj5aeoe47uotzju7xve@s5vqaafrppdv>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NThaT0tLdU5DZHVFc1U5SkNFSmdxUUZNUWhiRGN0M0h3c2d3L1JiNDZBY3Fs?=
 =?utf-8?B?Q2pQemlYdDBNUjJ6YWNCaVdkREVIalNtQ3M2d1dTRnJBQmhKWWFrdkQ3T3FE?=
 =?utf-8?B?NGd1ZUFXaVpvdmNHeStSWTFmeGV1MXAvb0U1ZDBmMjh3OVY3U2hJclM0b01i?=
 =?utf-8?B?VFVnRHM1NCtPMXhyR3UvZnFJSy8vcUtQRG4yUUJpM0xqRjM2WEZ2ald2U1dz?=
 =?utf-8?B?Q0ZoTnB2RVpGdnFzeXJUOEwyYkJaYXBhdmh5eGJpVkJZSzZVTXA5dmUzTkhz?=
 =?utf-8?B?VWcyUjQwMXBqbUNpRHJWL2hEa0MwWityUy9WWTJ1RVNYOVpnbjIxcnNDQ2VS?=
 =?utf-8?B?UVFOS0oxQi8wSUhocDhzV0NXT3UrSU1YM0c1RDBRL1NTWkJZdk5MNnNkVWQ4?=
 =?utf-8?B?M2pGVUY0MG53SEM4aC9UeTlHQTdEVDhpNXFBdk1aMUxnSVl2ai9EanVaaVVS?=
 =?utf-8?B?V29RblFaVEsvVTZkajF3STlpNFdQcWtaVVR4OTg3cEd5R0x3T05URTJYbGRj?=
 =?utf-8?B?SkR5NjUyQWtiS1QvNWg0TW4xWXRpaVBFNnVKZU00K2laTVdEb1lSamEwVjdK?=
 =?utf-8?B?YlVQNFpsWmtuSGtyMkIvKzNKeWlGTzR1SDI5MWkvWXFQU2oveTBjeTZRSFhv?=
 =?utf-8?B?dnhETythMmVPWjcxODg2MDcxNndrTlJOSm85b0lQWDBlSUk0SlEvbHRhOVNO?=
 =?utf-8?B?SkxXc1hmRU5OS1JCNkRnWWpoU0lwUXZvdCs3eFdUemdpWlI5WG9FU1pCRm5h?=
 =?utf-8?B?Slp4SGpCelpjS0xwRytmM0N2OElraVFSbUVwdW9VQjhRWHlscVhkcEhwWGJs?=
 =?utf-8?B?Uk90LzRPaWkyQTFZRWR2T1dMYmhRdDlKTkNTRjRNSGdnUnd3M3VqMTBkaysz?=
 =?utf-8?B?ZHArTVY3RnNEZ1YySUs2NkdwVDFadXVUVDdCbEFzb2pRMGZaSlMybkhBVDlY?=
 =?utf-8?B?dm5TQ05kV3BEYU1HNXdhT0E1NVNFb1c1VGJVcEJiT2dnb2FTejZkQ00vdTV0?=
 =?utf-8?B?L3Njb2pjdHhhQm0zSW1uakJDak94K2U5SVdHTHRNQ0dDMzAwRlo1WU9CWEhL?=
 =?utf-8?B?UXBxNlJqQjVtMkNYNU9UeUZQazljbmV0VElGZnVzRllEZkhXZnQ1ckdiaFBX?=
 =?utf-8?B?Y0dUN3gvaVIxNHE3enNtY0hnZjZJWW83Zm9CUzFDVHJDSitTSUsxQy9obkxZ?=
 =?utf-8?B?KzdUcFl0R1hHNi9ucUxvSDNMY2Q4aDZGTHRJTXpTRnNoM2FJSjliZmwrZmZ5?=
 =?utf-8?B?RExTUEVIWmYxOVJsdExBVVcyVkJmNTU4RGRVMlNrd2NsOEg2dU5MM09wd25H?=
 =?utf-8?B?YXFXRDZCMU0xclRKTzVMRWJJazZ4d0dyakxYbjVuZ2FHL0JuS2tDRG1CK2FU?=
 =?utf-8?B?b0ppMjEwb0pLakN5STdwNnBTdm5uaVpXdW44dllGKzVabjM3NUNwWFFyWkxH?=
 =?utf-8?B?NVJ2MWRVWVRLa3ZwSzRwcitoeGdMT1BvNno0NlM1VmFQSUV5amVyUEFEWXRH?=
 =?utf-8?B?RXdTankrQitqSGNpZGwzT0lDaXl1L2IvbzhJWlNpTDREcHlqTUtBV2J1QndR?=
 =?utf-8?B?ODZGNjZna0hVR1ppaCs5cnRiWkZFSkM3ODdnWnVnZDg2eHQ5MlhlQmhFUmxQ?=
 =?utf-8?B?ZUxRR2ZGSGpYd0l2M3FGZWRtaEFDdGNkcnhlSHdUeGw2MmUrVkpCYitGTUVY?=
 =?utf-8?B?Q3pvTHdhYlQ2UGUyeGFlSDdHL1lNaFBUZE5mUkQzVTdHMDUveE13RENjWHN4?=
 =?utf-8?B?cXdza2EyaG1ZTmRzTzFSd25QTHU5Qm4zRXpIM0JjcWVacGZGMFZnTHNpREFS?=
 =?utf-8?B?aE1BblZyRUNDZGtoakJTclNTUnRTckNJL2xxVnhROWd1YnBxbE05cnBrMjY3?=
 =?utf-8?B?amNGMDRoYkozSGtUeVpDcHVVTmxtY3ZXNjI2T0ZPQ3kxK2tpemxPbUxWdmFC?=
 =?utf-8?B?STdBUnI2RDBOcC9URCs0YXR5aFU0cUlWZEd0YXh5cWdxcTcySmhNbkZMYzg5?=
 =?utf-8?B?Qk9BS0piVk42RHBRdmFBb1dyQ2NFRG8xWHpVb0M2L0hpUkJ1cFhjcWI1aVBT?=
 =?utf-8?B?dVdPTXFXUzBlekY3aG1CR2taZGM1ZTA3YUR0NngyQUcrdEg5eGxjVUVXTWtS?=
 =?utf-8?Q?0GjHMBvPjK+jCp1MGpH++WZud?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: r01loaGIUWbPGBHGfG4kSpTn86oRDthZGYAeu18glcHBxO0AALcoWssa3EWoSCh2ltUbzSEMM/i6J+cYyRpQW02KjH1gk25TuH/Wja8ZViyK6qTUWPRFpx/bYLO/5nsDxgJrL040AfjUpi3KA2S0ukg4t7gVYJIBhwoBeqQiPYMbEg0Pm4V4z16Yil8NAtw4ZF+6Emye04yvMXrHy0+zTzOe+lXtqRewayh6qloyJbKiwwcEsNCkAnyh5GOnnp0YbIhyXwYcBRky4LGjOn5Tdo/doo2rN1YpifHlDzIyfjsQIU321Dwyi46ix763UWE+z7PhIJWqOSlKBv2KgyuTAsGqw4aaAWvA1AxTEEYXmXOoOyMg7Mb0Odr3mJKj2hK15dobNwzU1UKKKnHkjpJ9wVfpW2SBuh9i4byK9920ZWDsZf55mOKNU1p+UT0pCqhjxoJh9TDnGTzyS8/i2KYgw23+vcpJDoipbvaeAO9l4SFBnEMjLlOjcMi4voofOlaXY1hpedCrJsvqsvvx30m05exZroXhODsBTIGbd5b4s+iLfTncGcktNZESV8Go7DBvNzOmN1LsfTvrK7W6INBEP9bkGkmIv9w7aj3z3/6g+HhtiPwpgippo5RqNu1F2PXJ+vGddbk8D3ExrVFu+kZ4IvCeX5lFuXTdV+jHbZRWDWS5oTMj3iLH1fSJtcheEIwwWwBq1NUguJDg7bk8hNzr2v3tGKgUuEJj7P51zgXAZc4nlNsP3OY3MAvNLbDpACw2aGMkvvl88GLfIS2xtZCtjKSSRRn9mcQphaGv0zEuCDN8I/7hneMnkTLEAvsPi6lmIR0E7W5Bg9uUChVY5BauxJ2QA5xpY8J3wRwc0ZuvGaU=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 366bddd9-11b3-4571-03b7-08dbcc11f586
X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6535.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 17:29:31.1142
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IWMNoGYcT/AaDQi/WrbNlRzZwiVIQOLaTDgQJQEEDJZ+cHThkJ/vsKZx8E0CXAd72kYRn8HC37wgvm3tsKk+Ag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7253
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-13_09,2023-10-12_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0
 mlxlogscore=999 adultscore=0 suspectscore=0 phishscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2309180000 definitions=main-2310130149
X-Proofpoint-ORIG-GUID: yGf7-6ZXwFsTwWzN4NG2_GpVc1ftIjCg
X-Proofpoint-GUID: yGf7-6ZXwFsTwWzN4NG2_GpVc1ftIjCg
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 13 Oct 2023 10:29:55 -0700 (PDT)

Hi Stefano,

On 10/13/2023 2:22 AM, Stefano Garzarella wrote:
> Hi Si-Wei,
>
> On Fri, Oct 13, 2023 at 01:23:40AM -0700, Si-Wei Liu wrote:
>> RFC only. Not tested on vdpa-sim-blk with user virtual address.
>
> I can test it, but what I should stress?
Great, thank you! As you see, my patch moved vhost_iotlb_reset out of 
vdpasim_reset for the sake of decoupling mapping from vdpa device reset. 
For hardware devices this decoupling makes sense as platform IOMMU 
already did it. But I'm not sure if there's something in the software 
device (esp. with vdpa-blk and the userspace library stack) that may 
have to rely on the current .reset behavior that clears the vhost_iotlb. 
So perhaps you can try to exercise every possible case involving blk 
device reset, and see if anything (related to mapping) breaks?

>
>> Works fine with vdpa-sim-net which uses physical address to map.
>
> Can you share your tests? so I'll try to do the same with blk.
Basically everything involving virtio device reset in the guest, e.g. 
reboot the VM, remove/unbind then reprobe/bind the virtio-net 
module/driver, then see if device I/O (which needs mapping properly) is 
still flowing as expected. And then everything else that could trigger 
QEMU's vhost_dev_start/stop paths ending up as passive vhos-vdpa backend 
reset, for e.g. link status change, suspend/hibernate, SVQ switch and 
live migration. I am not sure if vdpa-blk supports live migration 
through SVQ or not, if not you don't need to worry about.

>
>>
>> This patch is based on top of [1].
>>
>> [1] 
>> https://lore.kernel.org/virtualization/1696928580-7520-1-git-send-email-si-wei.liu@oracle.com/
>
> The series does not apply well on master or vhost tree.
> Where should I apply it?
Sent the link through another email offline.

Thanks,
-Siwei

>
> If you have a tree with all of them applied, will be easy for me ;-)
>
> Thanks,
> Stefano
>