Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Miguel Luis <miguel.luis@oracle.com>
To:     Eric Auger <eric.auger@redhat.com>
CC:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
        Oliver Upton <oliver.upton@linux.dev>,
        James Morse <james.morse@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Zenghui Yu <yuzenghui@huawei.com>,
        Jing Zhang <jingzhangos@google.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kvmarm@lists.linux.dev" <kvmarm@lists.linux.dev>
Subject: Re: [PATCH v3 2/3] arm64: Add missing _EL2 encodings
Thread-Topic: [PATCH v3 2/3] arm64: Add missing _EL2 encodings
Thread-Index: AQHZ/G0Pr4UHFXyzik2/jKxJUqxW5rBGLCMAgAHlCgA=
Date:   Fri, 13 Oct 2023 18:42:43 +0000
Message-ID: <F88A4039-A2D0-463C-925C-549EA31CBE0A@oracle.com>
References: <20231011180103.91774-1-miguel.luis@oracle.com>
 <20231011180103.91774-3-miguel.luis@oracle.com>
 <4c73e58f-13d3-7cb9-a706-b20ab7d2df18@redhat.com>
In-Reply-To: <4c73e58f-13d3-7cb9-a706-b20ab7d2df18@redhat.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pA45GekODeU+HPL22gh5fw5xh+VWuMIMyBcB5ghJXNeODnGh6caYpJFwckeU?=
 =?us-ascii?Q?CGDHmfQ2yQkAmLpqfOEKxY6t74ubdjIqH3dHmXGnDPt0lUXLHKFXbQGHi5ob?=
 =?us-ascii?Q?txBKGyNsoW1HsHl5eN7yQNt9RGSzcDCi/Y34oj4r/T3acDYU+VLayJc7fUYN?=
 =?us-ascii?Q?npv66g4HcqtNZ7URkcgdFmwSEwwaV8m9pTD2GlsadGqdg5ZJGYszeaJedq0R?=
 =?us-ascii?Q?gncuuLOPMNB248DESh62dfQgD5oW3w/OiBFTHtxp49UWyJW0Sq+M9G4Unfa7?=
 =?us-ascii?Q?gp9OxsNfy8JYjN8mV08fWLb3jaXbw82QjXKIaDsFsDrb5jWl+acMvI+nXHDt?=
 =?us-ascii?Q?+dEKzvKNtwoB6tvkpDcNaNUAJwyUg2ZPLl++DFKlCdWWY8tbGkIVlVwwJqSC?=
 =?us-ascii?Q?Scbzssny/gOh2vrrUggwxcb3vTFQonnK8YtQSIMn/JM3M8IDiWV98ZeJ6khT?=
 =?us-ascii?Q?6x3v+/CM9OGL0MrZtslizsuDQhWyw6tBKjEDvtCjpe87rUzEig8IqCaV7FEc?=
 =?us-ascii?Q?rvIJ0/oMJiY4iXxbKvcZC/UV0Ec61Te92uCn/zy3txbpnTopK34z61ApFj0n?=
 =?us-ascii?Q?QSRwy2GS9L032f43FXAXERZOql+2vbEBbWyuDcz0MzCBcjIvGxFWh2rsRAQj?=
 =?us-ascii?Q?reCWBtAWBjwLT6GT50ZKxrsxBGc/VWcgFLILSiIjvLtZyT/RMYyZGhaajarS?=
 =?us-ascii?Q?gYSuwkmpYjDtj/VWi6/5j/afZ9tT9MqFM/lWB8RcRcvQFO27md1F55hgdqFd?=
 =?us-ascii?Q?RPAdwcbgOFiHfqCxgWOnjE9ZpytfIpouos8/huicxFxxFLXSepYMu4JSl59P?=
 =?us-ascii?Q?b04lG6OFSh20nWQMb/v9CWUb/kyr0LXWCAxxtksAzL6tOX6Lyt+C/4YzTW5h?=
 =?us-ascii?Q?4gQh84aOkle/GIh5fzk5oRQUEbX+9s/CRDtJK2eQXQP6ud9ThAn33wObG8B8?=
 =?us-ascii?Q?Kc0YAwM20cvirZulo8Kim6RihNYaPUoN7PYP/0Mlpd0PjqTyshTkNr8YlzqJ?=
 =?us-ascii?Q?YCtbl+beYo46Cq3HdscHMrSAepdowD/OQi+yAxQ8Bk5WRH0BGwSRWSqi0wOt?=
 =?us-ascii?Q?TG1paEqvJIY86dfqFiThy9VTuywrbXP9UuHnuEf8xKe3tANG182j0m72K4TQ?=
 =?us-ascii?Q?P5ecW7wfEuxt8VeQOPbxNEJ1CoAYJ6C8XPgip97bdaVkgFHAUUW0v3rU4yMs?=
 =?us-ascii?Q?bDHu8xHnPFeDoNo2XAW9cCte3v4DgdJVatrt3tXcUEMTcguvzk4mxDdiwbvc?=
 =?us-ascii?Q?FGWKmBKfVuDo/xBCbog06ye191Rs5i2Tzhv8fXj3aFIqJbA8G0fW5ty/goWX?=
 =?us-ascii?Q?dp9ReeD5dJYKdBV6c+cjs4/HKVIAZWNX33WcE/kSr1Rtl2mgk1s8nPVgvNP+?=
 =?us-ascii?Q?r4htCPUS83ITxsPsjCOBpPKVfWEWL1Be33XZzzx4marbWk3cJtVnX0QrWAeC?=
 =?us-ascii?Q?WdSLk+rB2oGSE44V69whq16Mmr6BxrhcQfZyzA/0kUoTTWSH11+1kDRTt4aW?=
 =?us-ascii?Q?6MS87Uc4iqp9fXzBeN7gFmwTZOPqKTGNIPmL1xNo8mxbamlZXVBdGX95kmM/?=
 =?us-ascii?Q?fi80qQaf9cJH8ortyAVNuWzmBucHW928sejj3QZU+nEL+rxstkPsOPDzfG+y?=
 =?us-ascii?Q?34f+bClSl3yhTLr+87ueXFA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7AE3488363BA9A4B94BA8A64196244F3@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?BS9thO1Waubk5k0qFD0vP8tBwlW8Opwm+axUdIWwL9mRN5ja1QP8Ywfv543Q?=
 =?us-ascii?Q?bIWswoz5JJhWhpB4/ituGm7yJGGZs9xD8T5f48XOwJ1bhJNiCRBQiF+a0zxW?=
 =?us-ascii?Q?9Vp3vbzX8T1rhaqU8qylp1+lro/LsTkvyz01Az3hwL4cH6ojQmrAPQaR9q34?=
 =?us-ascii?Q?JNaX0avLaY6QwgbYIM/kVAM2WzatIsaWx78xvotph6WHQi36W/c890wXH5Qy?=
 =?us-ascii?Q?gjv3ud0HuPFfhOVFm5K94faN2Nx6t26/HPiVy6y6EJPNGEAWX1gfyDIRNkbI?=
 =?us-ascii?Q?Wkmq9Tf+ooGfUaIJ0WBnuNnX1uM032f90jHmq6+r7/pLmHw21FjTIQYg6RIU?=
 =?us-ascii?Q?IDiS4j8oHp2PBT0vegsw5MobM1oC8z9ACF+kbTm1G0RwRfSxZLLUFazZcxcB?=
 =?us-ascii?Q?opYMaB234AWAvUStkQxChTPlmO8+pnioKgnMCs7yI+bzYl29A2+yHWEl9Jyq?=
 =?us-ascii?Q?6P+HSavV8gVeF2sTHaX9hDM30dYG3UiaDeFFAB0Xc0v83SY90AasQtDEuObw?=
 =?us-ascii?Q?kBYmG72ojbm+QJCQBVGr0YUcTR5tgVe9xtFGiekkaJdeZzWGmIcASbDWWfIH?=
 =?us-ascii?Q?qEij7JG44/r64dv36C9rSHELYe4WVPD0pNjQsq/1hamWSVs5SSHiKemlMOeN?=
 =?us-ascii?Q?xkEX5ipwMjfb/VLRWuUTfjaJjsqxEfKczdSpMwPxjAezh31luJmFubl1vOnR?=
 =?us-ascii?Q?SNAQIIwPSPw5Fh1x1lfMqYPSFJHe2VRoTgOAHEXbwzjhI0zre+HhMHewTePr?=
 =?us-ascii?Q?p/4pE4sibHLWQ9GjLdEWzI+yqCVmi3dUT/Q/h8ECk6rtodckbiRUHoLHex/A?=
 =?us-ascii?Q?vhWbLMFuj7oPJx8jWu8D+S+RukOsaeixFcf8jZrgeNv7IWQLguhX0UPvLliT?=
 =?us-ascii?Q?XrroC05rrzqIceXYisFHqeDJz6CYMFJrOHV36Tak6oJksX8aqP198freEeeg?=
 =?us-ascii?Q?e/o69b2SQ6CfJhqzXfDpdo1TTRjVXZVV8nqkE4ELbLU36HCGjbh7IFzuHpp4?=
 =?us-ascii?Q?BN6xg41+AemXxN8qtHPaPBGhWg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5433.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 434054be-d9f6-410c-c610-08dbcc1c2fde
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2023 18:42:43.7082
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uPsuMYFgpF/aPYywWxA70pteAdgYYPCvoN/UCeMf8x1CBVsXMyPsHdtXDzzLAuWptqLZV6URvlVgluxDF1vlHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7342
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-13_09,2023-10-12_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 malwarescore=0 adultscore=0 mlxscore=0 bulkscore=0 phishscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2309180000 definitions=main-2310130160
X-Proofpoint-GUID: IfWlm1FRXB7_lIjo1YVyzCvAUE7vK5i_
X-Proofpoint-ORIG-GUID: IfWlm1FRXB7_lIjo1YVyzCvAUE7vK5i_
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 13 Oct 2023 11:43:24 -0700 (PDT)

Hi Eric,

> On 12 Oct 2023, at 13:46, Eric Auger <eric.auger@redhat.com> wrote:
>=20
> Hi Miguel,
>=20
> On 10/11/23 20:01, Miguel Luis wrote:
>> Some _EL2 encodings are missing. Add them.
>>=20
>> Signed-off-by: Miguel Luis <miguel.luis@oracle.com>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
>=20

Thank you.

Miguel

> Eric
>> ---
>> arch/arm64/include/asm/sysreg.h | 37 +++++++++++++++++++++++++++++++++
>> 1 file changed, 37 insertions(+)
>>=20
>> diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sy=
sreg.h
>> index ba5db50effec..d8e8607c9de8 100644
>> --- a/arch/arm64/include/asm/sysreg.h
>> +++ b/arch/arm64/include/asm/sysreg.h
>> @@ -484,6 +484,7 @@
>>=20
>> #define SYS_SCTLR_EL2 sys_reg(3, 4, 1, 0, 0)
>> #define SYS_ACTLR_EL2 sys_reg(3, 4, 1, 0, 1)
>> +#define SYS_SCTLR2_EL2 sys_reg(3, 4, 1, 0, 3)
>> #define SYS_HCR_EL2 sys_reg(3, 4, 1, 1, 0)
>> #define SYS_MDCR_EL2 sys_reg(3, 4, 1, 1, 1)
>> #define SYS_CPTR_EL2 sys_reg(3, 4, 1, 1, 2)
>> @@ -497,6 +498,10 @@
>> #define SYS_VTCR_EL2 sys_reg(3, 4, 2, 1, 2)
>>=20
>> #define SYS_TRFCR_EL2 sys_reg(3, 4, 1, 2, 1)
>> +#define SYS_SDER32_EL2 sys_reg(3, 4, 1, 3, 1)
>> +#define SYS_VNCR_EL2 sys_reg(3, 4, 2, 2, 0)
>> +#define SYS_VSTTBR_EL2 sys_reg(3, 4, 2, 6, 0)
>> +#define SYS_VSTCR_EL2 sys_reg(3, 4, 2, 6, 2)
>> #define SYS_HAFGRTR_EL2 sys_reg(3, 4, 3, 1, 6)
>> #define SYS_SPSR_EL2 sys_reg(3, 4, 4, 0, 0)
>> #define SYS_ELR_EL2 sys_reg(3, 4, 4, 0, 1)
>> @@ -514,6 +519,18 @@
>>=20
>> #define SYS_MAIR_EL2 sys_reg(3, 4, 10, 2, 0)
>> #define SYS_AMAIR_EL2 sys_reg(3, 4, 10, 3, 0)
>> +#define SYS_MPAMHCR_EL2 sys_reg(3, 4, 10, 4, 0)
>> +#define SYS_MPAMVPMV_EL2 sys_reg(3, 4, 10, 4, 1)
>> +#define SYS_MPAM2_EL2 sys_reg(3, 4, 10, 5, 0)
>> +#define __SYS__MPAMVPMx_EL2(x) sys_reg(3, 4, 10, 6, x)
>> +#define SYS_MPAMVPM0_EL2 __SYS__MPAMVPMx_EL2(0)
>> +#define SYS_MPAMVPM1_EL2 __SYS__MPAMVPMx_EL2(1)
>> +#define SYS_MPAMVPM2_EL2 __SYS__MPAMVPMx_EL2(2)
>> +#define SYS_MPAMVPM3_EL2 __SYS__MPAMVPMx_EL2(3)
>> +#define SYS_MPAMVPM4_EL2 __SYS__MPAMVPMx_EL2(4)
>> +#define SYS_MPAMVPM5_EL2 __SYS__MPAMVPMx_EL2(5)
>> +#define SYS_MPAMVPM6_EL2 __SYS__MPAMVPMx_EL2(6)
>> +#define SYS_MPAMVPM7_EL2 __SYS__MPAMVPMx_EL2(7)
>>=20
>> #define SYS_VBAR_EL2 sys_reg(3, 4, 12, 0, 0)
>> #define SYS_RVBAR_EL2 sys_reg(3, 4, 12, 0, 1)
>> @@ -562,9 +579,29 @@
>>=20
>> #define SYS_CONTEXTIDR_EL2 sys_reg(3, 4, 13, 0, 1)
>> #define SYS_TPIDR_EL2 sys_reg(3, 4, 13, 0, 2)
>> +#define SYS_SCXTNUM_EL2 sys_reg(3, 4, 13, 0, 7)
>> +
>> +#define __AMEV_op2(m) (m & 0x7)
>> +#define __AMEV_CRm(n, m) (n | ((m & 0x8) >> 3))
>> +#define __SYS__AMEVCNTVOFF0n_EL2(m) sys_reg(3, 4, 13, __AMEV_CRm(0x8, m=
), __AMEV_op2(m))
>> +#define SYS_AMEVCNTVOFF0n_EL2(m) __SYS__AMEVCNTVOFF0n_EL2(m)
>> +#define __SYS__AMEVCNTVOFF1n_EL2(m) sys_reg(3, 4, 13, __AMEV_CRm(0xA, m=
), __AMEV_op2(m))
>> +#define SYS_AMEVCNTVOFF1n_EL2(m) __SYS__AMEVCNTVOFF1n_EL2(m)
>>=20
>> #define SYS_CNTVOFF_EL2 sys_reg(3, 4, 14, 0, 3)
>> #define SYS_CNTHCTL_EL2 sys_reg(3, 4, 14, 1, 0)
>> +#define SYS_CNTHP_TVAL_EL2 sys_reg(3, 4, 14, 2, 0)
>> +#define SYS_CNTHP_CTL_EL2 sys_reg(3, 4, 14, 2, 1)
>> +#define SYS_CNTHP_CVAL_EL2 sys_reg(3, 4, 14, 2, 2)
>> +#define SYS_CNTHV_TVAL_EL2 sys_reg(3, 4, 14, 3, 0)
>> +#define SYS_CNTHV_CTL_EL2 sys_reg(3, 4, 14, 3, 1)
>> +#define SYS_CNTHV_CVAL_EL2 sys_reg(3, 4, 14, 3, 2)
>> +#define SYS_CNTHVS_TVAL_EL2 sys_reg(3, 4, 14, 4, 0)
>> +#define SYS_CNTHVS_CTL_EL2 sys_reg(3, 4, 14, 4, 1)
>> +#define SYS_CNTHVS_CVAL_EL2 sys_reg(3, 4, 14, 4, 2)
>> +#define SYS_CNTHPS_TVAL_EL2 sys_reg(3, 4, 14, 5, 0)
>> +#define SYS_CNTHPS_CTL_EL2 sys_reg(3, 4, 14, 5, 1)
>> +#define SYS_CNTHPS_CVAL_EL2 sys_reg(3, 4, 14, 5, 2)
>>=20
>> /* VHE encodings for architectural EL0/1 system registers */
>> #define SYS_BRBCR_EL12 sys_reg(2, 5, 9, 0, 0)
>=20