Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Keith Busch <kbusch@kernel.org>
CC:     Daniel Wagner <dwagner@suse.de>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        Kenji Tomonaga <tkenbo@gmail.com>
Subject: Re: [PATCH v2] nvme: update firmware version after commit
Thread-Topic: [PATCH v2] nvme: update firmware version after commit
Thread-Index: AQHZ/fL8/I5yjhJHTEW4R44mU62q7LBH7PoAgAAyKIA=
Date:   Fri, 13 Oct 2023 19:43:21 +0000
Message-ID: <ZSmd1y+kaZkz1sXq@x1-carbon>
References: <20231013163420.3097-1-dwagner@suse.de>
 <ZSlzxGx8k9pgkhDk@kbusch-mbp>
In-Reply-To: <ZSlzxGx8k9pgkhDk@kbusch-mbp>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gDV0wWj1H0fxbGDeAq3MBON5ajK41mzLq9viZAEJwuSZwEcXYETPdrBM4H2N?=
 =?us-ascii?Q?QI3ve6xVqsN0ugxKqu9niH/TruEfm6e4EHDuUNg7LXuITGp4S/FsWKgnyzF4?=
 =?us-ascii?Q?BZaTGgHM+IZriWLm9lWjQQSOEOa2SBqu1TDYenNqcvZiu2abVAOKpk0f5htM?=
 =?us-ascii?Q?Sqs60MZbJuuQDTXv7LtXR+pR8g5FK4zhDL0uLoVWhgTxB6rusLAtYgxZFar1?=
 =?us-ascii?Q?qI39V6aHXYUCus6irH9tOvGujFTIGNEV6HkoWK16reTJfl7fzJMjyO4IKVyk?=
 =?us-ascii?Q?nPoBBv+uhwDHT0nT/2zVMFiF04Omq8sqWs8LTQfAOG1Xz1+gFOYjoUQlloyf?=
 =?us-ascii?Q?wJDgeWmT5rhxmJqd5yoO0QGVTbtoI5Z2UcLXmRUYKa1JvPQZVHcwKfesIfYH?=
 =?us-ascii?Q?zYf1bp2FP2GPZTTCcXdRRipUUMAXUwvz7eVTBZiqVq46qft0nk8TzZUXhxn+?=
 =?us-ascii?Q?Aym5GtslZr+IExnc5chEATkAKK5Os5ldrpaK64FLFswSe6Jx/tnnxC6CPXcS?=
 =?us-ascii?Q?4oInaYUygPh4p67pfmVEjtN/Nz/jFbWDPLWdeg102aXdDsqp5b2gJ6kRbw8+?=
 =?us-ascii?Q?+uhFXdn6Aj7cO1azdLpbkFFwAXcvl6fK+JbcgfhugXhxJx0gQcal0SxtE49r?=
 =?us-ascii?Q?Dx6B3d+rH4sNjqgkK8yTgVp3VQhGwKo9DoXcy6dH6gIYOI3xQi50k5aSq8ZX?=
 =?us-ascii?Q?tJ7u3v5BZKxKUKFXg0Pjh9treK39K7uYg5rKJKClvylDZzOlSo4/zBFV7+FR?=
 =?us-ascii?Q?ppKHNtdiRtUxFR9txnKADdZR6EeMThZoHuorqW2bBEKYJ1vGYOsvRstPfs5T?=
 =?us-ascii?Q?pxbSyC6QgKH8fStwj8pjM4RcQC9jnhVyzc27I8D291dzDR/hZE1dA92OSELb?=
 =?us-ascii?Q?Ldm1t2JX5qyBnCC2fQQAT49hmm3ONrKbZJtIzLp7dd2xiAPAwJdu5OUpKEju?=
 =?us-ascii?Q?UwjpXGo7OdW3whntNcXeEib8RlOjhkAprCpNU7VOd6dXJPploudX1ljLXC9p?=
 =?us-ascii?Q?yVJSKl3GnriaqqfUkmXo/qSpj+Z907rXQinLrskii+cELhBvk4rFaCoOP/JN?=
 =?us-ascii?Q?kqzK2ZSrvfPA5vOWx88nS1r7bUBHzSYKcoE2bim36wOBEaUgJG142ds7MntG?=
 =?us-ascii?Q?/pdD9KwMjuXTxTRbDICeTh0tYMt8b6z/WDa4Kox2wXPcQHlo5njaHL85B5O1?=
 =?us-ascii?Q?2DZbZNvo17GVs1jWDZD/CKEfAtufE8n+CTrxLx68HQKg0MsqfzR8GR06dq3v?=
 =?us-ascii?Q?B9lsQKV8qderO6GoPLxaXZDlSCAk/TVHeqZZJ+vUTIA+yhZPa+R4SneoYG35?=
 =?us-ascii?Q?Vkzdg78fyPeF7Kdt3u7gma06sa8jGVt+Rlw2/2vOVYUCzFa8BhbxGj2YIHnv?=
 =?us-ascii?Q?hS9bwOrQ1KehQvekM723PU9dVaCsvvotKN9hisVOLc/vJQa+qBVMnSCZh5Oq?=
 =?us-ascii?Q?EprG5zIj7guQNNYBuhM/Kg7yYt4RG98bIqAv60TzhUkxNRLiwQWMRa44RKeW?=
 =?us-ascii?Q?RYAIf8Ux8JqwoQCRxut4ohiJf65OXy7mCtQNTKZdgn3GLfV+6VGr7RoU8cWP?=
 =?us-ascii?Q?8zSRpe1m+YYnCRNOAc6FisfTxH2NZrVToRdkKGGs+YivgQyw/AwB5fU3DDRN?=
 =?us-ascii?Q?jA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A3408167DC74DC4A9C5E12FAF7594664@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?O0k3wcfj9uaYpPg9erCeBtSBY48p2Mv/zgaCBg3NNTx9RSH+lt6yGBp9YLeY?=
 =?us-ascii?Q?UO67QXLB7Z2R8Sb9cqU71svTtkZBq6fqzRRnYfwKId39xq5rg5p6nbMuZJqs?=
 =?us-ascii?Q?1vCjMS62tKEklJ2AyWEbNMGt1E4mB9xjuXZuy/OoQuRFUPZkBVcS7KEaqTpj?=
 =?us-ascii?Q?38XtZQCv3vuGahXInC8rq4KsJhB03eG5hoPu55RIrv01wAwaPv1MugclHm7V?=
 =?us-ascii?Q?678GNwv2ptqhOcszqsFPKhDpsJ+JENpR/8mdsSs9p3iThiGvv0bkdvfD2rud?=
 =?us-ascii?Q?hfeC6ypnBS6oNT6iMWhmWt4QeotupEZnZ25IV3NqcNlF6Khf6WGkeCoQAwE5?=
 =?us-ascii?Q?psmUkYR8msTD9HIAMvs6+Ts11fw+Y5No/Y82z5FjcVzBM9hv/R2ggRb3aSQv?=
 =?us-ascii?Q?oL6SNUstTXKPdU/tELBIuZvTQwFVMF0EpSIMN7H3Z/aUwoi0Yf4WTV1cddY8?=
 =?us-ascii?Q?wI98p3gVIxU2SfaFwsKzk3xoyEFp9jxZYXbML5PGAGxbS68ckrxV/+pV9kVN?=
 =?us-ascii?Q?yVqas7R0VnWwsuaww7tSPi7XWYhmwoicAOa0rUsjiqJ3wQBSrWvjcbOMXxXX?=
 =?us-ascii?Q?NgG9vtI2Vs7JNNELFmGrCAeM6yFe9P9xv7uqYEILIZSkUoP3XRik0k+4VVtU?=
 =?us-ascii?Q?8tdMbNijFU7f0rm4qoOys4hjt+qJnW13bVhH8hHp+dYt0ja9OLzGtNOKgIvU?=
 =?us-ascii?Q?MECjzR0Be2E+/LEE1+Td0T1zzn2BN4nSkfdBGUKtiOrHG1ep6spgXmty2wKZ?=
 =?us-ascii?Q?I4RlE4FUZclCk/T/ejORHdIIEy0exhRoOkMZVSee1l+DBm5lx56IMa+XztAN?=
 =?us-ascii?Q?qbXHlM0/HOqtPx8bv3Pw2uK87SA92F3TWKTln8hvFFAP4+owfck7IOCIBBYh?=
 =?us-ascii?Q?K67cLjpmOx8Rk2Ie08MuZLsEOlf9YKh8+atQ3lwOzKbbJmBO2FaYz3y/r9Eu?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6272.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0cda530c-8c0b-4498-edf6-08dbcc24a812
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2023 19:43:21.3193
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: A1Z9/p3kzM2hRhSJHH5akDQqo701ZMK3FmS6Ufd6VTWqHxoM1q06RmkjDTlgplDh/c0kugPPgbKkyoQbMgK+AQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR04MB8352
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 13 Oct 2023 12:43:44 -0700 (PDT)

On Fri, Oct 13, 2023 at 10:43:48AM -0600, Keith Busch wrote:
> On Fri, Oct 13, 2023 at 06:34:20PM +0200, Daniel Wagner wrote:
> >  	if (nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_FW_SLOT, 0, NVME_CSI_N=
VM,
> > -			log, sizeof(*log), 0))
> > +			 log, sizeof(*log), 0)) {
> >  		dev_warn(ctrl->device, "Get FW SLOT INFO log error\n");
> > +		goto out_free_log;
> > +	}
> > +
> > +	afi =3D le64_to_cpu(log->afi);
> > +	if (afi & 0x30) {
>=20
> That should be 'afi & 0x70'.

Personally, I like GENMASK().
In this specific case it would be GENMASK_ULL(6, 4);

I find that more readable than 0x70.
Although for some reason GENMASK()/GENMASK_ULL() does not
seem to be used in drivers/nvme/


Kind regards,
Niklas=