Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Fri, 13 Oct 2023 22:06:26 +0200
From:   Simon Horman <horms@kernel.org>
To:     Aaron Conole <aconole@redhat.com>
Cc:     netdev@vger.kernel.org, dev@openvswitch.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Pravin B Shelar <pshelar@ovn.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Adrian Moreno <amorenoz@redhat.com>,
        Eelco Chaudron <echaudro@redhat.com>, shuah@kernel.org
Subject: Re: [PATCH net v2 0/4] selftests: openvswitch: Minor fixes for some
 systems
Message-ID: <20231013200626.GS29570@kernel.org>
References: <20231011194939.704565-1-aconole@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231011194939.704565-1-aconole@redhat.com>
Precedence: bulk

On Wed, Oct 11, 2023 at 03:49:35PM -0400, Aaron Conole wrote:
> A number of corner cases were caught when trying to run the selftests on
> older systems.  Missed skip conditions, some error cases, and outdated
> python setups would all report failures but the issue would actually be
> related to some other condition rather than the selftest suite.
> 
> Address these individual cases.
> 
> Aaron Conole (4):
>   selftests: openvswitch: Add version check for pyroute2
>   selftests: openvswitch: Catch cases where the tests are killed
>   selftests: openvswitch: Skip drop testing on older kernels
>   selftests: openvswitch: Fix the ct_tuple for v4
> 
>  .../selftests/net/openvswitch/openvswitch.sh  | 21 +++++++-
>  .../selftests/net/openvswitch/ovs-dpctl.py    | 48 ++++++++++++++++++-
>  2 files changed, 66 insertions(+), 3 deletions(-)

Thanks Aaron,

this looks like a good incremental improvement to me.

For series,

Reviewed-by: Simon Horman <horms@kernel.org>