Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20231013132832.165768-1-2023002089@link.tyut.edu.cn>
In-Reply-To: <20231013132832.165768-1-2023002089@link.tyut.edu.cn>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Fri, 13 Oct 2023 13:27:24 -0700
Message-ID: <CAKwvOdneBDDCeg-GzKMpWmvqQCC53KcaV_GAF1JioCJdCtBkxw@mail.gmail.com>
Subject: Re: [PATCH] scripts/show_delta: add __main__ judgement before main code
To:     Hu Haowen <2023002089@link.tyut.edu.cn>
Cc:     gregkh@linuxfoundation.org, masahiroy@kernel.org,
        akpm@linux-foundation.org, n.schier@avm.de, ojeda@kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Oct 13, 2023 at 6:29=E2=80=AFAM Hu Haowen <2023002089@link.tyut.edu=
.cn> wrote:
>
> When doing Python programming it is a nice convention to insert the if
> statement `if __name__ =3D=3D "__main__":` before any main code that does
> actual functionalities to ensure the code will be executed only as a
> script rather than as an imported module. Hence attach the missing
> judgement to show_delta.
>
> Signed-off-by: Hu Haowen <2023002089@link.tyut.edu.cn>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

> ---
>  scripts/show_delta | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/show_delta b/scripts/show_delta
> index 28e67e178194..291ad65e3089 100755
> --- a/scripts/show_delta
> +++ b/scripts/show_delta
> @@ -125,4 +125,5 @@ def main():
>         for line in lines:
>                 print (convert_line(line, base_time),)
>
> -main()
> +if __name__ =3D=3D "__main__":
> +       main()
> --
> 2.34.1
>


--=20
Thanks,
~Nick Desaulniers