Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <272769bf-6fcc-4e25-8223-88b1775dc487@intel.com>
Date:   Fri, 13 Oct 2023 14:24:51 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v13 10/10] x86/resctrl: Display RMID of resource group
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <20231013202602.2492645-1-babu.moger@amd.com>
 <20231013202602.2492645-11-babu.moger@amd.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231013202602.2492645-11-babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUhNOGdXZDI5YjBRS29EalQ1bUZ4ckRpZDdiamkwYS8rd1pxM00xbGFZMWF0?=
 =?utf-8?B?Qy8xLzFZb09mem1TMVpPdXdGVmVsQ3pWNTFMTms5V2JzNHNEVkJpVkgyK2NT?=
 =?utf-8?B?eWVqVGhHcFEzdG1DOFZJWm00Zm16eHQ3bzdPNmxqdGNWWlY0cFRqZFN2ZVl3?=
 =?utf-8?B?QzhtZkQrZTVJYWY1QWdzaWEyaUhJaEdoL216aFVRa1FCWUJuSHJ0RmE3SE5w?=
 =?utf-8?B?djFGcjFlMktUQjhESXdNOVJYdWVWbnhYclh6RSsyVnl6T2lvYmJUOGlVZit5?=
 =?utf-8?B?STBqcVl0VzgrRWhXODlkaDJzNGNZY1lVaGJsTmF1bXVqZHBCUStLVGw4d3lC?=
 =?utf-8?B?WE1EZHpERE5ZeWVEWkVJU0hML1VWMllxUXd3L2VVZVFpYTdGNmJSU0dDZExT?=
 =?utf-8?B?SDFyVnlRM2FMY1Fvb2d4VGE5b0czUWlQS0xUei9LWFRCazdMR1BXc0ZKVkxr?=
 =?utf-8?B?S3RZRjcvT0IwUllwN05uWEdra0ZhU1JYMFNLdVdFbDBVN3pVR0NnT3F1QUxQ?=
 =?utf-8?B?aCs4MFBoeE1sb2RMdmhwOWJra2FSbHFxK2l4Mk5nd0w5QkxWVUdSd2pSUDdp?=
 =?utf-8?B?QTA3TjVhOXZGTkNOSXVvQ2R1OE1nSHdaMXR6b0hCU1poK3BHaitjbVl2bllF?=
 =?utf-8?B?dUNWSnhveEJQa0pxY0Jmc0tiYnJxVmZFdnkzZEJQVWlZRzV2Ui9FRVFWcUl2?=
 =?utf-8?B?ZjlLYXlEU2M3allCVmp3aTBHZDdVdndzL0JUOWFZbUx4dXBEWHlXN2h3TkZK?=
 =?utf-8?B?SWZ2TlU4eDEyZ2FMVlN4SldJOGI2QlJJZEpMTGZGcmdaaXlRK0ZuT3RCM1E1?=
 =?utf-8?B?QUhkZURJek8ya0JsUHRSSWJieFFhN1N5b0tqcldWU2dXQmMwKzdtUFF5Z2RO?=
 =?utf-8?B?ZnhjTzl0Y1J6ZVBZMVJRMWtNRDRGTlV4L1B1aDhtODB6dWxLU1dVNXdDb0Rr?=
 =?utf-8?B?eW5oTzg0K0VKcE5oMUVUMTNESzhpZTZ0NTdEN0Q2YVpDeWRJeEpNUmFHeWZ3?=
 =?utf-8?B?MW9KZksxSWo2TlMyd1ArTG0vTGlkUzE1djhDRVA2YWFoaG4wY0JhZDhpajNR?=
 =?utf-8?B?UlVCZFRkVE11T1JQM3B6WEw4VnNsaDNLbnJQU01ORzVieDVOVEVMWVRHTS90?=
 =?utf-8?B?elRlVjVldG5pUTFOMm9qdHRNTzFqYlVKTG5JNkhSMzBtNVB0SVY5YnU5Q3k4?=
 =?utf-8?B?UFdsTXEwTFAxTUo4cXFyeGxxbjh0OXZGR1dvaVgzY1FGZjIvaDczcGZUNjdY?=
 =?utf-8?B?SENDSGticVlxeEFXYUlZblU4QmNoZjRTM09IYTluRFZzUFcxZ1luRkxOL0t1?=
 =?utf-8?B?VzBHUndyQ2kyQ1RRTkFuaFJsZUFoQU9qb2R6TDVyUUZ5WnN2ZlcvMWQrN2Rn?=
 =?utf-8?B?MzZLakltSlZwSStRczluam5RZEo4TVdqV3Vnb3V2aFozTGhwZXRnNVlJQWd3?=
 =?utf-8?B?Q0NoNjVkbi8yL3Fka0phcS8xRXlJNnVIWWJaTTRTYkptYlhUR3M5YTdXYS8v?=
 =?utf-8?B?cjVvLzFFdkE0dnV2ZnVUclBTN3l2dldCb0pEczE2cW9FSUJKSFp6STFtZGFT?=
 =?utf-8?B?V285M2k5M3lVYjNhbDhIYUU0Vm5jczJWWCt3VkIvbDFHL3p2NkF1TXYyOEFa?=
 =?utf-8?B?UyswVHJmeU1LamtMdk03akl5bXpFZDRzYS9QRUJsZi83d1dnMjhQTWg3YWY1?=
 =?utf-8?B?cFlLemx3azVRdXhzSUsrWm9uSUE4ZkU2M1BJVmU3VmQ5ZDBzcGVPOW0yaVRN?=
 =?utf-8?B?NGI3YnhZMklzK3NZWnk4V2QxZDBscG1Na3FBQWtwT3NwTXBoRVUvWE15TGNP?=
 =?utf-8?B?cUdqQW0zWUVQREJlcFpQZFN5VDNPbkkvSlJmbWI0YmZ6L1ZGMzgvanRRZklC?=
 =?utf-8?B?ME5lSEd4dWRCN0x2K1ZhL3loZHBucmlaalZHNFVVTE9ZNkE3ZzZhbktwR3NY?=
 =?utf-8?B?S21CZEw0SlhzYWtuYzJjTzVnWU9iRWovNldQT0FjU0hHWkpjS0doRXd3ZDB3?=
 =?utf-8?B?NEdtekVqbC8vV2RsYTRoZ1JnYzZGUUI2bkF4SjBzVlFHbjFUM01mVGpYaVBN?=
 =?utf-8?B?eGppdDk3V0hsV2JLOE9BMUdPVHFGdXRrVlhrc1VhUXMvQ2JrS0pjUXZmMnJR?=
 =?utf-8?B?NjIvaFRBWHBFaTdLQWdVVzVYbStjalp2bWZReGx5V3YyYSt4eDhRY3dYaUt4?=
 =?utf-8?B?ZXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ffd4930e-fc0d-4ba7-229b-08dbcc32d73e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 21:24:53.5904
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xuNZcLLHd7hMsBBt5BYl7ratCVghCYRmbnh5BPJZxgxZiCXbR1Tx2ZPbLK0EWEQ09SB9Bbsi7/Wqp0VipcIgmWqYs+bflUB+3abW1xJFrmk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR11MB8755
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 13 Oct 2023 14:25:14 -0700 (PDT)

Hi Babu,

On 10/13/2023 1:26 PM, Babu Moger wrote:

> @@ -440,6 +444,14 @@ RESCTRL filesystem has two main components
>  		-> RFTYPE_CTRL (Files for CTRL group)
>  		   Files: mode, schemata, size
>  
> +		-> RFTYPE_MON (Files for MON group)
> +
> +			-> RFTYPE_DEBUG (Files to help resctrl debugging)
> +			    File: mon_hw_id
> +
> +		-> RFTYPE_CTRL (Files for CTRL group)
> +		    Files: mode, schemata, size
> +
>  			-> RFTYPE_DEBUG (Files to help resctrl debugging)
>  			   File: ctrl_hw_id
>  

Something went wrong during creation of this patch. Notice that the
"RFTYPE_CTRL" at the top is duplicated in the new changes and that
the "RFTYPE_MON" changes were inserted in the wrong place.

Reinette