Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
MIME-Version: 1.0
References: <20231011120857.251943-1-zhouchuyi@bytedance.com> <20231011120857.251943-8-zhouchuyi@bytedance.com>
In-Reply-To: <20231011120857.251943-8-zhouchuyi@bytedance.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Fri, 13 Oct 2023 14:27:30 -0700
Message-ID: <CAEf4BzYytbg+ZqR9vWm8f0XSi9ZvAqFhoE_-bD6A7ZBXVkic7g@mail.gmail.com>
Subject: Re: [PATCH bpf-next v5 7/8] selftests/bpf: rename bpf_iter_task.c to bpf_iter_tasks.c
To:     Chuyi Zhou <zhouchuyi@bytedance.com>
Cc:     bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
        andrii@kernel.org, martin.lau@kernel.org, tj@kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Oct 11, 2023 at 5:09=E2=80=AFAM Chuyi Zhou <zhouchuyi@bytedance.com=
> wrote:
>
> The newly-added struct bpf_iter_task has a name collision with a selftest
> for the seq_file task iter's bpf skel, so the selftests/bpf/progs file is
> renamed in order to avoid the collision.
>
> Signed-off-by: Chuyi Zhou <zhouchuyi@bytedance.com>
> ---

Acked-by: Andrii Nakryiko <andrii@kernel.org>


>  .../selftests/bpf/prog_tests/bpf_iter.c        | 18 +++++++++---------
>  .../{bpf_iter_task.c =3D> bpf_iter_tasks.c}      |  0
>  2 files changed, 9 insertions(+), 9 deletions(-)
>  rename tools/testing/selftests/bpf/progs/{bpf_iter_task.c =3D> bpf_iter_=
tasks.c} (100%)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/bpf_iter.c b/tools/te=
sting/selftests/bpf/prog_tests/bpf_iter.c
> index 1f02168103dd..dc60e8e125cd 100644
> --- a/tools/testing/selftests/bpf/prog_tests/bpf_iter.c
> +++ b/tools/testing/selftests/bpf/prog_tests/bpf_iter.c
> @@ -7,7 +7,7 @@
>  #include "bpf_iter_ipv6_route.skel.h"
>  #include "bpf_iter_netlink.skel.h"
>  #include "bpf_iter_bpf_map.skel.h"
> -#include "bpf_iter_task.skel.h"
> +#include "bpf_iter_tasks.skel.h"
>  #include "bpf_iter_task_stack.skel.h"
>  #include "bpf_iter_task_file.skel.h"
>  #include "bpf_iter_task_vma.skel.h"
> @@ -215,12 +215,12 @@ static void *do_nothing_wait(void *arg)
>  static void test_task_common_nocheck(struct bpf_iter_attach_opts *opts,
>                                      int *num_unknown, int *num_known)
>  {
> -       struct bpf_iter_task *skel;
> +       struct bpf_iter_tasks *skel;
>         pthread_t thread_id;
>         void *ret;
>
> -       skel =3D bpf_iter_task__open_and_load();
> -       if (!ASSERT_OK_PTR(skel, "bpf_iter_task__open_and_load"))
> +       skel =3D bpf_iter_tasks__open_and_load();
> +       if (!ASSERT_OK_PTR(skel, "bpf_iter_tasks__open_and_load"))
>                 return;
>
>         ASSERT_OK(pthread_mutex_lock(&do_nothing_mutex), "pthread_mutex_l=
ock");
> @@ -239,7 +239,7 @@ static void test_task_common_nocheck(struct bpf_iter_=
attach_opts *opts,
>         ASSERT_FALSE(pthread_join(thread_id, &ret) || ret !=3D NULL,
>                      "pthread_join");
>
> -       bpf_iter_task__destroy(skel);
> +       bpf_iter_tasks__destroy(skel);
>  }
>
>  static void test_task_common(struct bpf_iter_attach_opts *opts, int num_=
unknown, int num_known)
> @@ -307,10 +307,10 @@ static void test_task_pidfd(void)
>
>  static void test_task_sleepable(void)
>  {
> -       struct bpf_iter_task *skel;
> +       struct bpf_iter_tasks *skel;
>
> -       skel =3D bpf_iter_task__open_and_load();
> -       if (!ASSERT_OK_PTR(skel, "bpf_iter_task__open_and_load"))
> +       skel =3D bpf_iter_tasks__open_and_load();
> +       if (!ASSERT_OK_PTR(skel, "bpf_iter_tasks__open_and_load"))
>                 return;
>
>         do_dummy_read(skel->progs.dump_task_sleepable);
> @@ -320,7 +320,7 @@ static void test_task_sleepable(void)
>         ASSERT_GT(skel->bss->num_success_copy_from_user_task, 0,
>                   "num_success_copy_from_user_task");
>
> -       bpf_iter_task__destroy(skel);
> +       bpf_iter_tasks__destroy(skel);
>  }
>
>  static void test_task_stack(void)
> diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_task.c b/tools/te=
sting/selftests/bpf/progs/bpf_iter_tasks.c
> similarity index 100%
> rename from tools/testing/selftests/bpf/progs/bpf_iter_task.c
> rename to tools/testing/selftests/bpf/progs/bpf_iter_tasks.c
> --
> 2.20.1
>