Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
MIME-Version: 1.0
References: <20231004204741.985422-1-namhyung@kernel.org> <ZSnHek1HlQTkfjhG@kernel.org>
 <CAM9d7cip5qmPRhWF37JH_21Q8SjKQCTBVyF_PLE-ytTFOwpasg@mail.gmail.com>
 <ZSnMxtnt7o5mLj+w@kernel.org> <CAM9d7cg75rnPpOUB4wUqUPCbsEZucOyu0sB1UwF3kk-4E8q2SA@mail.gmail.com>
In-Reply-To: <CAM9d7cg75rnPpOUB4wUqUPCbsEZucOyu0sB1UwF3kk-4E8q2SA@mail.gmail.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Fri, 13 Oct 2023 16:20:27 -0700
Message-ID: <CAM9d7cgAg7LfTvZhR3+Mh64GjhnLQZ6Pjae_8agMLABc0_weqg@mail.gmail.com>
Subject: Re: [PATCH] perf bench sched pipe: Add -G/--cgroups option
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Fri, Oct 13, 2023 at 4:10 PM Namhyung Kim <namhyung@kernel.org> wrote:
> diff --git a/tools/perf/bench/sched-pipe.c b/tools/perf/bench/sched-pipe.c
> index 1103fd658d5d..25236f339b90 100644
> --- a/tools/perf/bench/sched-pipe.c
> +++ b/tools/perf/bench/sched-pipe.c
> @@ -118,9 +118,9 @@ static void enter_cgroup(struct cgroup *cgrp)
>
>         /* try cgroup v2 interface first */
>         if (threaded)
> -               fd = openat(cgrp->fd, "cgroup.procs", O_WRONLY);
> -       else
>                 fd = openat(cgrp->fd, "cgroup.threads", O_WRONLY);
> +       else
> +               fd = openat(cgrp->fd, "cgroup.progs", O_WRONLY);
>
>         /* try cgroup v1 if failed */
>         if (fd < 0)

Oh, actually it should be 'procs' instead of 'progs'.

Thanks,
Namhyung