Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1276682rdg; Fri, 13 Oct 2023 16:48:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEUOy/EKmThNi5/X/RipfXixzR8mObpP7JW85Q/bKN+61mC34yT5TzDWySfJQ2qOp+gfr3m X-Received: by 2002:a17:902:720a:b0:1c5:a7b7:291c with SMTP id ba10-20020a170902720a00b001c5a7b7291cmr29809832plb.12.1697240880950; Fri, 13 Oct 2023 16:48:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697240880; cv=none; d=google.com; s=arc-20160816; b=nPOQtu6mny7MVQZYNs0dEZ6xgaI1xWbMVirT/Xw1t+XpePiwUY7KAG33lBY6FYUW/q AbLno7gqM9CwpkkR+fwY7qqOEQqVPVuwCc86QOsFCKAgSHIxy3JIuXGw1ZLifImgZHg5 xVfzWrE48UDhfwT+BmJPLRmcI15EZ4URtAvBWDVLYoj/g6xwoUNB45TnPsiO7jkcN/9m 2Cg2sgO1JgYcDFiyu0EezPbT22ommyXOCQmlyXBTqOs/ndrE0uk1UV+/QnlIynL5kD4y nG7MreWXeWts5KZgRoC5VndjmaLLsocsbhx3cp4WwQ80xNYrR0s57L3LRfvOQP4Ghmcf 7n5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KJrm38iAyueby6JBNctMCXPsnK32BGQQ6vdEWVAMrOI=; fh=Jr/ZUGwuqk8r3C0qciQ38igCbjoZjzbRVHKdCQpyGnA=; b=rJ5fqIkOuIVEprQljXqKcrLAnVVyX7bI3tH8nJlo+ysz3QUJJeM+5zRsROXSNhz9KV VwzlnKc1mj7BNlMVhV9NtP2/Qk7UuP18ME5hreKGeS1KUHWtMqp/S4p5D/IxQr7xNC9S EbBHAlPmKbz62pSuxYbZlxlM7HyQbYsrw1Ui1O1tVB80D9+mig5KNS8KSXJVipcho874 +Y/ZzWwUy/avOaBmePyO3ybjIj1cKK758LyVKQS+XU16fPeUuHLyzKbk1QTjRrKPtP1T HatG4O4m5DDsogneyFLXJuzLSE19ZuN5obQ2UPRPihRU8E9QEegeQaRp9qhCA5U99LfL 3kXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Zs9iaBg4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id s24-20020a170902b19800b001c5e1c94588si5069198plr.550.2023.10.13.16.48.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 16:48:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Zs9iaBg4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id E57478031AE8; Fri, 13 Oct 2023 16:47:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232632AbjJMXri (ORCPT + 99 others); Fri, 13 Oct 2023 19:47:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232431AbjJMXrf (ORCPT ); Fri, 13 Oct 2023 19:47:35 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70A98CE for ; Fri, 13 Oct 2023 16:47:34 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-69101022969so2336894b3a.3 for ; Fri, 13 Oct 2023 16:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697240854; x=1697845654; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KJrm38iAyueby6JBNctMCXPsnK32BGQQ6vdEWVAMrOI=; b=Zs9iaBg42ugfcYr/gMAk5pvACGuWjAZa2udPvD0fUM7sxe6ZxWQFV29PGgGfb8Z5/k hova8YP7lNGQRy652t714a2xOFuqcMamgzopfy6cgAmUC1fkVIK/5EwMshPKFBwWpHg6 zEpqbSCToQO5Ge9sWdJEarJwKSjoOD9nBsB3fqdoAU6ngr7dqErl7/7UhAKLTbE/6vSf f5rrDfaSpsGTVON6h1RfIlqyOyYSJWZgTjo/NVYSWi/RrF+naLbFCpE3aEMcdcVreTNq SH1VzcddBhs1dxVZtgRCkhsfkkvypNI5vrwrpUmMTTCJ9h7qNBQXQwmMfonAxQT9F2FB P+BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697240854; x=1697845654; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KJrm38iAyueby6JBNctMCXPsnK32BGQQ6vdEWVAMrOI=; b=TaUHMtiofR9J847L6wqh9jOos6qt6xTKE7TdiDkGbc4Wg9rwW4+33UcKgzi/CTRbQf /+NbPS4GWxG5f5Aqlw+9+cgGIBBQpG1ukYOJLp/6a94H84ZuOdo6zcEbNYjPnzzFyaPf 7p49sIyNEe4kwYed6UpLN1xMpzfae+H5p9YZpldmMEnBw9nHpIdWKOUmEv4DfC/SlNCA +VuexTrduvaDW3YWr7ClFQ30Je3uGK2JC/7HsqEiFcdLY0QZhnrfhII3BHIogccU8cGF +tBF2ES32+N47e5zCAntu8fesxTBi8+iKd8iqOoMRONHwqAN8x2tiL4yJZUCLAw9QXvu TwUQ== X-Gm-Message-State: AOJu0YxQ3zrGDVMIH4CfsQUcRVIozE6XlkNN5HeyOKkZ2g68SMejwCb5 myM66NNt3MZEUBu1YWkMb18= X-Received: by 2002:a05:6a00:814:b0:690:3a0f:4165 with SMTP id m20-20020a056a00081400b006903a0f4165mr33074285pfk.32.1697240853802; Fri, 13 Oct 2023 16:47:33 -0700 (PDT) Received: from Negi ([68.181.16.134]) by smtp.gmail.com with ESMTPSA id 1-20020a631241000000b005a9b20408a7sm1980883pgs.23.2023.10.13.16.47.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 16:47:33 -0700 (PDT) From: Soumya Negi To: Martyn Welch , Manohar Vanga , Greg Kroah-Hartman Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Soumya Negi Subject: [PATCH 2/4] staging: vme_user: Fix unbalanced {} in if-else blocks Date: Fri, 13 Oct 2023 16:47:14 -0700 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 13 Oct 2023 16:47:59 -0700 (PDT) Add missing braces so that {} are balanced in all arms of if-else statements as per Linux coding style. Issue found by checkpatch.pl Signed-off-by: Soumya Negi --- drivers/staging/vme_user/vme.c | 3 ++- drivers/staging/vme_user/vme_tsi148.c | 7 ++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c index 80083ea0fb53..6519a7c994a0 100644 --- a/drivers/staging/vme_user/vme.c +++ b/drivers/staging/vme_user/vme.c @@ -1849,8 +1849,9 @@ static int __vme_register_driver_bus(struct vme_driver *drv, if (vdev->dev.platform_data) { list_add_tail(&vdev->drv_list, &drv->devices); list_add_tail(&vdev->bridge_list, &bridge->devices); - } else + } else { device_unregister(&vdev->dev); + } } return 0; diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c index 2f5eafd50934..d549c22da534 100644 --- a/drivers/staging/vme_user/vme_tsi148.c +++ b/drivers/staging/vme_user/vme_tsi148.c @@ -2118,8 +2118,9 @@ static int tsi148_slot_get(struct vme_bridge *tsi148_bridge) if (!geoid) { slot = ioread32be(bridge->base + TSI148_LCSR_VSTAT); slot = slot & TSI148_LCSR_VSTAT_GA_M; - } else + } else { slot = geoid; + } return (int)slot; } @@ -2196,9 +2197,9 @@ static int tsi148_crcsr_init(struct vme_bridge *tsi148_bridge, dev_info(tsi148_bridge->parent, "CR/CSR Offset: %d\n", cbar); crat = ioread32be(bridge->base + TSI148_LCSR_CRAT); - if (crat & TSI148_LCSR_CRAT_EN) + if (crat & TSI148_LCSR_CRAT_EN) { dev_info(tsi148_bridge->parent, "CR/CSR already enabled\n"); - else { + } else { dev_info(tsi148_bridge->parent, "Enabling CR/CSR space\n"); iowrite32be(crat | TSI148_LCSR_CRAT_EN, bridge->base + TSI148_LCSR_CRAT); -- 2.42.0