Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1286926rdg; Fri, 13 Oct 2023 17:17:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2aZTW9mlz87dHMbz2NOfmQ7hoFxLgj9CkmW7WgsnNXOu9cPnb3rHaEwVF7+jZRzVgu83D X-Received: by 2002:a17:90b:3d0c:b0:261:2824:6b8c with SMTP id pt12-20020a17090b3d0c00b0026128246b8cmr2314612pjb.13.1697242652413; Fri, 13 Oct 2023 17:17:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697242652; cv=none; d=google.com; s=arc-20160816; b=Nrp0WcB4PZQYNIql8N2NAZdMOgPVAc2Zj7yQVQLuN9LsFPhz1HxOmT/3dCpuwKSpv7 ZXtMACKP1NzGN2/wNXl6/3ZWZg90ZLaQ2NvAOYiWbTOwjMQBGV2Vqm3TRIy8yI6KB+bu X5B/6KPGl6JGyFZOeJiCqLHU5NTef4y5A02gfSKtokapF3+/lvCegFiBvI0YhCGMlXMd uzp24Chr2bGLuvT5AbVZXqApRoDA6CmwaSX/XW+iHR8nsltHFpi50hLzq2bFHGQbuk9p pTnPPgi1UeGqKOp1zHDYJQqZPgOfn7ekqKtPG0dvCBiA79iUF0y121a6o1dcRjhgDfP1 VK0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=bMVTYw5qF/AxhljO0Rn8gnklo5bBJXyClUyD8o5V+dM=; fh=S20C/FVabSWRyXIaDp4EJkwORVYgvcPNWCWjaFjLVhs=; b=VhVE2PZWwAQKk/JFvcqTqihYVoKObE/1qMfR95XfonvcqA6t+04b/QDJe5VUGoaube SwEXPzwWxS68UigkREUppjn4/vEfKj0iB/voXyKuFfbVt3WkYrYQ/2vVMe/AJgj9ovez eh1Slpv/LJG+nvh3l/LaqdiEpXz32JS7a0aFU18aWBAZpXnDjdt1+S9tFSVOnJPPN3zy 96k2C/l6TDosxNBqu8vM6BaeF3NLtCmL3dKxCq41NVvWCOlNLEt/shTU15H1Qy5wyRUu j4iesQf/tvuAKzdWOAk89lbsx7ebwvPSYVePE/Lufc606YjUHZVd4pL4hx5DqdH79XtS 0icw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tcMBcBB5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id v1-20020a17090ac90100b0027762924984si1056697pjt.183.2023.10.13.17.17.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 17:17:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tcMBcBB5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 6193B807C862; Fri, 13 Oct 2023 17:17:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230469AbjJNARQ (ORCPT + 99 others); Fri, 13 Oct 2023 20:17:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjJNARP (ORCPT ); Fri, 13 Oct 2023 20:17:15 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5F11AD for ; Fri, 13 Oct 2023 17:17:14 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6733C433C7; Sat, 14 Oct 2023 00:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697242634; bh=vLvOaEPuC1BYwKAmpu9Nz8KcUbjUhS1EcNVCw0Qexxs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tcMBcBB5FCHwKhA9dv9Ovo+nzv7iNSvxGgpV4RLj/xfH6Dc6IeE8xvyZDpaPKDt9l KuwdfIU1UNuDoirqn45ByYsQIqP3x7XhlDWQxFzSGea8dwZjScPDhQ6qFg1sfd+WxU /XtGBrRqDlLaYr5D6wFvZYJZI7Ff42UXNkOn2lCotsOYsMDzTGnJmHOFQQPJqmP9Mn M95E7kOjkxfQya/m502KrF4vc6KntjsDYHaxrCxbJkIMY3VW+LDuMZv7nxhmAHpwpr fMzLm9QWcnV/BCZ+1DjYls4SWwjU7ea4NlcVybyGvxYrMyw+kFb6fPOyTBhTdaDd4O uk+sZAllHckXQ== Date: Fri, 13 Oct 2023 17:17:12 -0700 From: Jakub Kicinski To: Ma Ke Cc: jmaloy@redhat.com, ying.xue@windriver.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tipc: Fix uninit-value access in tipc_nl_node_get_link() Message-ID: <20231013171712.0817d810@kernel.org> In-Reply-To: <20231013070408.1979343-1-make_ruc2021@163.com> References: <20231013070408.1979343-1-make_ruc2021@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 13 Oct 2023 17:17:30 -0700 (PDT) On Fri, 13 Oct 2023 15:04:08 +0800 Ma Ke wrote: > Names must be null-terminated strings. If a name which is not > null-terminated is passed through netlink, strstr() and similar > functions can cause buffer overrun. This patch fixes this issue > by returning -EINVAL if a non-null-terminated name is passed. > > Signed-off-by: Ma Ke You have now sent 14 incorrect fixes to Linux networking. And not a single correct one. I would like to politely ask you to stop.