Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1351266rdg; Fri, 13 Oct 2023 21:08:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHm4kUllx5JLZg+MLZ8s1LyfDef/GRRtSD44fih8IBSueoEGAmmqgMjR4mNoN51vXVJdE6F X-Received: by 2002:a05:6a20:3941:b0:174:7f7:e19f with SMTP id r1-20020a056a20394100b0017407f7e19fmr9409190pzg.47.1697256519670; Fri, 13 Oct 2023 21:08:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697256519; cv=none; d=google.com; s=arc-20160816; b=xcq4fXlVGeWHJL1+/I2WtAc66hrJJgh20srTzdCv2uDPRTm1mscKpbxgqnTthhsjT+ TyuptSwduEK/nTTEGUdXUfnvdQ0P8U81eJSGfEZFi36ou2QsJsjA2eN2XPd4Wwth5mqN 8+Y22IZcragQLfgSusmP6Y+1nRmpF+n0TALg/y00nOFWxozQGq+jUyuBWO0fKgQePlRh NpN6Nh0pzY12dU4ucf78I59Px7xh6ImExSWKgJjK1pvFl7+MHxHWhQXvHgPya97RJYWk WjLyNrTwyCBDlIpU8j6QKYrluae46beS+kPLgvRSKLsu/Sh8UkDnBJL3RpUgOlCW5sER 8dAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XBj8j89zDLkCdR77CxvVfssAX/S5nXsHlrO7MTMB6qI=; fh=SpagKWgTxXymkBh4vV8litKhf4ubaiCSUzqnL/rRwUw=; b=AQhgS8dBdBR35wTMSEcURQMMJ3TszgwmCT5uLUwCRS/AQMx2dZCN5XGe/EPV+4Tw1O uX6cbxW7iN4TOc74hfqALjVbT/22X3G6VhK13Eju6WO/6EPa8rnljwWjNCstOrVIuvtL IgrmMaQE0VIrwlREHFKxOyUxMHvGUHZV1PUCODZwANhHD2ToxlRRr3d85BtCyg4HavDS BqzuXz5HvLGwnuQQNZLjPT9LEuXP+2mddAvFBKBE3K3QZcz8caWLEpTjOc3YAmsa78oY yk3WgHva8OIUD1RETFEKvJVG8Em4u9i0swu5nGfriBgzDfQyf/jTcbM5LioNjH9yoDEC rS7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=HV9MVLhf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id w4-20020a1709029a8400b001c589ba4a1bsi5855260plp.83.2023.10.13.21.08.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 21:08:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=HV9MVLhf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 25B3C80657ED; Fri, 13 Oct 2023 21:07:17 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231469AbjJNDv0 (ORCPT + 99 others); Fri, 13 Oct 2023 23:51:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjJNDvZ (ORCPT ); Fri, 13 Oct 2023 23:51:25 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A0D9C0; Fri, 13 Oct 2023 20:51:24 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-27b22de9b5bso1913621a91.3; Fri, 13 Oct 2023 20:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697255483; x=1697860283; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XBj8j89zDLkCdR77CxvVfssAX/S5nXsHlrO7MTMB6qI=; b=HV9MVLhf4GjJrRejeH2TczXvg16LXW7ggrKWn4oFvihIid3tLfIvegxxxHXGG0PXr4 efGAhOSltaWMzXjACIaAZC2NcfgE4QRatCzWII1HtKGxI2c3llbEf1UUnR/ENsRZ2oeP 9eoNnZR8Yj7sV9ulXFwIdekNNh707nlAmnvrA+vBCgWwrHMaRFb5ReDE0tt3drRzec06 ps5UrLs1uS59oN5MXRTNSVyyBDwAmv0acPoDQpO9Nd+jWVcvSIhHjDHkeEHTDWGlIoTC SilM9/cUUd00HOsUPm3kX2RlxGILRbQ/MELfrmtOUkUnHrW9e++B+eBe4triTA2Gk7KI fYTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697255483; x=1697860283; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XBj8j89zDLkCdR77CxvVfssAX/S5nXsHlrO7MTMB6qI=; b=wRgVl9ILPsKtuJASW+uY4s+gsYvgid+Ft9ItaKiN7I8ggd3+OlnFqXArLD7JGDkTWg ZE9MX2DVZRT1kL40WNjnC5JbTSvUHQAmvJkvFobi4cuteC75KFsnIvsVLGUQhaQKN0xT OknB2bNmMhLqxovIvJMk91YPbfchCFbY3n4oSJHtuJ9a0Ym+E25Xq+aSCUkIPy+GDmzs IJAbGdR5MVoGOi44UitS0YmuPdbhgyLMfjbvm9cyEGE7x/5ijXtIp7G2FAVK+NSgcpHc TUrTwcuRZjn/aBezED9AfaSWH6d1OYRVdtFhrRrdqI+A2kxk3Lp6DMAJQlies4ip0Ebu 9HKA== X-Gm-Message-State: AOJu0YwcV8EFIEb+7yWK2eNFkL7QrL9Tkw0AiJuJVlJ9tMPs6FoeVlhX RuhKcyFJyOV7zMGO8TNtQcs= X-Received: by 2002:a17:90b:1d8b:b0:27d:2ecd:6a23 with SMTP id pf11-20020a17090b1d8b00b0027d2ecd6a23mr4029697pjb.14.1697255483566; Fri, 13 Oct 2023 20:51:23 -0700 (PDT) Received: from pek-lxu-l1.wrs.com ([111.198.228.56]) by smtp.gmail.com with ESMTPSA id 29-20020a17090a01dd00b0027476c68cc3sm931099pjd.22.2023.10.13.20.51.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 20:51:23 -0700 (PDT) From: Edward AD To: horms@kernel.org Cc: bpf@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, syzbot+225bfad78b079744fd5e@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com, twuufnxlz@gmail.com Subject: Re: [PATCH] media: imon: fix stall in worker_thread Date: Sat, 14 Oct 2023 11:51:15 +0800 Message-ID: <20231014035114.1057686-2-twuufnxlz@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231013105909.GC29570@kernel.org> References: <20231013105909.GC29570@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HK_RANDOM_ENVFROM, HK_RANDOM_FROM,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 13 Oct 2023 21:07:17 -0700 (PDT) On Fri, 13 Oct 2023 12:59:09 +0200 Simon Horman wrote: > The code is already switching based on urb->status, > so unless the warning message is really desired, > perhaps this is more appropriate? > > diff --git a/drivers/media/rc/imon.c b/drivers/media/rc/imon.c > index 74546f7e3469..0e2f06f2f456 100644 > --- a/drivers/media/rc/imon.c > +++ b/drivers/media/rc/imon.c > @@ -1799,6 +1799,7 @@ static void usb_rx_callback_intf1(struct urb *urb) > > switch (urb->status) { > case -ENOENT: /* usbcore unlink successful! */ > + case -EPROTO: /* XXX: something goes here */ > return; > > case -ESHUTDOWN: /* transport endpoint was shut down */ Hi Simon Horman, Who added the above code where?