Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
MIME-Version: 1.0
References: <20231013085722.3031537-1-michal.wilczynski@intel.com>
 <6529727e18964_f879294ea@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <f7441bb4-c2c9-4eee-9fed-ad8b28de4788@intel.com> <652978deafdf8_f8792944c@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <1c2117f1-2d22-4d08-bd9f-8c821d4a1757@intel.com> <6529b493cc785_5c0d2947d@dwillia2-mobl3.amr.corp.intel.com.notmuch>
In-Reply-To: <6529b493cc785_5c0d2947d@dwillia2-mobl3.amr.corp.intel.com.notmuch>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sat, 14 Oct 2023 13:17:47 +0300
Message-ID: <CAHp75Vc1D3ut8x8_bVRSaEGy8EdUgfubxEsAbLEzJvNDx49f_g@mail.gmail.com>
Subject: Re: [PATCH v2] ACPI: NFIT: Fix local use of devm_*()
To:     Dan Williams <dan.j.williams@intel.com>
Cc:     "Wilczynski, Michal" <michal.wilczynski@intel.com>,
        nvdimm@lists.linux.dev, linux-acpi@vger.kernel.org,
        rafael@kernel.org, vishal.l.verma@intel.com, lenb@kernel.org,
        dave.jiang@intel.com, ira.weiny@intel.com,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Oct 14, 2023 at 12:20=E2=80=AFAM Dan Williams <dan.j.williams@intel=
.com> wrote:
> Wilczynski, Michal wrote:

...

> "The new cleanup.h facilities that arrived in v6.5-rc1 can replace the
> the usage of devm semantics in acpi_nfit_init_interleave_set(). That
> routine appears to only be using devm to avoid goto statements. The new
> __free() annotation at variable declaration time can achieve the same
> effect more efficiently.
>
> There is no end user visible side effects of this patch, I was motivated
> to send this cleanup to practice using the new helpers."

The end-user side effect (educational and not run-time) is that: "One
should really be careful about the scope of the devm_*() APIs and use
of them just for the sake of the RAII replacement is not the best
idea, while code is still working. Hence it gives a better example for
whoever tries to use this code for educational purposes."

--=20
With Best Regards,
Andy Shevchenko