Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Sat, 14 Oct 2023 14:28:03 +0200
From:   Herve Codina <herve.codina@bootlin.com>
To:     wangweidong.a@awinic.com
Cc:     lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        perex@perex.cz, tiwai@suse.com, shumingf@realtek.com,
        rf@opensource.cirrus.com, arnd@arndb.de, 13916275206@139.com,
        ryans.lee@analog.com, linus.walleij@linaro.org,
        ckeepax@opensource.cirrus.com, fido_max@inbox.ru,
        sebastian.reichel@collabora.com, colin.i.king@gmail.com,
        liweilei@awinic.com, trix@redhat.com, dan.carpenter@linaro.org,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 2/3] ASoC: codecs: Add code for bin parsing
 compatible with aw88399
Message-ID: <20231014142803.43f2aa9b@bootlin.com>
In-Reply-To: <20231013104220.279953-3-wangweidong.a@awinic.com>
References: <20231013104220.279953-1-wangweidong.a@awinic.com>
        <20231013104220.279953-3-wangweidong.a@awinic.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Weidong,

On Fri, 13 Oct 2023 18:42:19 +0800
wangweidong.a@awinic.com wrote:

> From: Weidong Wang <wangweidong.a@awinic.com>
> 
> Add aw88399 compatible code to the aw88395_lib.c file
> so that it can parse aw88399's bin file.
> 
> Signed-off-by: Weidong Wang <wangweidong.a@awinic.com>
> ---
>  sound/soc/codecs/aw88395/aw88395_lib.c | 3 +++
>  sound/soc/codecs/aw88395/aw88395_reg.h | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/sound/soc/codecs/aw88395/aw88395_lib.c b/sound/soc/codecs/aw88395/aw88395_lib.c
> index 87dd0ccade4c..692ad9fa65a6 100644
> --- a/sound/soc/codecs/aw88395/aw88395_lib.c
> +++ b/sound/soc/codecs/aw88395/aw88395_lib.c
> @@ -702,6 +702,7 @@ static int aw_dev_load_cfg_by_hdr(struct aw_device *aw_dev,
>  	}
>  
>  	switch (aw_dev->chip_id) {
> +	case AW88399_CHIP_ID:

Just a nitpick here.
You can use the same 'switch case' order as for the other 'switch cases' below.
I mean
   case AW88395_CHIP_ID:
   case AW88399_CHIP_ID:

With that done:
Reviewed-by: Herve Codina <herve.codina@bootlin.com>

>  	case AW88395_CHIP_ID:
>  		ret = aw88395_dev_cfg_get_valid_prof(aw_dev, *all_prof_info);
>  		if (ret < 0)
> @@ -791,6 +792,7 @@ static int aw_get_dev_scene_count_v1(struct aw_device *aw_dev, struct aw_contain
>  
>  	switch (aw_dev->chip_id) {
>  	case AW88395_CHIP_ID:
> +	case AW88399_CHIP_ID:
>  		for (i = 0; i < cfg_hdr->ddt_num; ++i) {
>  			if ((cfg_dde[i].data_type == ACF_SEC_TYPE_MULTIPLE_BIN) &&
>  			    (aw_dev->chip_id == cfg_dde[i].chip_id) &&
> @@ -832,6 +834,7 @@ static int aw_get_default_scene_count_v1(struct aw_device *aw_dev,
>  
>  	switch (aw_dev->chip_id) {
>  	case AW88395_CHIP_ID:
> +	case AW88399_CHIP_ID:
>  		for (i = 0; i < cfg_hdr->ddt_num; ++i) {
>  			if ((cfg_dde[i].data_type == ACF_SEC_TYPE_MULTIPLE_BIN) &&
>  			    (aw_dev->chip_id == cfg_dde[i].chip_id) &&

[...]


Best regards,
Hervé