Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Sat, 14 Oct 2023 14:25:50 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Linu Cherian <lcherian@marvell.com>
Cc:     Mike Leach <mike.leach@linaro.org>,
        "suzuki.poulose@arm.com" <suzuki.poulose@arm.com>,
        "james.clark@arm.com" <james.clark@arm.com>,
        "leo.yan@linaro.org" <leo.yan@linaro.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "coresight@lists.linaro.org" <coresight@lists.linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "conor+dt@kernel.org" <conor+dt@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        George Cherian <gcherian@marvell.com>
Subject: Re: [EXT] Re: [PATCH 1/7] dt-bindings: arm: coresight-tmc: Add
 "memory-region" property
Message-ID: <20231014-carbon-slept-9464499a4156@spud>
References: <20230929133754.857678-1-lcherian@marvell.com>
 <20230929133754.857678-2-lcherian@marvell.com>
 <CAJ9a7VhzARGmywQFPNCZ27D5UKEEPSR9_hmL5fo3daFWpB26Vg@mail.gmail.com>
 <PH0PR18MB500266F8C82877450DC9DDD2CED1A@PH0PR18MB5002.namprd18.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="xODWgUT9EMkdmFwT"
Content-Disposition: inline
In-Reply-To: <PH0PR18MB500266F8C82877450DC9DDD2CED1A@PH0PR18MB5002.namprd18.prod.outlook.com>
Precedence: bulk


--xODWgUT9EMkdmFwT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Oct 14, 2023 at 11:36:37AM +0000, Linu Cherian wrote:
> > > +      - description: Reserved meta data memory. Used for ETR and ETF=
 sinks.
> > > +
> > > +  memory-region-names:
> > > +    items:
> > > +      - const: trace-mem
> > > +      - const: metadata-mem
> > > +
> >=20
> > Is there a constraint required here? If we are using the memory area for
> > trace in a panic situation, then we must have the meta data memory area
> > defined?
> > Perhaps a set of names such as "etr-trace-mem", "panic-trace-mem" ,
> > "panic-metadata-mem", were the first is for general ETR trace in non-pa=
nic
> > situation and then constrain the "panic-" areas to appear together.
> > The "etr-trace-mem", "panic-trace-mem" could easily point to the same
> > area.
> >=20
> As noted above, we do not have other generic use case for these reserved =
regions now.
> Hence two regions/names, panic-trace-mem and panic-metadata-mem with cons=
traints kept as
>  minItems: 2 and maxItems: 2 would suffice ?

Whatever you do, please delete the -mem suffix.

--xODWgUT9EMkdmFwT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZSqWzgAKCRB4tDGHoIJi
0qX6AP9zu1/zSvIKb+Or0bUn+DYlqMtR8PQFTUOPeVyvcHN8SwEA1kUb5kBtLo7/
/tHTuGBcFv3oHZR+As70GVeHsRHGtwA=
=JnQT
-----END PGP SIGNATURE-----

--xODWgUT9EMkdmFwT--