Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Sat, 14 Oct 2023 17:14:17 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc:     Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH 0/2] iio: Add device tree support for silabs,si7005
Message-ID: <20231014171417.3a3448a1@jic23-huawei>
In-Reply-To: <20231012-topic-si7005_devicetree-v1-0-6c8a6fa7b3ec@gmail.com>
References: <20231012-topic-si7005_devicetree-v1-0-6c8a6fa7b3ec@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 12 Oct 2023 22:07:06 +0200
Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:

> This series adds device tree support for the IIO humidity sensor si7005
> and extends the trivial-devices binding to document the addition.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---
> Javier Carrasco (2):
>       iio: si7005: Add device tree support
>       dt-bindings: trivial-devices: add silabs,si7005
> 
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  drivers/iio/humidity/si7005.c                          | 7 +++++++
>  2 files changed, 9 insertions(+)
> ---
> base-commit: 401644852d0b2a278811de38081be23f74b5bb04
> change-id: 20231012-topic-si7005_devicetree-644b61b62178
> 
> Best regards,

Applied to the togreg branch of iiog.it and pushed out as testing for
0-day to take a look at it.

I'll note though that I would expect the fallback path for i2c bindings
to have worked here in which it matches the 'device' bit of the compatible
(ignoring the vendor) with entries in the i2c_device_id table.

I prefer explicit support like you have added here though as that
avoids clashes when different manufacturers use the same part number etc.

Thanks,

Jonathan