Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1637026rdg; Sat, 14 Oct 2023 10:02:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFTrFwcS4o4w1qfKaxb5DcLchvmbBQ8/gZ26gKTnsjYQ1Qr3m2o9cGtsF8QdPZfYVoA+BKW X-Received: by 2002:a05:6a20:7292:b0:14d:f41c:435a with SMTP id o18-20020a056a20729200b0014df41c435amr34795200pzk.39.1697302953067; Sat, 14 Oct 2023 10:02:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697302953; cv=none; d=google.com; s=arc-20160816; b=0XFuMRDnVWS/2eMl2htrZ3EsVnTQ8vqS0zYlEhCxU/qqI27jkIMaogWcbiCpCk5GS+ u916KqMi+Rm/AHXMH+HNEpvlsZgvQ6dOOO5jB1eGDcMSdkhWTIB9vW9AgVtLmnUQnO3f O7hTwiNPPgzM8O2BnXrk+F4pTVCzyMpxrGOSfQMAjUguJ3VJcOJ85tu5RldHB00B/mhQ PfNOqkcH3areCejm9HPyIo36vPEBuqR7+9aLDyHqqbePiyV6U29kgTPZjQttwQ8+/S/R H+yq+/EYJapZwuO1OUDbmdS+blhTxThYw5z5jBO7zdK4fXgJm0gE3o9+d860IXDh4h8J t6dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=a4JZARCX0Pv8VMrXuno0db3MocAdG6ErfH+YqMbuS/U=; fh=pbdktCCt2wJuv718rIqzCC/OpSnBg3qQmTtg1LbUuLo=; b=0V6bWzqdj1DjWblf9fw9Gs0yRjhP1GhXFJ/poz/FXOu3ftK8b0ruCaUGbErQdkeVf8 HlRRMWFAw9i95wxJX3y9xlqctFX0XahmU+46S4QW7+zjuDPl5XsVZrbdIZJnfLXXOvSG KMDDL6as5aZoKQh9qr57c7QEFkPryNPYe/uSTIKOOmNXW0gXK26Gg6A5vHYwOsbRCACZ ZPJAV6Xuvz8H7UVuHWZ/5MehNEnwCSao8zTPD+tnDcGdlAPpGt6rS5ZWEThazVtNSJAZ ZuKEh9+WAGJrN6CsuR/zVGZ2i0XXoYjpUxij9XhYTLOTTrDiFzKk0FrksOGPf9K1sUkV P4bQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=DdUpjYB7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id p5-20020a170902bd0500b001b045d65aedsi6659718pls.228.2023.10.14.10.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Oct 2023 10:02:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=DdUpjYB7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 2AF2B806BE1D; Sat, 14 Oct 2023 10:02:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233277AbjJNRCN (ORCPT + 99 others); Sat, 14 Oct 2023 13:02:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230016AbjJNRCL (ORCPT ); Sat, 14 Oct 2023 13:02:11 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24B3BB7; Sat, 14 Oct 2023 10:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=a4JZARCX0Pv8VMrXuno0db3MocAdG6ErfH+YqMbuS/U=; b=DdUpjYB7WQU2xK11g8gcDXl6jI 3fyUDr/ngjS2X/NwLJVATqMk2TX3T04y7ZxGE0caWTRWAG8bU1fB9lmMz4mHsxrVFPxYlknJ81Yml k0aaq31yg3gGf92qvc2Eoh7ERy79gRPn5GA9yRURmJckRL9x/xlyfXVioQCzynRzY11g=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qri1U-002BoU-VE; Sat, 14 Oct 2023 19:01:56 +0200 Date: Sat, 14 Oct 2023 19:01:56 +0200 From: Andrew Lunn To: Oleksij Rempel Cc: "David S. Miller" , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Woojung Huh , Arun Ramadoss , Conor Dooley , Krzysztof Kozlowski , Rob Herring , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, "Russell King (Oracle)" , devicetree@vger.kernel.org Subject: Re: [PATCH net-next v3 2/7] net: dsa: microchip: Set unique MAC at startup for WoL support Message-ID: References: <20231013122405.3745475-1-o.rempel@pengutronix.de> <20231013122405.3745475-3-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231013122405.3745475-3-o.rempel@pengutronix.de> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sat, 14 Oct 2023 10:02:30 -0700 (PDT) On Fri, Oct 13, 2023 at 02:24:00PM +0200, Oleksij Rempel wrote: > Set a unique global MAC address for each switch on the network at system > startup by syncing the switch's global MAC address with the Ethernet > address of the DSA master interface. This is crucial for supporting > Wake-on-LAN (WoL) functionality, as it requires a unique address for > each switch. > > Although the operation is performed only at system start and won't sync > if the master Ethernet address changes dynamically, it lays the > groundwork for WoL support by ensuring a unique MAC address for each > switch. I've not been following this patchset, so sorry if i make points others have asked on earlier versions. Maybe it would be good to add that the hardware only supports one MAC address for all ports for WoL, and its this address. At least that is my assumption. > + * ksz_cmn_set_default_switch_mac_addr - Set the switch's global MAC address > + * from master port. Florian is doing a search replace to make use of the word `conduit`. > @@ -3572,8 +3633,6 @@ static int ksz_switch_macaddr_get(struct dsa_switch *ds, int port, > const unsigned char *addr = slave->dev_addr; and this might need to change to user?