Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1676266rdg; Sat, 14 Oct 2023 11:59:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF1riWGq2eTbG/bqt2CZ3IxIgtOuag/LokGtFTNMuPYef2oRjrXYOqgYXGwSi88fV7D1EGv X-Received: by 2002:a05:6e02:1c84:b0:34c:bc7e:896c with SMTP id w4-20020a056e021c8400b0034cbc7e896cmr37906147ill.1.1697309988762; Sat, 14 Oct 2023 11:59:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697309988; cv=none; d=google.com; s=arc-20160816; b=zQuBog+9Re06Y/FjTqGYdaPbvQySBUVkl5vPT/v+zKGWCU9JmdXt21l/15EX6LznRY kPtUY/H9NAgAZ6zXbmLJbSSRZkEPht06uwgtYno3hXWuO6fZwHNrLHp/NMW/67JrZHN+ jNKc28GjOLFkwNZyygV4MTbqC3njuS/pAkS+zTiLRmkrL2F8DV9DaFLtfZLyrKUU+9// bJlzJLREKeBJR60TFq5kZTXVacoJzt0JwCQ/Xt6Z3suc9PZGzjPModp81VfffS4TpMde uHAl/1baiiDD700ta4w7BvwVH7MeFF6ySL0RQjlFfEiWNgpL3lIYB5Yg6qWAQGvy51Iq eyHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:feedback-id:dkim-signature :dkim-signature; bh=7lUanCG2PYVTMybzolsdF41bCQYpQ+LnkECeghf21F8=; fh=U/VCD8tN6j2z5z5ZJxoDB/2syeMUH2oSp1/QMNc1oSE=; b=tPQKNHu84HP0yZp5VAmPFkzEfM8xcsy4EY/PzqICIp6PALXCOL+qR74YspB+pe9X7N WPKKgPVXiSxF+JthuN3wpUeVm/uQAu4gEoxDzIL79yorjV2gpS+SRIb+OCeBEG7y3b4Z R4TR95AUmSusA9wD1a/b2NBdGT+rBJxh9krKNUZjqKyrUQcGo/VVi9ln9BYnN6HbVc1N 9KzYnGW67iEGAUItMfoCsdJPfF29qqpKTkQ8w7donyj069b6HF26ZHJqnfFccQSrOgZa T1ibpsNRCWAFWeGWuNVQv/zwpilgNTgpzO0RKddt9MbT9krObRIHfgu4XqNvrSc9Lpbr ExBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arndb.de header.s=fm2 header.b="abeD/3zk"; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=EjzP9+QY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id pc14-20020a17090b3b8e00b0027d33155aefsi3104994pjb.99.2023.10.14.11.59.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Oct 2023 11:59:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@arndb.de header.s=fm2 header.b="abeD/3zk"; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=EjzP9+QY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id AE30C805362D; Sat, 14 Oct 2023 11:59:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233208AbjJNS7U (ORCPT + 99 others); Sat, 14 Oct 2023 14:59:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232759AbjJNS7T (ORCPT ); Sat, 14 Oct 2023 14:59:19 -0400 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B4C0DA for ; Sat, 14 Oct 2023 11:59:17 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 08ACF5C0226; Sat, 14 Oct 2023 14:59:14 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Sat, 14 Oct 2023 14:59:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1697309954; x=1697396354; bh=7l UanCG2PYVTMybzolsdF41bCQYpQ+LnkECeghf21F8=; b=abeD/3zkHKd9D06Tdf 0kFJYkBYMSf8fLeO2A+Ncc49VYnIjYfhURlPCDfIRO1Yg2r9BzWjb+fSEzMoQrt5 07phx4wo8ituPc/vtv10p9VwB7+XLq+PY4Ugtt0DE0icSX0l6L1K7Ch2X/fV3BVi yunw9rcc9q2+hTSACWNzTt8vU4VkuJuCsYESG86Pj1j/O1z0FfzGXgLLXuPTTufN izl/2rUGFL2ZPLqxLQezGvA2kMxC+z4rvIe+39nRMIWFSId5/YXsXafLj+D3InV+ jb8WuVsz+0xvyFEOLa9nrixPGAe8G5VpvAtKM1adY6iXbxRRFlmlLRcm5LAUsspu 6TJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1697309954; x=1697396354; bh=7lUanCG2PYVTM ybzolsdF41bCQYpQ+LnkECeghf21F8=; b=EjzP9+QY3l9wtwaNQmBAUMdM+ST67 4BNDWpN1+JQmb7fLBG8gqvh7UQienQ4ASpLhSwIKyyLDqG2jZTOz43RZvJ/rsj6Y hOg5yGszFoJvV/Z1fCXLSGfqj60CZIZaga1AAryGN9y5RxQlifzufWXDFTnECyuG 2QwFzIT/6rJr6VXh0v4ix8s3id/U90+oKNrnBz9N7euAskw7eEN6j4+5EC5jeirA Fyh03rQUWN9OoS95YHlBYymRZ2nQCuB2EjjbMYwMTSm7SB7hctkR8TmrS5ZV6pp+ IEfnhRWrsfQ0fIa1wRPoF6hUUwzVcAwSCrmCjOWrcspqekHq4kw6h/XwQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrieehgddufedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepvefhffeltdegheeffffhtdegvdehjedtgfekueevgfduffettedtkeekueef hedunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id A0224B60089; Sat, 14 Oct 2023 14:59:13 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1019-ged83ad8595-fm-20231002.001-ged83ad85 MIME-Version: 1.0 Message-Id: <6e7a13f0-e98a-474a-b6ac-6e107788c74f@app.fastmail.com> In-Reply-To: <20231014164934.GA12750@matrix-ESPRIMO-P710> References: <20231014164934.GA12750@matrix-ESPRIMO-P710> Date: Sat, 14 Oct 2023 20:58:52 +0200 From: "Arnd Bergmann" To: "Philipp Hortmann" , "Greg Kroah-Hartman" , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: "Kalle Valo" , "Larry Finger" Subject: Re: [PATCH] staging: rtl8192u: Remove broken driver Content-Type: text/plain X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sat, 14 Oct 2023 11:59:45 -0700 (PDT) On Sat, Oct 14, 2023, at 18:49, Philipp Hortmann wrote: > Tests on rtl8192u hardware have shown that this driver is broken since > 2016. Remove broken driver. Find fix for two of the bugs in mailing list: > ("[RFC PATCH 0/2] staging: rtl8192u: Fix two crashing bugs") > > Signed-off-by: Philipp Hortmann Looks good to me, but I'd suggest adding the links to the patch you mention and the discussion: Link: https://lore.kernel.org/lkml/db98d9ac-7650-4a72-8eb9-4def1f17ea0d@app.fastmail.com/ Link: https://lore.kernel.org/lkml/cover.1697089416.git.philipp.g.hortmann@gmail.com/ Acked-by: Arnd Bergmann