Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1731600rdg; Sat, 14 Oct 2023 15:12:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG9CD2ooa3J1/ZWnlqpfde1A3qThQGaq5mTWcY9ZK1jejGzCTUdAakmc+jrXNbA9RrraD/j X-Received: by 2002:a17:90a:1906:b0:27d:3f08:cc21 with SMTP id 6-20020a17090a190600b0027d3f08cc21mr4599162pjg.5.1697321565344; Sat, 14 Oct 2023 15:12:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697321565; cv=none; d=google.com; s=arc-20160816; b=hix8duizbsymVpPMc6rODuj5j+g/DSeVixfElt+SPw2pGyYoMOBInriE81jI1Zmoi+ I5B/Rdr1G3gTxL3Z7sbaS8pRlIUPaHKms0D2A5fj65onBrXHesuQo1Up6Wddv9bwQZa9 WKQlypV+SGjaXhMZpzvV4rgMPS/yv798lLX3gxF14E39RCfXgddt8XOMSdfA0VOGxR5e m35v3hkpORuis40D+LoUiVCHsSbjT9bRGUysNzVDrl3liZBvAWJps4qA1SzCchhqqECX hUhw+EuGZuxGc65vPMUi5YF4uCEpToX5Eno62RVDlYm/EKCYFiiUoYg9MWIokIoxc5/b 6dGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=XyCWwm422SJgD21aOem6HKHPtuII/Mjlva+WgvLSWkI=; fh=+wr3+7XkIv9i/KFXnPIYKCFqRlpCd6XIbrrrh16wJeA=; b=zWpDvM/XuuDODBY7APV+f9zTuXFa9vFJTltVzeLyPU7jxof6itzpyj7IfDYpZ52Rf6 ONa5DQ41aNUJr9elC/2WdA5WgG8HkLqIX2HJgq0htgz0GxdIUV1dZ4x3zKwR6xpXnLAM U7L//y47UVEeI8g7xErbxLnYCU+3Smgg+2pd76mKAuftDOpvgZnk7qnEpdbLblz+EKvK 5JbDwrhv7gGMaLEDJ9AZBcSl4SysB5z0gLmQdiZWkREHvoCbkAj17btwdEsQJgwWrTmf FU5HGwQN3+hWAzUVnlaBJ9pxHyW7/c3qYT3J4mYmUQcTPlqhJYCJWpysEpgRPEAJY/66 oSHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=eLFhIYoT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id dw21-20020a17090b095500b0027b258f284esi2844263pjb.26.2023.10.14.15.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Oct 2023 15:12:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=eLFhIYoT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id DC9F9803D57B; Sat, 14 Oct 2023 15:12:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232947AbjJNWMc (ORCPT + 99 others); Sat, 14 Oct 2023 18:12:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229735AbjJNWMb (ORCPT ); Sat, 14 Oct 2023 18:12:31 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2F08C9 for ; Sat, 14 Oct 2023 15:12:27 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C14F9C433C8; Sat, 14 Oct 2023 22:12:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1697321547; bh=W9HiB33vcbVaedyeYlI+FUVAaV9QCtpHY2zsfWUBXtY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eLFhIYoTbp2lD+r2LSkm2pa+69fc8TLcXsIFoJV3LKcN5yNgn6KUrX5uFNb3ChYa2 lSK0C+wDXnwIImCe5oL5z6GYGk3iyM/qHFcB9GSkoYm092jYVwnTkUDhF9bh4OERI4 6H4ue2GhPyzdBLxEeGdcgFy5zXDHR79M8r4Q4i1Y= Date: Sat, 14 Oct 2023 15:12:21 -0700 From: Andrew Morton To: Alexey Dobriyan Cc: linux-kernel@vger.kernel.org, Peter Zijlstra Subject: Re: [PATCH] smp: fix __smp_processor_id() backup macro Message-Id: <20231014151221.46096b7fc17ccaeb691ff5d0@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sat, 14 Oct 2023 15:12:42 -0700 (PDT) On Sat, 14 Oct 2023 19:14:15 +0300 Alexey Dobriyan wrote: > Every __smp_processor_id usage doesn't have arguments and > every raw_smp_processor_id usage doesn't have arguments, > therefore "#define __smp_processor_id(x)" can not possibly work. > > ... > > --- a/include/linux/smp.h > +++ b/include/linux/smp.h > @@ -261,7 +261,7 @@ static inline int get_boot_cpu_id(void) > * regular asm read for the stable. > */ > #ifndef __smp_processor_id > -#define __smp_processor_id(x) raw_smp_processor_id(x) > +#define __smp_processor_id() raw_smp_processor_id() > #endif > It's been that way for at least 4 years. Presumably this is never used and should be removed?