Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1796287rdg; Sat, 14 Oct 2023 19:31:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGNHPp7PPlZXWZ/QlhK9Pv5svWwaYlQc9UabPza0mx+F5Gu5VyFfPvTCRZcyn8AzlSqS1V7 X-Received: by 2002:a05:6a21:7894:b0:158:143d:e215 with SMTP id bf20-20020a056a21789400b00158143de215mr6318185pzc.1.1697337062189; Sat, 14 Oct 2023 19:31:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697337062; cv=none; d=google.com; s=arc-20160816; b=IFTyg0vtvau7fJ9Q7jCkSndGpyAolnyQeTJUyLHOr6hrTcRETyzrdYoMvGXXccr3a1 fsoLpBnPGBbxQJVa6iMMOoEUFGolb5GlyaY86JDRLFjnmS21dHFaFO9quxzPENxd4biq OXxRJfshwBSHLodLcYgMzyDZgOxWVME3Ots+JwXEjHPrPiqioB2QsWb1lmfoIwmkUzCp xtu5NDNFx/3lMekKIltjm8GkH7ipGAwI/YxYPOwd8U9X2n1WWjvC78JMoUssBNR4Ye77 gmJiaLJtEZDoVrIQ255W6snwqAWzp+rmHdJAuYDrZMkn9FzysdaabM6mNRtrEah68H5H haow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=dhN/OgC882rYGvnQvvtSIJopNEt0MUImMTuzjqZB2Xk=; fh=bS6TIRXh9bkQ2oct6rKFhKYaG2ShmgGZpDXcWUVfOCI=; b=gZP9Fie21lZdahnbm2wCVhSf+6wrq6ooRA0qjJzUMM24k/3GxJgKSNqeZXT/QPswEp TmFW0YUKSpwoFlX6cNanvYp1jBGM4pwCySArv9JcbmibVU/UeHozTNbguXPqfdJnEOV9 4Jq4+xl/CMuW2cjwDGMD5EBBUj7E7YABvWt2cKvWEQRi2quOLznnDDN2VWg43WE8M8KL qbXu+qV/AxjbpobSuUr2L0AqaSgTBKfXZ2HZWZvHrcV87tyAj5bp6xH0uXoDcQa5GQ5k LlFii/Y/ZaJjl5PwZmIM/feib8RXl9Oa7FEaBy8iv1voesyAVuCG6jnlZB+bCtKqwKuu RyJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Odi8MenD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id z11-20020a6552cb000000b0057776b67494si7640644pgp.887.2023.10.14.19.31.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Oct 2023 19:31:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Odi8MenD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 9525E80A9E39; Sat, 14 Oct 2023 19:30:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233392AbjJOCaD (ORCPT + 99 others); Sat, 14 Oct 2023 22:30:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233328AbjJOCaB (ORCPT ); Sat, 14 Oct 2023 22:30:01 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36DC8D8 for ; Sat, 14 Oct 2023 19:29:59 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6bd73395bceso168490b3a.0 for ; Sat, 14 Oct 2023 19:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1697336998; x=1697941798; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dhN/OgC882rYGvnQvvtSIJopNEt0MUImMTuzjqZB2Xk=; b=Odi8MenDvKuf/AZcwNneuZFISXmSP4H8U2QnTOs9+tLcXMyrQNLcEq5oM1t0ELa5XI DPAWGPpjkHyon7/JTTZAgPY/HteOJpRDWphxmeF4BOphMAHqnt7RZBDW6IVJZGIoGDLr NPKv1l4UeDBU8qczVFi6AZfXG/jzFv++t1ilc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697336998; x=1697941798; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dhN/OgC882rYGvnQvvtSIJopNEt0MUImMTuzjqZB2Xk=; b=p7U+SGEt1KaK2+XZ5PhmnhAp6zXOQVH2JakNdmvIPgnRZU6VuZFJwieh3qk/vm2kwK hrqa8l/cTltLzl018faoA78/UgAm5OedYrMaP1nRXtH/yvv5XAwhg9LOm2muKt/tk87y fwzwR8NcsOEEQkN2D16Wan6OQ/dLVHZEMcBsiZmiKj4SBy2enWFYj/EaIC+Y8NI5xq/r BX42pIvXweyDcs1F7MOcCY2fbPVaOIkBqadF+0YYmNP0g26Fpx+rl/0l5sKqZVjrSeEH xsltG8WBIhNFxFw5kQRqb/G8+6T0nySta3UwbjyLF8Y5lNb3zPCQ5KIIiJdp79BGpkcR TkMw== X-Gm-Message-State: AOJu0YyV0wt2K3H0xCAUBzJpiHUIxNjGNf0DQbVMB9M/ck4wDQ1kPIAL SybDiH4OFUwHZvhMUkzfcXqtig== X-Received: by 2002:a05:6a00:318c:b0:68f:cdb8:ae33 with SMTP id bj12-20020a056a00318c00b0068fcdb8ae33mr5233919pfb.10.1697336998549; Sat, 14 Oct 2023 19:29:58 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id t1-20020a63b701000000b005776446f7cbsm4589302pgf.66.2023.10.14.19.29.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Oct 2023 19:29:57 -0700 (PDT) Date: Sat, 14 Oct 2023 19:29:57 -0700 From: Kees Cook To: Christophe JAILLET Cc: Pravin B Shelar , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Gustavo A. R. Silva" , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, dev@openvswitch.org, linux-hardening@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v2 2/2] net: openvswitch: Annotate struct mask_array with __counted_by Message-ID: <202310141928.23985F1CA@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sat, 14 Oct 2023 19:30:31 -0700 (PDT) On Sat, Oct 14, 2023 at 08:34:53AM +0200, Christophe JAILLET wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > Signed-off-by: Christophe JAILLET > --- > v2: Fix the subject [Ilya Maximets] > fix the field name used with __counted_by [Ilya Maximets] > > v1: https://lore.kernel.org/all/f66ddcf1ef9328f10292ea75a17b584359b6cde3.1696156198.git.christophe.jaillet@wanadoo.fr/ > > > This patch is part of a work done in parallel of what is currently worked > on by Kees Cook. > > My patches are only related to corner cases that do NOT match the > semantic of his Coccinelle script[1]. > > In this case, in tbl_mask_array_alloc(), several things are allocated with > a single allocation. Then, some pointer arithmetic computes the address of > the memory after the flex-array. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > --- > net/openvswitch/flow_table.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/openvswitch/flow_table.h b/net/openvswitch/flow_table.h > index 9e659db78c05..f524dc3e4862 100644 > --- a/net/openvswitch/flow_table.h > +++ b/net/openvswitch/flow_table.h > @@ -48,7 +48,7 @@ struct mask_array { > int count, max; > struct mask_array_stats __percpu *masks_usage_stats; > u64 *masks_usage_zero_cntr; > - struct sw_flow_mask __rcu *masks[]; > + struct sw_flow_mask __rcu *masks[] __counted_by(max); > }; Yup, this looks correct to me. Thanks! Reviewed-by: Kees Cook -- Kees Cook