Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Sun, 15 Oct 2023 12:14:02 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     chenguohua@jari.cn, linux@armlinux.org.uk
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sfp: Clean up errors in sfp.h
Message-ID: <ZSt1GkmyO_6iit3-@debian.me>
References: <1a7c167f.942.18b26fb3ec9.Coremail.chenguohua@jari.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="v4L48laAikyil5vP"
Content-Disposition: inline
In-Reply-To: <1a7c167f.942.18b26fb3ec9.Coremail.chenguohua@jari.cn>
Precedence: bulk


--v4L48laAikyil5vP
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 13, 2023 at 11:01:21AM +0800, chenguohua@jari.cn wrote:
> Fix the following errors reported by checkpatch:
>=20
> ERROR: spaces required around that '=3D' (ctx:VxW)
>=20
> Signed-off-by: GuoHua Cheng <chenguohua@jari.cn>
> ---
>  include/linux/sfp.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/include/linux/sfp.h b/include/linux/sfp.h
> index 9346cd44814d..725c8381a347 100644
> --- a/include/linux/sfp.h
> +++ b/include/linux/sfp.h
> @@ -289,10 +289,10 @@ enum {
>  	SFF8024_ENCODING_8B10B		=3D 0x01,
>  	SFF8024_ENCODING_4B5B		=3D 0x02,
>  	SFF8024_ENCODING_NRZ		=3D 0x03,
> -	SFF8024_ENCODING_8472_MANCHESTER=3D 0x04,
> +	SFF8024_ENCODING_8472_MANCHESTER =3D 0x04,
>  	SFF8024_ENCODING_8472_SONET	=3D 0x05,
>  	SFF8024_ENCODING_8472_64B66B	=3D 0x06,
> -	SFF8024_ENCODING_8436_MANCHESTER=3D 0x06,
> +	SFF8024_ENCODING_8436_MANCHESTER =3D 0x06,
>  	SFF8024_ENCODING_8436_SONET	=3D 0x04,
>  	SFF8024_ENCODING_8436_64B66B	=3D 0x05,
>  	SFF8024_ENCODING_256B257B	=3D 0x07,
> @@ -306,11 +306,11 @@ enum {
>  	SFF8024_CONNECTOR_MT_RJ		=3D 0x08,
>  	SFF8024_CONNECTOR_MU		=3D 0x09,
>  	SFF8024_CONNECTOR_SG		=3D 0x0a,
> -	SFF8024_CONNECTOR_OPTICAL_PIGTAIL=3D 0x0b,
> +	SFF8024_CONNECTOR_OPTICAL_PIGTAIL =3D 0x0b,
>  	SFF8024_CONNECTOR_MPO_1X12	=3D 0x0c,
>  	SFF8024_CONNECTOR_MPO_2X16	=3D 0x0d,
>  	SFF8024_CONNECTOR_HSSDC_II	=3D 0x20,
> -	SFF8024_CONNECTOR_COPPER_PIGTAIL=3D 0x21,
> +	SFF8024_CONNECTOR_COPPER_PIGTAIL =3D 0x21,
>  	SFF8024_CONNECTOR_RJ45		=3D 0x22,
>  	SFF8024_CONNECTOR_NOSEPARATE	=3D 0x23,
>  	SFF8024_CONNECTOR_MXC_2X16	=3D 0x24,

To be consistent, other enum's indentation should also be aligned to match
the longest ones (MANCHESTER and PIGTAIL).

In netdev, though, checkpatch fixes are not welcome (auto-rejected) as these
make stable backports more convoluted.

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--v4L48laAikyil5vP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZSt1GgAKCRD2uYlJVVFO
o32hAP9QYVZ7joG4QINC/SIgwAKup3NqZVPF6Nd+fO62v8gFhwEAikdG0aJCslJx
37l5zFrIz6QL6e2JYEElblDRIDNp4gc=
=mbEP
-----END PGP SIGNATURE-----

--v4L48laAikyil5vP--