Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1839726rdg; Sat, 14 Oct 2023 22:37:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFwxMHOTmIpOtkPD3OpEYdeCAAzK7pgGpRBECxrpg6L5BQZ0mcjRw1gb/513oepvNFfY9KW X-Received: by 2002:a92:cd8a:0:b0:357:43a5:acf8 with SMTP id r10-20020a92cd8a000000b0035743a5acf8mr18797951ilb.17.1697348265854; Sat, 14 Oct 2023 22:37:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697348265; cv=none; d=google.com; s=arc-20160816; b=xuQUvtvQu3rJR68z126tdgthPS0ZhK8T5hFCdilPnDDOq5As+GJpXOJaM3MmAIernh Rak98d9OmHl6h159fgxlpuimLDU/x+H/EHN6Oj6zx5olaLkOHtA8ZPRqX2QFENbEWIUo y8OA4oMPNjWGvbrVJQWnYZz9B2+FmVz4hpAWmER0nMAZ5m6AUtXC1/ENadhauL48t7XB d2hX8QiBf6L3XIW1GqGwVitreP3itbOM53ORLrt91Um875FWu0C4agVOrw2ntHGws2Jt SIPnbiPSb5pOz0M89UKvlSVG9nvc18nFVDgxa060NQb0u2fBIDSyoaedKKNIwBRScZ7H n/fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RRpnhmtTe4AzXIJShiNgb4gCkmt2PmoziWLIJ3d7Kx0=; fh=QB4z44s7ob/tfnCKJVkAHaU9G1siH9L7UzNZPuykhZI=; b=UBlvofg+pFOxHl5qDYWo1ElM3S6pGUkfWN6AxXIUZN+qckvf7j+Bn6/XBW86jEnrob tm6vsmkF0wImzAVCmrVkBARyLNbtVKtsjyjqJR1tssMBHF8Ae50IYTvNDsH1/mNqFrHw xeAHZlDIs0+gaViMqC1ktzjzT9PUuz49uE3xlEDwArwgScCZCpht/vbA2GiCV6jAat8i Cjs0qTDqI0abEw5G2qy8gG8NoW3qbK95JMSS5adO5WyET4VucxFq5vIc/Gwlk3FURiax wwzeJRIK/hhGB/58/a5u2TjpOR40++29g+NU+AIYYvfsMrkfzEXMHtYsoPz1yvwi0XOV NURg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rhLyxXtE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id bj3-20020a170902850300b001b7d2b55d8asi7489190plb.626.2023.10.14.22.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Oct 2023 22:37:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rhLyxXtE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id B5A2F804C66F; Sat, 14 Oct 2023 22:37:43 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233483AbjJOFhf (ORCPT + 99 others); Sun, 15 Oct 2023 01:37:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230091AbjJOFhe (ORCPT ); Sun, 15 Oct 2023 01:37:34 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 268FFA2 for ; Sat, 14 Oct 2023 22:37:33 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4639FC433C8; Sun, 15 Oct 2023 05:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697348252; bh=cYiN/rDOSxfdgPDehCPj0uNGMsIsA2nH4XQt//rThOg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rhLyxXtE2YBZQ/6TVBbyph8qQnh9EKQFvL4amq6L6wMvvedNvdj1VFhX2Q1Rw8k3u dPGHtxvdcH6U4pT8iuhtYA1TUNAMclhlqexO9vKOYSHz2zVU/YuUH0WJmLkj3ePn7E QCQhfdv6vB92+YmfhXcABwvLiMa4GXXWmz+hpk8I= Date: Sun, 15 Oct 2023 07:37:30 +0200 From: Greg Kroah-Hartman To: Soumya Negi Cc: Jonathan Kim , Dean ahn , outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] tty: gdm724x: Add blank line after declaration Message-ID: <2023101551-placidly-garnish-3ee7@gregkh> References: <3b24ca9976cf873dbaadb499e09d7b545e9db89c.1697184167.git.soumya.negi97@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3b24ca9976cf873dbaadb499e09d7b545e9db89c.1697184167.git.soumya.negi97@gmail.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sat, 14 Oct 2023 22:37:43 -0700 (PDT) On Fri, Oct 13, 2023 at 01:26:35AM -0700, Soumya Negi wrote: > Fix WARNING: Missing a blank line after declarations > Issue found by checkpatch.pl > > Signed-off-by: Soumya Negi > --- > drivers/staging/gdm724x/gdm_tty.c | 1 + > 1 file changed, 1 insertion(+) Why do you have "tty:" as the prefix for a staging driver? Shouldn't it be "staging: gdm724x: ...."? thanks, greg k-h