Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <ZSjpQlUcyOoYv4Yh@lab-ubuntu> <62778e4d-cc2e-4310-b334-52b54cfe7e79@kadam.mountain>
In-Reply-To: <62778e4d-cc2e-4310-b334-52b54cfe7e79@kadam.mountain>
From:   Calvince Otieno <calvncce@gmail.com>
Date:   Sun, 15 Oct 2023 10:39:20 +0300
Message-ID: <CADFX3OSqnjGrxRazmmcBuGUOyv4TuXGEJ8fqbAhR4X9j0rn6sA@mail.gmail.com>
Subject: Re: [PATCH] staging: wlan-ng: remove unused functions
To:     Dan Carpenter <dan.carpenter@linaro.org>
Cc:     outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Luke Koch <lu.ale.koch@gmail.com>,
        Bagas Sanjaya <bagasdotme@gmail.com>,
        Simon Horman <horms@kernel.org>, linux-staging@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Oct 15, 2023 at 10:38=E2=80=AFAM Calvince Otieno <calvncce@gmail.co=
m> wrote:
>
> On Fri, Oct 13, 2023 at 12:02=E2=80=AFPM Dan Carpenter <dan.carpenter@lin=
aro.org> wrote:
>
> On Fri, Oct 13, 2023 at 09:52:50AM +0300, Calvince Otieno wrote:
> > The following functions were defined in the prism2mgmt.h file but neith=
er
> > declared nor used anywhere. It is recommended that they be removed.
> >
> >       - void prism2mgmt_get_grpaddr(u32 did, struct p80211pstrd *pstr,
> >                                     struct hfa384x *priv);
> >       - int prism2mgmt_set_grpaddr(u32 did,
> >                                  u8 *prism2buf, struct p80211pstrd *pst=
r,
> >                                  struct hfa384x *priv);
> >       - int prism2mgmt_get_grpaddr_index(u32 did);
> >
>
> Could you look up when the functions were deleted and add that
> information to the commit message?
>
>     These functions were removed five years ago in commit 123412341234
>     ("delete functions").
>
> regards,
> dan carpenter

Hello Dan,
I am  not able to locate exactly when these functions were deleted.
I have checked the commit history of these files prism2mgmt.h and prism2mgm=
t.c,
but, I can't find any commit relating to the removal of the above functions=
.

--=20
Kind regards,
Calvince Otieno