Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Sun, 15 Oct 2023 23:44:33 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC:     Peter Zijlstra <peterz@infradead.org>,
        <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>,
        "Mel Gorman" <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Swapnil Sapkal <Swapnil.Sapkal@amd.com>,
        Aaron Lu <aaron.lu@intel.com>, Tim Chen <tim.c.chen@intel.com>,
        K Prateek Nayak <kprateek.nayak@amd.com>,
        "Gautham R . Shenoy" <gautham.shenoy@amd.com>, <x86@kernel.org>
Subject: Re: [RFC PATCH] sched/fair: Introduce WAKEUP_BIAS_PREV_IDLE to
 reduce migrations
Message-ID: <ZSwI4UTrXLNEWwKM@chenyu5-mobl2.ccr.corp.intel.com>
References: <20231012203626.1298944-1-mathieu.desnoyers@efficios.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231012203626.1298944-1-mathieu.desnoyers@efficios.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z9yeQCMPue0nyG43VzzR65j7J3+hG8ejUTQq/d+iDBToBKEzQX7EjFhSuhDf?=
 =?us-ascii?Q?hyiIvHmDQqcRJs45qF4qqaaqt+GgwqrBxHiaraM/qdb05xmkc2MPUdy/GmJk?=
 =?us-ascii?Q?0ayi8gZs6FFq3sX1LG4ct6NQsTjBrS2qBEHvN6xDWs4zJbKtRwc3Xfbtz1Gp?=
 =?us-ascii?Q?NyWDBLEPNAWp1LHtJQaHKEsOtaiwJBZ2O7QlcMfh2uKsi5CLLV4HbDt4FxaY?=
 =?us-ascii?Q?jyXs2SKHXDOd8sAF8W1qZgSBjC9cJpDN6FGAL00Msx8R2B7bxG73katnjSJV?=
 =?us-ascii?Q?D3iz5/NQZBBzAXCHa2oOqdrfpqKu2GV5l6rlph1H1y93oPiBy8ROc7ToLovs?=
 =?us-ascii?Q?eQVK1mSQwG3lS+qQY6Mf7YeWRTwVr8ZCMiRQ0IB3WkEbi8Va/CE58WEqodnk?=
 =?us-ascii?Q?Qhl5F77q5SLLPWGz2atdY7sMzX2O5ZB8LbyJ71L9ffZDfXeq1ZkTcev4Zljy?=
 =?us-ascii?Q?4qLdC7iRxdZwUCD4gXMvJjPXELmFOvEuKXj7nuFdcfHK8oUN3nTEI0aFwWMY?=
 =?us-ascii?Q?qzMBjXgxp6ItHvUUylk52b9rDGh2XDTjH2gxgK0cpGVYLYLujtFxopa++L1T?=
 =?us-ascii?Q?EyJFu+l6hkELd0s0TztzGL9v6/rq5wkge8i6bs0Fmg63BAH7GDVyntUprAoG?=
 =?us-ascii?Q?aRSoH0BgjtL+IZli7xl1itkh6OxkZO7EMxJsLRZrryQxWN/SyPytamZS2K2C?=
 =?us-ascii?Q?xQEE3GT8hXS56jpkM0yn5ZXGCHyOUc0XIjKzlWBzMNeBgatPR0ZGJO7Ied8d?=
 =?us-ascii?Q?7bCHVDi5zb9aht0DS4AOYHAjo0tOiT623enPwkS18i1lAdy3vCvbjw46XepE?=
 =?us-ascii?Q?Y301cxRR7tFQIHv+vTCqTaI/O/YGIMoch255CShmBlb3UYskvQD/SYCqO+CP?=
 =?us-ascii?Q?G9pBkx4f5G9uN6uI1gQAaywCQrN5sKEwavMPGcVXfOerCMxYk1WcRSI54QCV?=
 =?us-ascii?Q?FrQ3WBVBw2vxaPaSUWmem61m7EoJg6kYjJhGNPKxPi+ChPwS9HM6NStWCBdX?=
 =?us-ascii?Q?fBsR7mvpfVfhv8RJgCiaRX6dS7ieDUi5Hjzg46f+OaiyGX+vsvzzsRfGafKE?=
 =?us-ascii?Q?k0ZBRxnZtByL9tuapWx9mVPcJsicupel44MqrlcN98LLjvgZ+EKFaaP8AvmV?=
 =?us-ascii?Q?PA6EynTiOgpckBxcEhg8jtfutylFaf9fe0FWUjY4pxN6d2bqYt1JAObmslkH?=
 =?us-ascii?Q?CXzffSGWKBS9XrAUtSghTsSfpAiHhnuEPFB78Q4DQWmP2HWO+x9vZrlqcuJW?=
 =?us-ascii?Q?cZnORqhNkT2azseszoDqisygnHfb2sZHy1PS3/v6dsWKjplPIz59EBrfgqF1?=
 =?us-ascii?Q?ZFfQHPDHrlvERn3Rg9TfuKFA3oKU3Au1h/Hidpu5O+WEOHgYMHBFS9Tj+q5Z?=
 =?us-ascii?Q?zqizIi4loQOcMr9jYtkbybLv2oj71hNwjfnqQTx27esmgqr/JHSpmHpC73ur?=
 =?us-ascii?Q?hojMxErMWUnLePOi0exnB4Z3B2EOK1zs/u3C2gKVryPdJzUplBVSUSNu+LbC?=
 =?us-ascii?Q?Eeb3IU/UjJoMwsSo4c5+oixrUhevflpx9XGG5go8hA6baHQI09YEr/xFmOyS?=
 =?us-ascii?Q?sKufv5zfOnezsfuaoQoK950KsQoPRPEr9GLsHD+J?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b589cad1-6437-455e-a1f9-08dbcd95ab4d
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2023 15:44:51.3025
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S8UQroNRTuFd//8WvUoDo9uzlX3TC0qG7/qw1730/px+OniUjSuXCGEN7mJkPNAyDlfrFKdOvODAnBRc7xQVYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7640
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sun, 15 Oct 2023 08:46:39 -0700 (PDT)

On 2023-10-12 at 16:36:26 -0400, Mathieu Desnoyers wrote:
> Introduce the WAKEUP_BIAS_PREV_IDLE scheduler feature to reduce the
> task migration rate.
> 
> For scenarios where the system is under-utilized (CPUs are partly idle),
> eliminate frequent task migrations from almost idle CPU to completely
> idle CPUs by introducing a bias towards the previous CPU if it is idle
> or almost idle in select_idle_sibling(). Use 1% of the CPU capacity
> of the previously used CPU as CPU utilization "almost idle" cutoff.
>
> +
> +/*
> + * A runqueue is considered almost idle if:
> + *
> + *   cpu_util_without(cpu, p) / 1024 <= 1% * capacity_of(cpu)

util_avg is in the range [0:1024], thus cpu_util_without(cpu, p) / 1024
is <= 1, and 1% * cap is 10, so 1 <= 10 is always true.
I suppose you want to compare:
 (cpu_util_without(cpu, p) / capacity_orig_of(cpu)) <= 1% ->
    cpu_util_without(cpu, p) * 100 <= capacity_orig_of(cpu) ?

thanks,
Chenyu