Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2058825rdg; Sun, 15 Oct 2023 09:10:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE3ViW2ZxyRmYe8Ac5JRARnXGYmndkk1KXkdIxHyIP9mXHFEavKNroxez3sqe1ChMSezgiv X-Received: by 2002:a17:902:ca14:b0:1c9:ca02:6451 with SMTP id w20-20020a170902ca1400b001c9ca026451mr9139709pld.39.1697386247717; Sun, 15 Oct 2023 09:10:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697386247; cv=none; d=google.com; s=arc-20160816; b=D1lThKGbRKy73ZIAmMLYtVCHFlsf6N0UqDRAaAP70XPifrO0Q8Y6xRzjpxcQR2japS BO07oEJgV0wHQwQRK27rtInfZ0y4spbt+xl5DjxAd3PPFoLKk+SIFZkQ5hiOAh0YHZSi FUKpASiuT6pRXTdr8BMXgpDoRtl4/M+aG1UfiaT/JzMiN7NZYUfmyDcoiJEqdBEj5tP7 3QkqH1EIvz8mfwjTa2RctRpKk0EJbF/+3dk87vkhhISfFjx8x3TkaEu51PtwHedqnqcw 1rMz0ATHhqS7/M1Bp2fAyTUN96McrI64ZeW2s3jHntB25Cb92qbIzRIV6aNcRMRvQjlo nppg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Sq5mMNQzd4Rvz6ccXVDVDJH9DUFHJSbs7P8ROP3fDLI=; fh=96xpKCwFENOsvMo2kPOr6D74rQA3lodqCzR9LZFzJ2I=; b=ArNUNp434OtAro1Lnv1dxWuOgdgZPaRM7iDmUalBtSXlRFH0qXP84SKoYkjOFw115l mkOv/dsc9VonZqD2hihK5xYZ1XSHv3qQSZIcS7NvZbXjjKvStqJ41n+cCCNnu+RMVRQx ec7NDx/CE0KwFzZu9uGs754vf2koUjEhm0ybOVOiU80LPKO4dfr+aMajxBWs7nIlANro 9EUcrfn3r7Br0cvj47BsrKJR7rWL46vMOa8fz6fXutTwxnTIIDJPcPtKrEZt6GgEkiY5 oysga4duysNjUAKq7oEi5Bh3LR1yKzveVZsc0r5j/I3HmBtNytLn+H6pdydkegPvdeBN WBvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TifoANNf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id l1-20020a170903244100b001c3e9b0bae1si9546308pls.443.2023.10.15.09.10.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 09:10:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=TifoANNf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 77C6C807C85C; Sun, 15 Oct 2023 09:10:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230139AbjJOQJw (ORCPT + 99 others); Sun, 15 Oct 2023 12:09:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbjJOQJv (ORCPT ); Sun, 15 Oct 2023 12:09:51 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBD47A3 for ; Sun, 15 Oct 2023 09:09:50 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2767C433C7; Sun, 15 Oct 2023 16:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697386190; bh=9JuI03ZP/U0XMwAWcNqdQJ5I2Au2PAR4LpQx78SO3NI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TifoANNffvYUf3VBdZPNEO0sdMjAN9hMkqJgAQzesVprLSTCf85zi24+lSVOGUigX 0UNMJEGO0XN9qtQXLGVod5EeavGnI2fwaDMBQStvbCYWtYu8m933Vgfv1ARaQ87Yn2 7oz7+9VUVP2Swz/2b/5ni9YzVaDG8RYyIlwKu5L0= Date: Sun, 15 Oct 2023 18:09:47 +0200 From: Greg KH To: Gilbert Adikankwu Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192u: Align descendant arguments Message-ID: <2023101519-cane-backlands-b376@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 15 Oct 2023 09:10:15 -0700 (PDT) On Sun, Oct 15, 2023 at 08:44:18AM +0100, Gilbert Adikankwu wrote: > Adhere to Linux kernel coding style. > > "...A very commonly used style is to align descendants to a function > open parenthesis" - (Excerpted from Linux kernel coding style (#2)) > > Reported by checkpatch: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Gilbert Adikankwu > --- > drivers/staging/rtl8192u/r8180_93cx6.c | 4 ++-- > drivers/staging/rtl8192u/r8190_rtl8256.c | 16 +++++++-------- > drivers/staging/rtl8192u/r8192U_core.c | 20 +++++++++--------- > drivers/staging/rtl8192u/r8192U_dm.c | 24 +++++++++++----------- > drivers/staging/rtl8192u/r819xU_firmware.c | 4 ++-- > drivers/staging/rtl8192u/r819xU_phy.c | 2 +- > 6 files changed, 35 insertions(+), 35 deletions(-) > > diff --git a/drivers/staging/rtl8192u/r8180_93cx6.c b/drivers/staging/rtl8192u/r8180_93cx6.c > index 2527cea60e3e..1453a0307eb4 100644 > --- a/drivers/staging/rtl8192u/r8180_93cx6.c > +++ b/drivers/staging/rtl8192u/r8180_93cx6.c > @@ -114,7 +114,7 @@ int eprom_read(struct net_device *dev, u32 addr) > ret = 0; > /* enable EPROM programming */ > write_nic_byte_E(dev, EPROM_CMD, > - (EPROM_CMD_PROGRAM << EPROM_CMD_OPERATING_MODE_SHIFT)); > + (EPROM_CMD_PROGRAM << EPROM_CMD_OPERATING_MODE_SHIFT)); > force_pci_posting(dev); > udelay(EPROM_DELAY); > > @@ -165,6 +165,6 @@ int eprom_read(struct net_device *dev, u32 addr) > > /* disable EPROM programming */ > write_nic_byte_E(dev, EPROM_CMD, > - (EPROM_CMD_NORMAL << EPROM_CMD_OPERATING_MODE_SHIFT)); > + (EPROM_CMD_NORMAL << EPROM_CMD_OPERATING_MODE_SHIFT)); > return ret; > } > diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c > index 54747fda552f..a81e88894e01 100644 > --- a/drivers/staging/rtl8192u/r8190_rtl8256.c > +++ b/drivers/staging/rtl8192u/r8190_rtl8256.c > @@ -46,17 +46,17 @@ void phy_set_rf8256_bandwidth(struct net_device *dev, enum ht_channel_width Band > priv->card_8192_version == VERSION_819XU_B) { > /* 8256 D-cut, E-cut, xiong: consider it later! */ > rtl8192_phy_SetRFReg(dev, > - (enum rf90_radio_path_e)eRFPath, > - 0x0b, bMask12Bits, 0x100); /* phy para:1ba */ > + (enum rf90_radio_path_e)eRFPath, > + 0x0b, bMask12Bits, 0x100); /* phy para:1ba */ Now you added a different checkpatch warning, you can't say you fix one and then add another, sorry. greg k-h