Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2130771rdg; Sun, 15 Oct 2023 12:36:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF47WLALHtsvJedNYHjabLs/cIvxH8cXeiq7ge7ZAowdvO91wHe4dadpIj1YHhbQd+aeIEp X-Received: by 2002:a05:6358:91c:b0:134:c8cb:6a00 with SMTP id r28-20020a056358091c00b00134c8cb6a00mr36028663rwi.12.1697398581223; Sun, 15 Oct 2023 12:36:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697398581; cv=none; d=google.com; s=arc-20160816; b=FF/RUHBB3Xr+dDHRDOUkQH/KT1WWixDCcGcmyCyjL2I8OaY3+0/UBvOJvwLjJNaNrk eF4uDMMu9i9Xxos0wtNh9nz47YBD+fIPeL3GsFkInFDqg1036eY9r6JnoJlERDHq6b9c zs1phOPLCN0eZhoTcpTCS3rwLrD5ZmyrwDs+gb6LSwcRa61UYNzZHgTFmkiuu9to6YSE /gr+b4RfGqufPuCJkCnxp0xxkQLYT1gy6bYjo8dqh6+wTGbhH4AyB+uYhpyXtZB9v1+V 8lETRJ15qFnlVLHxocP4m1TLhtOrhT+AbNjoY8VBBDzJelGg89ZnLyRGZn+X3IDh0x5m 3PfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=g7b7CDe0Rw1hAfle5eQhLTmPYBUlC3VPMwPdSvyshGQ=; fh=QB4z44s7ob/tfnCKJVkAHaU9G1siH9L7UzNZPuykhZI=; b=w8wZALG/jVqPAMOfOza2Zyw6ElRZNxKtUOoIF0Eu9p8NM9od4SIlCu3MPlFdSHltpv HMsumB7aIL4kFTxZFhM9qamqUxXxI+P/UNcYlwyMSakKJGQ94OxQEQPdgzdvV8cWIpha e6kBcq/x9c0s4Iy8rGqpyOPYEwA00uN3M8hk1rgho99w7ihcbmxDfb01MZl5Xj7yLiUw yF76jagE/FaxT0FabnV8AhpRLkagLCOV7vG/4m8RQm6TbnPKh8cOYu7RS07wkSxfiY7o Bb8btpLsqajQy2bCY7ud3UzkeL+NgDdf8UMc5RvMMCf/eUSrwCvRC6h/qAYMPyTRgGLq JAsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Y/eyc2CY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id c185-20020a6335c2000000b005acb3613ba9si5335991pga.432.2023.10.15.12.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 12:36:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Y/eyc2CY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 9C6FA806237D; Sun, 15 Oct 2023 12:36:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230178AbjJOT2T (ORCPT + 99 others); Sun, 15 Oct 2023 15:28:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjJOT2S (ORCPT ); Sun, 15 Oct 2023 15:28:18 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EE63A9 for ; Sun, 15 Oct 2023 12:28:17 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE29DC433C7; Sun, 15 Oct 2023 19:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697398097; bh=NvvSDT0DdlGAaVq23B5QUDrtCIF+hE6S3uS807DItYk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y/eyc2CYnBWgrZpCISUQpFR7Qdg4bi3xLWY/PtEClfbRwA042rTK6+aO1k+2QPM15 xwbTpMQl8x7LrWy90VPiEWGpra+7usQ+gUnnUpg/RWgwQColTCeX2nwZW8bJZWasGT Yf7e1Dtt0HW1o8l00nSJNc+yzkbNreYnbzEownfM= Date: Sun, 15 Oct 2023 21:28:14 +0200 From: Greg Kroah-Hartman To: Soumya Negi Cc: Jonathan Kim , Dean ahn , outreachy@lists.linux.dev, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: gdm724x: Add blank line after declaration Message-ID: <2023101501-sprung-lance-c017@gregkh> References: <20231015192139.3121-1-soumya.negi97@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231015192139.3121-1-soumya.negi97@gmail.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 15 Oct 2023 12:36:18 -0700 (PDT) On Sun, Oct 15, 2023 at 12:21:37PM -0700, Soumya Negi wrote: > Fix WARNING: Missing a blank line after declarations > Issue found by checkpatch.pl > > Signed-off-by: Soumya Negi > --- > drivers/staging/gdm724x/gdm_tty.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c > index 4e5cac76db58..0c61eaff6122 100644 > --- a/drivers/staging/gdm724x/gdm_tty.c > +++ b/drivers/staging/gdm724x/gdm_tty.c > @@ -160,6 +160,7 @@ static ssize_t gdm_tty_write(struct tty_struct *tty, const u8 *buf, size_t len) > > while (remain) { > size_t sending_len = min_t(size_t, MUX_TX_MAX_SIZE, remain); > + > gdm->tty_dev->send_func(gdm->tty_dev->priv_dev, > (void *)(buf + sent_len), > sending_len, > -- > 2.42.0 > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot