Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20231015202650.85777-1-pedro.falcato@gmail.com>
In-Reply-To: <20231015202650.85777-1-pedro.falcato@gmail.com>
From:   Pedro Falcato <pedro.falcato@gmail.com>
Date:   Sun, 15 Oct 2023 21:35:26 +0100
Message-ID: <CAKbZUD01au=HoDe=yXSLtxJgYdivZccqqBfpmnmQ04R1Y1orvg@mail.gmail.com>
Subject: Re: [PATCH] mm: kmsan: Panic on failure to allocate early boot metadata
To:     kasan-dev@googlegroups.com, Alexander Potapenko <glider@google.com>
Cc:     Marco Elver <elver@google.com>, Dmitry Vyukov <dvyukov@google.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Oct 15, 2023 at 9:26=E2=80=AFPM Pedro Falcato <pedro.falcato@gmail.=
com> wrote:
>
> Given large enough allocations and a machine with low enough memory (i.e
> a default QEMU VM), it's entirely possible that
> kmsan_init_alloc_meta_for_range's shadow+origin allocation fails.

Ugh, forgot to run checkpatch.pl until it was too late :/

> Instead of eating a NULL deref kernel oops, check explicitly for memblock=
_alloc()

If there's no need for a v2, please wrap the above line and...

> failure and panic with a nice error message.
>
> Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
>  mm/kmsan/shadow.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/mm/kmsan/shadow.c b/mm/kmsan/shadow.c
> index 87318f9170f..3dae3d9c0b3 100644
> --- a/mm/kmsan/shadow.c
> +++ b/mm/kmsan/shadow.c
> @@ -285,12 +285,18 @@ void __init kmsan_init_alloc_meta_for_range(void *s=
tart, void *end)
>         size =3D PAGE_ALIGN((u64)end - (u64)start);
>         shadow =3D memblock_alloc(size, PAGE_SIZE);
>         origin =3D memblock_alloc(size, PAGE_SIZE);
> +
> +       if (!shadow || !origin)
> +               panic("%s: Failed to allocate metadata memory for early b=
oot range "
> +                     "of size %llu",

unwrap this string like this:
    "%s: Failed to allocate metadata memory for early boot range of size %l=
lu",

Silly mistake...

--=20
Pedro