Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Sun, 15 Oct 2023 22:57:06 +0200
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     Maxim Korotkov <korotkov.maxim.s@gmail.com>
Cc:     Alessandro Zummo <a.zummo@towertech.it>,
        Shanker Donthineni <sdonthineni@nvidia.com>,
        linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
        lvc-project@linuxtesting.org
Subject: Re: [PATCH] rtc: efi: fixed typo in efi_procfs()
Message-ID: <20231015205706326de111@mail.local>
References: <20231006090444.306729-1-korotkov.maxim.s@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231006090444.306729-1-korotkov.maxim.s@gmail.com>
Precedence: bulk

On 06/10/2023 12:04:44+0300, Maxim Korotkov wrote:
> After the first check of the value of the "eft" variable
> it does not change, it is obvious that a copy-paste
> error was made here and the value of variable "alm"
> should be checked here.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 101ca8d05913 ("rtc: efi: Enable SET/GET WAKEUP services as optional")
I had a look at the history and this is actually a bug that predates
v2.6.12-rc2 and so its introduction is not in the main git repo history.

I guess nobody actually cares and I'm very tempted to just rip out this
procfs file.


> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
> ---
>  drivers/rtc/rtc-efi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-efi.c b/drivers/rtc/rtc-efi.c
> index dc6b0f4a54e2..fa8bf82df948 100644
> --- a/drivers/rtc/rtc-efi.c
> +++ b/drivers/rtc/rtc-efi.c
> @@ -227,7 +227,7 @@ static int efi_procfs(struct device *dev, struct seq_file *seq)
>  			   enabled == 1 ? "yes" : "no",
>  			   pending == 1 ? "yes" : "no");
>  
> -		if (eft.timezone == EFI_UNSPECIFIED_TIMEZONE)
> +		if (alm.timezone == EFI_UNSPECIFIED_TIMEZONE)
>  			seq_puts(seq, "Timezone\t: unspecified\n");
>  		else
>  			/* XXX fixme: convert to string? */
> -- 
> 2.34.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com