Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2232735rdg; Sun, 15 Oct 2023 18:33:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFj5ICBNtHzBTUh528Xqi9uJFjFHG0CFEIf7xezzpaHBHkt9Em22fPYxfpQhymOqxC3/oC+ X-Received: by 2002:a05:6358:5924:b0:135:24ed:5106 with SMTP id g36-20020a056358592400b0013524ed5106mr21664732rwf.9.1697419995306; Sun, 15 Oct 2023 18:33:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697419995; cv=none; d=google.com; s=arc-20160816; b=VscwC0Z9ZmcjxyuNtkqPK7nFhuaxzAOLA5SY1uRdG0xaiyg0uK1ggymf+CJAN0Poq+ AZuNSAei751eA32lra43WDK6s3McnFHO8CoW2kt0zJGpeE6s2ZhoV4/L9a06Fxn1PDh6 F3SE8gChPP6fUoCHyxEAO4bZBtY8o5DbTKxpryfgfsh2gWnkJCvUpeTDbNbgyu/HoQ7Q TIq0uB26N5u72c0QC05xleI1aULVI6UTROW2AC5v9hWvOFsdR+B0PIytat6m1OlnBA6I sjvQ4uzrH0Yl+k5+a4eR9J7NTY7vyl0EuZ4nPEruDkk9aDp3maGOCsiZleMeHq3Zd9e9 2dhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=J6M5IsynnoswtQm5mi5V72Srk6LXjCtjo18yO5zsd8w=; fh=Nzm/d5osnMbWcj1axr7I4PeO1HcgqO6bJ5rjdp4I3Fs=; b=Vh5JI6CeauMfRCOe0gekDTeuO51B9z54iRGX53LTMpS/iXsfp0wFa7i66HqT9vRyC6 9q9SXKEtyvSOVZX7zDEUpcaqB+NFk1jymE4mwxAZAsX4vbyZT1XoRXvCXhQZNLxX9aDC 6MHAIg3P6qtMdi8tfet8AEsfyAoOHBmjKGZB7eunOJ0SnJVcuZuVqOZL9zhykzgoPWXk /b2WGwqbJ3S0GYmFtKw5YTKom5eHjO43nxGE6xflWgjT0tTjVUDEjZTzNQCtfUh6yWUf WfD16xulx63JZyu/AeDdOrRPpolgy2M2gVDTp6X+YqYeQpsoU4/lw5yXY/fKdaNWyZM3 VPtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alliedtelesis.co.nz header.s=mail181024 header.b=SHI7P0gy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=alliedtelesis.co.nz Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id y2-20020aa79e02000000b006be0b790ebfsi1577200pfq.255.2023.10.15.18.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 18:33:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@alliedtelesis.co.nz header.s=mail181024 header.b=SHI7P0gy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=alliedtelesis.co.nz Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 02B1A80BB80A; Sun, 15 Oct 2023 18:33:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229600AbjJPBc6 (ORCPT + 99 others); Sun, 15 Oct 2023 21:32:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbjJPBc5 (ORCPT ); Sun, 15 Oct 2023 21:32:57 -0400 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [IPv6:2001:df5:b000:5::4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51FA0A9 for ; Sun, 15 Oct 2023 18:32:55 -0700 (PDT) Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id A68382C02B1; Mon, 16 Oct 2023 14:32:51 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1697419971; bh=J6M5IsynnoswtQm5mi5V72Srk6LXjCtjo18yO5zsd8w=; h=From:To:Cc:Subject:Date:From; b=SHI7P0gyE/ZTmFmQGrr1kjmDW9BPFteWcgCceiXUdBVJj/qLtyzPS8MjAnPAUF2bh rNn7a+bkSE2ViMZs1VizUnNSWBiVCYmYIRLuH0XxL9V5QLWCbV3arPnW8+qhVJZr+2 hESeyTxeB+Aj3MFPTs47Rm4BWDacOYMC9XIoFDkZE2T7A4coMwsod/Wg97NWoP0qEx WAL8Jrew3TqXepLGgm6+pqTf5U7EU2D35LtyYBgNiGtTig9GsRpCoqeyAJZetzdonh MQ3W1sSr0aSy+LR7psmiBM55RCXcuSTSlTJO6UXP5oBh0pIxklP8IPP1RMiyi+01Ri ZLQNm5JriScUQ== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Mon, 16 Oct 2023 14:32:51 +1300 Received: from richardl-dl.ws.atlnz.lc (richardl-dl.ws.atlnz.lc [10.33.23.23]) by pat.atlnz.lc (Postfix) with ESMTP id 8126A13EDA9; Mon, 16 Oct 2023 14:32:51 +1300 (NZDT) Received: by richardl-dl.ws.atlnz.lc (Postfix, from userid 1481) id 7CF5B520158; Mon, 16 Oct 2023 14:32:51 +1300 (NZDT) From: Richard Laing To: gregkh@linuxfoundation.org, jirislaby@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, ilpo.jarvinen@linux.intel.com, andriy.shevchenko@linux.intel.com Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, Richard Laing Subject: [PATCH] dt-bindings: serial: snps-dw-apb-uart: Add property to drain TX FIFO Date: Mon, 16 Oct 2023 14:32:05 +1300 Message-ID: <20231016013207.2249946-1-richard.laing@alliedtelesis.co.nz> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SEG-SpamProfiler-Analysis: v=2.3 cv=L6ZjvNb8 c=1 sm=1 tr=0 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=bhdUkHdE2iEA:10 a=4-VxxmyDogjG6lCeASgA:9 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 15 Oct 2023 18:33:13 -0700 (PDT) During development of a new hardware an issue was seen where writes to UART_LCR can result in characters that are currently held in the TX FIFO being lost rather than sent, even if the userspace process has attempted = to flush them. This is most visible when using the "resize" command (tested on Busybox), where we have observed the escape code for restoring cursor position becoming mangled. This is the same issue as addressed in=20 commit 914eaf935ec7 ("serial: 8250_dw: Allow TX FIFO to drain before writing to UART_LCR")=20 for the Armada 38x serial port. This patch makes the fix more generic allowing it to be applied on any similar UART. Richard Laing (2): serial: 8250_dw: Allow TX FIFO to drain before writing to UART_LCR An issue has been observed on the Broadcom BCM56160 serial port which appears closely related to a similar issue on the Marvell Armada 38x serial port. dt-bindings: serial: snps-dw-apb-uart: Add property to drain TX FIFO .../bindings/serial/snps-dw-apb-uart.yaml | 6 ++++++ drivers/tty/serial/8250/8250_dw.c | 18 ++++++++++++++++++ drivers/tty/serial/8250/8250_dwlib.h | 1 + 3 files changed, 25 insertions(+) --=20 2.42.0