Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2232775rdg; Sun, 15 Oct 2023 18:33:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtkySQcj3zUQdHQctXeySr0XUIVeE23s8EUl7yQe6Ma/kq3L9xjcfrZuvQrhYeXnMmZM5e X-Received: by 2002:a17:902:c711:b0:1c3:e2eb:f79d with SMTP id p17-20020a170902c71100b001c3e2ebf79dmr7775521plp.8.1697420001937; Sun, 15 Oct 2023 18:33:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697420001; cv=none; d=google.com; s=arc-20160816; b=MPWNd3ME2tBvbV5qfayt2luSw6AjlLaXDvSo+jo1IqIKijhUX2t9Ke9QduoC3vzPnc SP/J7gO126wPooxXafrfURLmzo/veW+k0aQi2MJB/SQtCSZTqfrtZOcIbjPVYUreXj89 Clmb7UMBr3joWmp0KbId+RLZCq8Lft+uwpPHSPymg1gwfmUNC5sOE36Mq9HnfUR1OU3M HX7qO3n91v1GS1sYn2OgiJqMMqMKdKBYsui2xC4AMokhF809beCPpRYutiPeJ5u6RLOi c6tgnZ1Zz7PYPWa6dAsj4Df0EpmO68l4FBgYSrtuJuuH3wS2bfgunFr+X0mwzrYm3xW2 OLkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ko5T8oZxTS9rIyp1bVTVligc3kX9bo+JSpSRE33ApsY=; fh=Nzm/d5osnMbWcj1axr7I4PeO1HcgqO6bJ5rjdp4I3Fs=; b=0munny8fCiXS4BweXFQWFyE0lwGy5oXNRBdtTSEeR9SW6CiJlx7IjStTxA9Hu9BWBD 1zUyNB1h9r/1HZ2BLww5cvOV07Pme3qL3TS0soeQI/tqq83fzjh85Blvj9TWIV7sW1Zm KcPJJrGkFiTZ4z+1G04+icTc+QqC5EE2zyYUuFJkJ1BiNjGFfPllPJDps0u0P1EBwDBe hQUV08KY70KUz15fve7P23LRehhk70lKnDdLyrhDK5aGj59h9ADXOeKAlsV0GOBTffxr Pw//KBE1foxbfefCtd5IQnz0+CZfnAPs2NGgPGeMUv4bIQfZPbMgcgrYu7VM4keZXpUA olsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alliedtelesis.co.nz header.s=mail181024 header.b=dhYgZVE5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=alliedtelesis.co.nz Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id u17-20020a056a00125100b0068a590d803csi5773439pfi.361.2023.10.15.18.33.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 18:33:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@alliedtelesis.co.nz header.s=mail181024 header.b=dhYgZVE5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=alliedtelesis.co.nz Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 7CC14805935C; Sun, 15 Oct 2023 18:33:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230527AbjJPBdK (ORCPT + 99 others); Sun, 15 Oct 2023 21:33:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231140AbjJPBdI (ORCPT ); Sun, 15 Oct 2023 21:33:08 -0400 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [202.36.163.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F9CCDC for ; Sun, 15 Oct 2023 18:33:07 -0700 (PDT) Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id B7F072C0733; Mon, 16 Oct 2023 14:33:05 +1300 (NZDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1697419985; bh=ko5T8oZxTS9rIyp1bVTVligc3kX9bo+JSpSRE33ApsY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dhYgZVE5mzOHTRTF/qyeXifd9fuLrkEsacshOLJ5gze9eEP7cszJ6BdreWlvrxmA6 GmhwOJsQGTnMbY2glQZtdj63PMSQndKiMw8yyGSRerpeqi18naWry34mRwbxzDFMGX Djy9QLRXIAiA4kPrFlO/jYSXo18wNCDpjo+oQQWPViI9v1G6wpWx9p0WN1+MNw3F6d BjEq9QS0nwlNtrWvvmp7FC3IW3chRf2QAyrNfVzOgKwL5+XrkpWmPW/lum5YY0dI7A 9yMplHdXZLu5hWi/mrBT3TMmi+/yfjYHkaDHqm+nk9IGmPiOuP7jEbPRuPP/1MzkgB qMTZk6+Tw2Lcw== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Mon, 16 Oct 2023 14:33:05 +1300 Received: from richardl-dl.ws.atlnz.lc (richardl-dl.ws.atlnz.lc [10.33.23.23]) by pat.atlnz.lc (Postfix) with ESMTP id 9808813EDA9; Mon, 16 Oct 2023 14:33:05 +1300 (NZDT) Received: by richardl-dl.ws.atlnz.lc (Postfix, from userid 1481) id 959D6520158; Mon, 16 Oct 2023 14:33:05 +1300 (NZDT) From: Richard Laing To: gregkh@linuxfoundation.org, jirislaby@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, ilpo.jarvinen@linux.intel.com, andriy.shevchenko@linux.intel.com Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, Richard Laing Subject: [PATCH] dt-bindings: serial: snps-dw-apb-uart: Add property to drain TX FIFO Date: Mon, 16 Oct 2023 14:32:07 +1300 Message-ID: <20231016013207.2249946-3-richard.laing@alliedtelesis.co.nz> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231016013207.2249946-1-richard.laing@alliedtelesis.co.nz> References: <20231016013207.2249946-1-richard.laing@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SEG-SpamProfiler-Analysis: v=2.3 cv=L6ZjvNb8 c=1 sm=1 tr=0 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=bhdUkHdE2iEA:10 a=yJYUBcXGP3-BVwV7yiEA:9 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 15 Oct 2023 18:33:19 -0700 (PDT) An issue has been observed on the Broadcom BCM56160 serial port which appears closely related to a similar issue on the Marvell Armada 38x serial port. Add a new property to force the TX FIFO to be drained before changing the UART_LCR. Signed-off-by: Richard Laing --- .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.ya= ml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml index 17c553123f96..4266ef96832c 100644 --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml @@ -114,6 +114,12 @@ properties: register. Define this if your serial port does not use this pin. type: boolean =20 + drain-before-lcr-change: + description: Force TX buffer flush before LCR change. Make sure all + characters in the buffer are sent before reconfiguring. Define this = if + the UART drops its FIFO when reconfiguring. + type: boolean + required: - compatible - reg --=20 2.42.0