Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc:     linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
Subject: [Patch v2 6/6] tty: serial: 8250: Add support for MOXA PCIe boards to switch interface between RS422/RS485
Date:   Mon, 16 Oct 2023 11:37:05 +0800
Message-Id: <20231016033705.20669-7-crescentcy.hsieh@moxa.com>
In-Reply-To: <20231016033705.20669-1-crescentcy.hsieh@moxa.com>
References: <20231016033705.20669-1-crescentcy.hsieh@moxa.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?72lFDRG1boXoKZzAcjnSUAPB4JOEWJqXndMD87jgTS55m2+cbwhtIaObFaHA?=
 =?us-ascii?Q?9OPHFFLvTlhREKDzfuUIvOogFaVeS2dxTG8qxoj/XpjyRx61SpqRd7VypnvP?=
 =?us-ascii?Q?loyqGVWPvk/WOY0x70aE/Zp1lTZ45kechAW9EzdHaaRNGiAXtaikxbXwNoEe?=
 =?us-ascii?Q?vRsrfh92lqRT4Gz2+DX5/tUD3sij/NSpkg5oqhLReW+SQ/WqYhgTSK7AxxyY?=
 =?us-ascii?Q?Z/bkkjFzYGcAJ4wpG0LPdDOgTuT7DgPPrSbWk+Lq99IoBhqUS8HNPz2WSxX7?=
 =?us-ascii?Q?i+JKJi5ozBIcM10pSIuktADnPVEU60j4yf3JM/7IzamqadmylsD44CYrxQQW?=
 =?us-ascii?Q?kISUZiXeBBqCVwYc8eEce4s0lj9EGZMyTQsRyGk/mkd4a2osuN6OluqC6jEo?=
 =?us-ascii?Q?WlYnBYBpQezaJwOglmZni7JxphdYAgY8dpAn4CWjVtmocoOmFnW0nuK1r5JO?=
 =?us-ascii?Q?kNqxsXTtM2E/8EzN60FPvloLXRNenQDA2wL67ZU/noymhH4A1tMHfDdcSTmw?=
 =?us-ascii?Q?aM+g8Hv1mLufzcImD9fg6URkn6034qDNLPXircki576RRvqCBRn5fH5rQYFf?=
 =?us-ascii?Q?K52rjuZvPYbfamQEVyMZbhlWzXfsNM404NgxOcDBCnMtdqg5FiP/surLG2Ue?=
 =?us-ascii?Q?6Wh7hfR7wgJryEsBAiUIfPfTi0pvcP440vwJvcNz8Cark9YzD+lmamyEoIIS?=
 =?us-ascii?Q?N4yxvJXTqzitnYSh003X4kXOxZiylf8BXXANjG0lYtD9jeetnV71r4wdyKl3?=
 =?us-ascii?Q?qzejCEgprf/N/VVNOUckGAow9iqk/rPL8/U0AF/F7UoYvJ/Rv47uNODCnh/l?=
 =?us-ascii?Q?RT9K/ENB/4037eFKKI7B9/YCwDiGFbh0wLftCvznkFfXltmCma4Gka1ZdLrH?=
 =?us-ascii?Q?WlFIiNRMkltOZoyPe+BSn6jABVu6aaFDQ5scT/LdEcQ57TT/fidkEjw1IBcw?=
 =?us-ascii?Q?XO1j29yY2Yb5wvE8Qd06GkwRA0PwP6Bu/l7fF+erICcuhRBaC2rrQOEx3fBT?=
 =?us-ascii?Q?MGk+qT94VYebRvCEsqrSadouLJur2f4cDgoe0j5zRLRC9QJs2E2HuN5bDLWu?=
 =?us-ascii?Q?3czHpJ0o/2dWf8NumHVdSzbmWg6xV6Igy7L7/Ao+YHifi/rmiWhxc2zCoROu?=
 =?us-ascii?Q?EuS5MOwM6FOFnw2rgkqCyg77A2/6oVBB4b/xQ0YeCous1DiyAWdwL73yDTvS?=
 =?us-ascii?Q?UIqUCrbUxxOIm4uSo81ApetH9c2rb8Jri146YKOkYFl/tXNa68Na65qRPmKg?=
 =?us-ascii?Q?wTF8mWCtDzv0TquNpVWGR7Gx9iEu+etXKAAIGrKDtnJ4V6jMxGJZFzRopHXh?=
 =?us-ascii?Q?LfRSfBJfWxkSqwSgVeR4g5vTkxwXEwpJAgQs9C7NQOeUI58cGjeEQ5xqrjRA?=
 =?us-ascii?Q?55LJ50Su8e0v3gs9l9lLSNEb4Zek+wBfRtwWtmdzrxZ5On/Wcb9XVOBRn3dz?=
 =?us-ascii?Q?U7EQzzVEzfbqYhBwqufOtZElk5JMs8XAlYQ8RNa+BZs8uD54Rk2v1x5rrxy7?=
 =?us-ascii?Q?yJuvfV4BUzb09K7L1v9IYkTj97GvVoBFQXnNlpInRJbaeBBhYh+IeAUPfotD?=
 =?us-ascii?Q?b3cd0lyQVf2Y0+PvG+LnLZkccotHqNHS326XGgL+2vlubT+w5i9RKjD2KPUY?=
 =?us-ascii?Q?eQ=3D=3D?=
X-OriginatorOrg: moxa.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2ea9b08-f5a2-476b-3d4f-08dbcdf97cf9
X-MS-Exchange-CrossTenant-AuthSource: PUZPR01MB5405.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 03:39:23.1466
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5571c7d4-286b-47f6-9dd5-0aa688773c8e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1kpVAxFrCCpnEOGBdbbUb0h9+1QJoJhsowgyYMzoy9AqAVYSHTTkDPkqDuhPy+2sX9sUo71OrYCRZ39UKhf/Mr8Crou1lr30WAXeQTMzDrA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR01MB5156
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 15 Oct 2023 20:40:22 -0700 (PDT)

MOXA PCIe boards have 4 serial interfaces and don't require additional
stuff to switch between interfaces:

- RS232
- RS422
- RS485_2W (half-duplex)
- RS485_4W (full-duplex)

By using ioctl command "TIOCRS485", it can switch between default
interface and RS485 if supported.

That means, for RS422/RS485 board, it can switch between RS422 and
RS485 by setting the flags within struct serial_rs485.

However, for the RS232/RS422/RS485 board, it can only switch between
RS232 and RS485, there's no flag for switching interface into RS422.

This patch uses "SER_RS485_TERMINATE_BUS" to represent RS422 as a
workaround solution.

Signed-off-by: Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
---
 drivers/tty/serial/8250/8250_pci.c | 52 ++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index 72dd27141801..e2e8a28242bc 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -1976,6 +1976,10 @@ pci_sunix_setup(struct serial_private *priv,
 #define MOXA_RS485_2W	0x0F
 #define MOXA_UIR_OFFSET	0x04
 
+static const struct serial_rs485 pci_moxa_rs485_supported = {
+	.flags = SER_RS485_ENABLED | SER_RS485_RX_DURING_TX | SER_RS485_TERMINATE_BUS,
+};
+
 static bool pci_moxa_is_mini_pcie(unsigned short device)
 {
 	if (device == PCI_DEVICE_ID_MOXA_CP102N	||
@@ -1989,6 +1993,11 @@ static bool pci_moxa_is_mini_pcie(unsigned short device)
 	return false;
 }
 
+static bool pci_moxa_match_x1xx(unsigned short device)
+{
+	return (device & 0x0F00) == 0x0100;
+}
+
 static bool pci_moxa_match_x3xx(unsigned short device)
 {
 	return (device & 0x0F00) == 0x0300;
@@ -2016,6 +2025,36 @@ static int pci_moxa_set_interface(const struct pci_dev *dev,
 	return 0;
 }
 
+static int pci_moxa_rs485_config(struct uart_port *port,
+				 struct ktermios *termios,
+				 struct serial_rs485 *rs485)
+{
+	struct pci_dev *dev = to_pci_dev(port->dev);
+	unsigned short device = dev->device;
+	u8 mode = MOXA_RS232;
+
+	if (rs485->flags & SER_RS485_ENABLED) {
+		/* Use SER_RS485_TERMINATE_BUS to represent RS422 as a workaround. */
+		if (rs485->flags & SER_RS485_TERMINATE_BUS) {
+			mode = MOXA_RS422;
+		} else {
+			if (rs485->flags & SER_RS485_RX_DURING_TX)
+				mode = MOXA_RS485_4W;
+			else
+				mode = MOXA_RS485_2W;
+		}
+	} else {
+		/*
+		 * RS232 is not supported for those device IDs of
+		 * MOXA PCIe boards match the pattern 0x*3**.
+		 */
+		if (pci_moxa_match_x3xx(device))
+			return -EINVAL;
+	}
+
+	return pci_moxa_set_interface(dev, port->port_id, mode);
+}
+
 static int pci_moxa_init(struct pci_dev *dev)
 {
 	unsigned short device = dev->device;
@@ -2055,9 +2094,22 @@ pci_moxa_setup(struct serial_private *priv,
 		const struct pciserial_board *board,
 		struct uart_8250_port *port, int idx)
 {
+	struct pci_dev *dev = priv->dev;
+	unsigned short device = dev->device;
 	unsigned int bar = FL_GET_BASE(board->flags);
 	int offset;
 
+	/*
+	 * For the device IDs of MOXA PCIe boards match the pattern 0x*1** and 0x*3**,
+	 * these boards support switching interface between RS422/RS485 using TIOCSRS485.
+	 */
+	if (pci_moxa_match_x1xx(device) || pci_moxa_match_x3xx(device)) {
+		port->port.rs485_config = pci_moxa_rs485_config;
+		port->port.rs485_supported = pci_moxa_rs485_supported;
+
+		if (pci_moxa_match_x3xx(device))
+			port->port.rs485.flags |= SER_RS485_ENABLED | SER_RS485_TERMINATE_BUS;
+	}
 	if (board->num_ports == 4 && idx == 3)
 		offset = 7 * board->uart_offset;
 	else
-- 
2.34.1