Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2282524rdg; Sun, 15 Oct 2023 21:42:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGSCb3Z3roDvtSZEtit3pcqweS7mwxKqSW5uCA3RBJSurTicaNQTcyPZAYM8zN0+WWQmnTs X-Received: by 2002:a67:fe88:0:b0:44e:9313:b045 with SMTP id b8-20020a67fe88000000b0044e9313b045mr29737322vsr.7.1697431343797; Sun, 15 Oct 2023 21:42:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697431343; cv=none; d=google.com; s=arc-20160816; b=yuTZMmhCpgLlPnbhPm2RjL+7lQuLCuamhzyBg+pVARVoJEvSOz39X1iTSj9B+RM4bK nFQQfU+fukTwo3l5vIT/pFYPbzMYPA+wmch2C4e52fHTF8qK8EXQa6JjPGZWja14JvQI mX5vWPLCcjk+EdfIH68gBIQsoCKxIm083VOIaVD4EtTC0kAq8qjow+Vr9BOfIy+lE3vb NOKdu2I6ZvE2I/vKeb1blMpIN1UscsaWG6rvzL8DDcKkWWM1Hdgcx3nzmgAfy/FamT8L PpcCVv3ezLLKwu/Wbs3HZJqLHVpMIGWxY4OMawyUK+Cuj4+WzuZ9yccL65f/cKYTZPQw r2gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+OOjXanV6ifmADtLDN2bjdEAHMH7dAxhg1yhRTNpb/Q=; fh=cOckVxVjrM5jmf86/i5eTTw5wBLyeTzAmcCgKIUtB0I=; b=T0+YggmL2bpodfkm9swGAM6X5/Wukth4zVx4g2fmx8O5q8kLIfPxSA01VjQhcCQGOF kZpcfn5PyrzvAEes2N9R2BXjht1mTpG9SzvsAXVZIQK+8nBHWduvlrX9x1ht9R/hFErq oUoQVfqaMK6P4kbYBQyF8RWmH/XxNDSwyATtPjMUXbLokmEWPIAIvm2jKhMsQQ0BTv8H aWTORfWlqhuSguqIBt8ulg8e0h9uo+krS3jQu58GVnidsQh8eDDY2isaIDLk3CTKEAE3 tHHQCAABdfz5pmggJJ9sr8QiG76TGgduiWNCKbwensAq6c33NxypCIf6fZK3K+0C/mTO CR3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="mD/VPJ2i"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id q16-20020aa78430000000b0068fc7ab1fd5si6452020pfn.269.2023.10.15.21.42.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 21:42:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="mD/VPJ2i"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 5FD5F803FCC6; Sun, 15 Oct 2023 21:42:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231634AbjJPEmK (ORCPT + 99 others); Mon, 16 Oct 2023 00:42:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231200AbjJPEmH (ORCPT ); Mon, 16 Oct 2023 00:42:07 -0400 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 762BED9 for ; Sun, 15 Oct 2023 21:42:02 -0700 (PDT) Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-40572aeb73cso41551765e9.3 for ; Sun, 15 Oct 2023 21:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697431261; x=1698036061; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+OOjXanV6ifmADtLDN2bjdEAHMH7dAxhg1yhRTNpb/Q=; b=mD/VPJ2iF8ANl0x72C8pPI0inTtyQ6vYnF0059voZw4FjcL2FSwoNF3E/1OTFWQYWP jDzhbOhH6rSPVT7vVgJs3kxjaZjQks+zjANvFc9uKOlJ/FA/GviMguO3bVpTmPKp7S9P gJwat65bRfm//JwM+qPy+7P0lZ4T8rCkaiX+gT5wC4ZHKK/zb/oU4W0ULRMHOMpVozqP tv/O8MqE9A1yQiD3k7pPwO2KcYuJtZ7vSVKMxHjBb1o6Kuzpxgb1GzgEwiucibgQeV2v 39ZK7OHG0AM+Z5uvF/iSfEsxvl+3NCVmkHtTYwiFOAntQ882yfWiYIJ8aB6DakRFzpV6 pXkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697431261; x=1698036061; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+OOjXanV6ifmADtLDN2bjdEAHMH7dAxhg1yhRTNpb/Q=; b=VeVBts9NgzCGUXlGfp2//Nu7y/Fgxus29nExeKXEwOvtHJeCLW59bAKSwhZw7pRRRG 85WhydgqzIO71mNta7Kr5Ql9hZHeOB8TWRfENP0mitbX5IVk7pqDGILGBdBPq9MUB/es ycCNkaVdYqDDKRfVWj+jeUqQJfSUDDd8U5FDMFvh43NdNupWb3edQhuI8DQ/ujxJHu1e LPkGu1arQLJpSNubq/dQpIMNFpcQbRpza4rLce0/wxT7XCfhRciiQukVAzz5Byg+2wGy 3o4GrqDD05MpFV+IOPHBmPXpZUb/QBe2BG/ZLTjvOHUamLGvLB0kiqQ8pxopJPigqrAY AAng== X-Gm-Message-State: AOJu0YxEa3oXji4NIfL1ReihD7KCpUJtflmsrcAH9Y2V3nYxM0TbROCi aH/Q0hYaYL9GiOjFl/YJAfUPew== X-Received: by 2002:a7b:c851:0:b0:405:3252:fe2 with SMTP id c17-20020a7bc851000000b0040532520fe2mr28195556wml.14.1697431260924; Sun, 15 Oct 2023 21:41:00 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id p18-20020a05600c431200b0040642a1df1csm6020508wme.25.2023.10.15.21.40.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 21:41:00 -0700 (PDT) Date: Mon, 16 Oct 2023 07:40:57 +0300 From: Dan Carpenter To: Calvince Otieno Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Luke Koch , Bagas Sanjaya , Simon Horman , linux-staging@lists.linux.dev Subject: Re: [PATCH v2] staging: wlan-ng: remove helper function prism2sta_inf_handover() Message-ID: <4c29cb7a-3b24-4682-9211-09aff1e01360@kadam.mountain> References: <67d90726-15b9-4d64-87c6-bfbf662cbe81@kadam.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sun, 15 Oct 2023 21:42:21 -0700 (PDT) On Fri, Oct 13, 2023 at 07:04:56PM +0300, Calvince Otieno wrote: > On Fri, Oct 13, 2023 at 3:12 PM Dan Carpenter wrote: > > > > On Fri, Oct 13, 2023 at 01:50:23PM +0300, Calvince Otieno wrote: > > > prism2sta_inf_handover() function basically calls pr_debug() to print > > > a literal string. This can be done by the parent function directly. > > > > > > Signed-off-by: Calvince Otieno > > > --- > > > Patch version v2: > > > - Replace pr_debug() utility function with the module specific netdev_dbg() > > > > This isn't a v2 patch, right? This patch assumes that we applied the > > v1 patch... > > > > This patch is not white space damaged though so that's good. > > > > regards, > > dan carpenter > > > > > > Hello Dan, > Does this response mean that the patch was accepted? Ugh... No, sorry. I suck at emails. White space damaged is not good. I left out the word not... :/ You need to figure out what's going on there. Some of your patches are not white space damaged so sometimes you're doing it right but here the spaces were replaced with tabs so it doesn't apply. regards, dan carpenter