Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Mon, 16 Oct 2023 07:28:44 +0200
From:   Maciej =?utf-8?Q?Wiecz=C3=B3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
To:     Shuah <shuah@kernel.org>
CC:     <akpm@linux-foundation.org>, <christian@kellner.me>,
        <fenghua.yu@intel.com>, <keescook@chromium.org>,
        <ndesaulniers@google.com>, <coltonlewis@google.com>,
        <dmatlack@google.com>, <vipinsh@google.com>, <seanjc@google.com>,
        <brauner@kernel.org>, <pbonzini@redhat.com>, <hannes@cmpxchg.org>,
        <nphamcs@gmail.com>, <reinette.chatre@intel.com>,
        <ilpo.jarvinen@linux.intel.com>, <linux-kselftest@vger.kernel.org>,
        <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v6 0/8] Add printf attribute to kselftest functions
Message-ID: <s3wj75zwkwwmvllobuevhf7nbkhyn2a2kwis7oyt3nwsnl5j36@ju5xzn6pw5p5>
References: <cover.1697196663.git.maciej.wieczor-retman@intel.com>
 <0efe3ba3-b62f-4447-a195-2447e1152a22@kernel.org>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0efe3ba3-b62f-4447-a195-2447e1152a22@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?hyIJdKOvU+OFrneiR80DQuiFXRzagUv4SWP/JC0xkqt/p+g3LI+tDJPfhq?=
 =?iso-8859-1?Q?yZp94L+MW4TfIONkP8hODmxzKi9cbAk+16nw1MSs+YkP6+KYv0eLRj8B9e?=
 =?iso-8859-1?Q?bw6Un2AGW7goIgZsyarPQsC9EFLikTN7ytay58cUoeV1RwC9FuO/b1iqs7?=
 =?iso-8859-1?Q?ZNMJ+7WjoO/Mbyqn0mn6h8mSVbxfkuU2AmkG57Mh4/OujxHC5q7QYkSLnZ?=
 =?iso-8859-1?Q?HiMUEUqrKMVdP4UvTjSGIsABEn2szmPsoFuG7vTKPWngft2WLyYOXZeLwJ?=
 =?iso-8859-1?Q?fXpC50iEjDupfwsR3noPeeEsYDqbSiz+mMAPtl23sOg4mKEr9MsZshTHKu?=
 =?iso-8859-1?Q?NbBH0HgwLG5Kn7T2oapjCqdYPVNK7PGam20NawF+8dT51+z3NXu0IzvY9N?=
 =?iso-8859-1?Q?Xd+6th2UCgJ3lERCdmhqYVCLAL5LdMxoRs8ZPUyTh8WgXPKx7UlM0JUGXZ?=
 =?iso-8859-1?Q?7MBmui5ZGT+UOBlS8MJAZteHfj1Cy02YK+BbYpmOEL7O67bp/iS3CwWZmV?=
 =?iso-8859-1?Q?IDhp54SWP7IL5Hzu5Q8Yrb4jv592PktBeWLOhL6GDKWHPuZH9QLgW3x3xG?=
 =?iso-8859-1?Q?NMEDtlFUsVIZZ3pLaCd+PkBl/cb2zICq7rRjJKCQoGS0q88PwMt3dh1Nvk?=
 =?iso-8859-1?Q?Cy7SuHVs3WmCxPJGpriV5x0il5Zbpy4KVhRAjPpJFnfriSQXmzc/TK7qjP?=
 =?iso-8859-1?Q?N1HBjIr5qfLi+igF/y9Eo3umf1TD+AwaVPGy8mtMzFWUNeBtWaNfdd6gOX?=
 =?iso-8859-1?Q?UlvngY4SuEMRW0NEsg/3bZnQ8COwnRIW4wekQyg/Emqd3ETSsod5mAXolG?=
 =?iso-8859-1?Q?BM7LlOHdaEgHhtgnskXIWSwAmS8xHA647BRx6+0YeX1XbZ4IB/8BJq2tNo?=
 =?iso-8859-1?Q?1ypAuol8gvMcqOJQAKOvE8FJajZbUVfESD6g7pV2M/XASZ6lfbpMjoZ5T5?=
 =?iso-8859-1?Q?DZK2oiHYkc8JV47+ZIH4vgYOuLCfqGbgmHawgmU0ukDYHiDH/428B0qh1D?=
 =?iso-8859-1?Q?pilDjxOPMvknWG/eSLmnVa3vEZE3AiQHjsnG+/xSaBTSOzjXtG7omVy0jE?=
 =?iso-8859-1?Q?wgi7SXeSgNdBpISEhQhUGc33vZlEOwOnVHnfNq79enfrGrYiURWm06OpDP?=
 =?iso-8859-1?Q?r6IrI4TxYFgwAafN96C2Ulvy6eXQRyJTm7OxHjgzHf1jGawz1ueVvz+Fio?=
 =?iso-8859-1?Q?zdOkqhRSf0SaNSEwmVxpyaeaZU7/X339CvDf7YaP07yN+Z2MWIbLjGf0tD?=
 =?iso-8859-1?Q?mfLFk89FEdXhKaGBR0SHNxYOreQzaob2MINCOrKBl8EXVGpbFq77Q5oG4L?=
 =?iso-8859-1?Q?Uq1i9C2XBcqmliSA5EtYFUvybxUHw+KEFXYJYrxADoA9wOjj1lgme0sGeU?=
 =?iso-8859-1?Q?4awgf07YDVjvMkzbcfNVwBt5/BPJsCQTV4oqjDKi//RFVK3L3+MZ4jgQlJ?=
 =?iso-8859-1?Q?7CbBSMAkp7qzBfvbQXz+dSXfnuPvQhAI7ABLgE9AMbfF1goIGj8g7w+5Kk?=
 =?iso-8859-1?Q?UaFsF5kmXnkmZ8ESvkSM53w5ynVdMomBo/UaK0JUtyGCQlXxh7CLduCFDR?=
 =?iso-8859-1?Q?6pmqeRFiFEMTqRybduWqSwvG4e/VvB8e9v3fmKzvchCpUNHYrx6+ShImAm?=
 =?iso-8859-1?Q?qcvf5vxxOsjy5sR4bTSWCoD44eC49kmIQnarG9Jx2QbzGFh38WpMz7WFPq?=
 =?iso-8859-1?Q?Mj+/PIMwdWbjyVcQrA8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 162bbef3-ee24-4a2a-cfa0-08dbce08c738
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 05:28:50.2254
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kE1/4gHUp7rnKRIrp9TZLldNX2vMv+3fk+2janYi0C46itN5rXV3vv1+l0/UKwWfRTatLo9bRKCHph4pqawSpCNQZFvRt4bdh2+cqS4JzLo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7792
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sun, 15 Oct 2023 22:29:17 -0700 (PDT)

On 2023-10-13 at 15:03:11 -0600, Shuah wrote:
>On 10/13/23 05:36, Maciej Wieczor-Retman wrote:
>> kselftest.h declares many variadic functions that can print some
>> formatted message while also executing selftest logic. These
>> declarations don't have any compiler mechanism to verify if passed
>> arguments are valid in comparison with format specifiers used in
>> printf() calls.
>> 
>> Attribute addition can make debugging easier, the code more consistent
>> and prevent mismatched or missing variables.
>> 
>> The first patch adds __printf() macro and applies it to all functions
>> in kselftest.h that use printf format specifiers. After compiling all
>> selftests using:
>> 	make -C tools/testing/selftests
>> many instances of format specifier mismatching are exposed in the form
>> of -Wformat warnings.
>> 
>> Fix the mismatched format specifiers caught by __printf() attribute in
>> multiple tests.
>> 
>> Series is based on kselftests next branch.
>> 
>> Changelog v6:
>> - Add methodology notes to all patches.
>> - No functional changes in the patches.
>> 
>
>Applied this series and the following three - all 25 patches are
>in linux-kselftest next for Linux 6.7-rc1.
>
>[1] https://lore.kernel.org/all/cover.1696932728.git.maciej.wieczor-retman@intel.com/
>[2] https://lore.kernel.org/all/20231002094813.6633-1-ilpo.jarvinen@linux.intel.com/
>[3] https://lore.kernel.org/all/20230904095339.11321-1-ilpo.jarvinen@linux.intel.com/
>
>thanks,
>-- Shuah
>

Thank you!

-- 
Kind regards
Maciej Wiecz?r-Retman