Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <05a5c068-6766-ade4-0e7c-e94b48c4d754@amlogic.com>
Date:   Mon, 16 Oct 2023 14:49:48 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH V2 4/4] clk: meson: c3: add c3 clock peripherals
 controller driver
Content-Language: en-US
To:     Stephen Boyd <sboyd@kernel.org>,
        Jerome Brunet <jbrunet@baylibre.com>,
        devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Neil Armstrong <neil.armstrong@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Chuan Liu <chuan.liu@amlogic.com>
References: <20231010062917.3624223-1-xianwei.zhao@amlogic.com>
 <20231010062917.3624223-5-xianwei.zhao@amlogic.com>
 <5e0bd4bba88701dd1a7a3e89d18412f0.sboyd@kernel.org>
 <1jmswnvub2.fsf@starbuckisacylon.baylibre.com>
 <2fb931d1aa2190b918d0ddba87579eeb.sboyd@kernel.org>
From:   Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <2fb931d1aa2190b918d0ddba87579eeb.sboyd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dm8xdHROUTZrb3BodTYxZkx6VU5zc29yaE5tV2VnTTNSYk9LeVlSbGFqZFdV?=
 =?utf-8?B?VTlPc3RuMVp3S2RwdjlpWmt2YmtiN1lqMERzZisvaU1IU1A3M3VJcU9pYjMz?=
 =?utf-8?B?anhIbWN3Sk9QQ09UOFRGQnRJdDdnSWVJcSs4Qk8zWnNudFdDbUdlQ2JSMFhO?=
 =?utf-8?B?UWROdVJhRk5NdXJYUXliVG11NktHVWVRQlBuM2FvQzFZNGR2Y3V4NERsOEFu?=
 =?utf-8?B?MzlHMnNXZUZOY2dWTnRSdEZvQmVhY1dBaTdFaGJiZnJZWWx6TTJobGNZdW5h?=
 =?utf-8?B?ajlkV0xBMHQzcC9ONUplbVBvQmZDTEo2QnppcnYxekljSGhYeEhSZ2xoemc4?=
 =?utf-8?B?LzJTdUVmWFdKdko5U0xDbEZXenZFQ05ITzJZanArbkZyRzZ6LytzOUtDNXNG?=
 =?utf-8?B?ZHRqTUUwRVlYdHhNYnBsT3FBYmVsN1VNR05QbDlMUlpjUC9ER0JpTVZnYkNJ?=
 =?utf-8?B?WTF1SWZJWWZtUjY1WTNqMjhPbXZFYW11SkNhU3JyMTQ5bzZZbEt3MEhtMFBK?=
 =?utf-8?B?U0dLb3hNcStDdDFRcDVLRmZ4SU9NUjkxTFFKOHFETUdNU1hBbWNiNm1JR0Nh?=
 =?utf-8?B?My9CeHRTRi9VbG8ydnFzbnd0L2NUT1FFRTQzZzZQdHR5M2wydW9sMW51MFl5?=
 =?utf-8?B?bXN0Y2lhem16RGs4RlgwU0RlOU5yeVY5Sk95encvTUYvd1J2VXhUZTZWMWJK?=
 =?utf-8?B?d2pQVmhCUDRpaGdGQTdCL0xxMlhudVZEb2E4S3JueDlOTVpkNzlRM2x3UDNM?=
 =?utf-8?B?ZEJRbE1wTDlqYVJaY2Z5UU9aQk4vK1BkWWREajhYQ0FQV2xnTGR5Y3pqK2VF?=
 =?utf-8?B?ZVZ4eXFQSG1DRmlkc2tKVUMzOXI1RnlPaytoNXo2VG4wa1lKYkZHTGxpVGN5?=
 =?utf-8?B?SDJhekV6YWpDeXdRcmtoK09McjM2Tmc5N0JTRGtKV3JHNU9XVlp1bmpGd244?=
 =?utf-8?B?OS96UjBXYWFBZ1hyYkIyaTU5Y3pKY0hpN0ZlVkh1azI5bEM3aFJPYlRmMlZF?=
 =?utf-8?B?ZWZjNVhFSlpGQldZd0RGNVpWL1pNMUd2Q21haGthcGRSOE9qcXRmNVpFRFMy?=
 =?utf-8?B?Y0gvRlhGVDdsc0xWekZDU0F1TFZmZmNPOHJydGQzamdvZDZMZldmKzR6UkxT?=
 =?utf-8?B?SVBwNVQvcEF3R2RCeUNNOWh1SFZBUHVuSWhYQmp3aHpBRFlJb0g0NHZUV3gz?=
 =?utf-8?B?cTlGQTY5aEF1TXd0VUdSMzcwKzRlamxZL3RIZnByQjFVb015WXZpNmMxUmVt?=
 =?utf-8?B?d2pnWjlUb1ZZSmR2bE9PcStTQ29QOE82UGVUcWhUNFM2VE5rNDFORG9NQThy?=
 =?utf-8?B?bUVDdFB6WEtXMEVPaVdsdERmdWhTb1BOc3dFUUNBN3BVUXpKaFVJZWdFT2tn?=
 =?utf-8?B?UEExSTlEZWNQbUV3czNRUVM0UWlMeXhuMXdNZE1kNXRuU3BxMzFuRE54NWZq?=
 =?utf-8?B?U3lrSkFsb09hTW0vV1JHYi9CZU5tSFRsVTFvQ2NWekVwSGxCU05qL0NDTkxE?=
 =?utf-8?B?YTkxSkdIbjhvbURLak9LYWpiS09XRUp1ZDNuZVNOaFF0bjVEZlVoZUowRTJ5?=
 =?utf-8?B?b0EwVzdCa2MyVXZKSGZRUlZkbXRnakdxRXNEallYVk9ydjZjdysxakVZamlQ?=
 =?utf-8?B?bFlKeFRneTY0SEVrQ0RJZzFIVTc2TFpzN2Mxam9kUlc3YUlEdEZZUmNnMmpq?=
 =?utf-8?B?VjloNTNRYUgwek5BZnAzeTRFVnlkc2dGMlVpSmhmWEFHc3pIdkxtWVFwTmFS?=
 =?utf-8?B?a1R6SmlJVS9iSmVIa21la3VOUTVINjBSZ3BSK3FObnVvb3p0R0tmc2dGeTJj?=
 =?utf-8?B?N1Z2TlFZOXNuMWl5SmlMOU43V2lhUXZqQm9RLzZUdVVxOWc0OS9ra0tKZW1X?=
 =?utf-8?B?WTltUGhOQjhTblNFU1BYcEVoQlhaaGp3RVE1N2p2RUs0bVlSU084K25NUjhk?=
 =?utf-8?B?SmxrVEhrT1pZRmllQm5OaUowTCsxRUM5M25UNzlEa2QyQ2xxd21aZE9kQmJX?=
 =?utf-8?B?T3U3YnFNV2ZnS3ZnekdOT3dueDNwT1ZMT3ByRC9JcGFHQ1B2anZBWGZsK3Bl?=
 =?utf-8?B?SWh5cVEweEkrZ3ptaDBpVThrOWQ3M3lsV1pXOTl3anJna0ZnZ3VEc00zQ3Ju?=
 =?utf-8?B?bWRXRG1kQVB6OXV3OFBzUm5mZG5HTUFVelBvblVtUm5FaHNoZ0NsTXZ6aCtk?=
 =?utf-8?B?Z2c9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 978ebec6-6b94-4cea-9af9-08dbce141a4c
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6896.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 06:49:54.0748
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EoyM4FVZqU2iYx7JQPnMXB14/ErAMq5DSbyh1yeHyfbYpscht9QLrDOuPHakGF0NBmobVqQaoj1FSeFh5HUlE4OxcKyDbkqIvkyAi2Mu/XU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR03MB6578
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 15 Oct 2023 23:50:53 -0700 (PDT)

Hi Stephen & Jerome,
        Thanks for your reply.

On 2023/10/14 06:01, Stephen Boyd wrote:
> [ EXTERNAL EMAIL ]
> 
> Quoting Jerome Brunet (2023-10-13 00:38:14)
>>
>> On Thu 12 Oct 2023 at 16:51, Stephen Boyd <sboyd@kernel.org> wrote:
>>
>>> Quoting Xianwei Zhao (2023-10-09 23:29:17)
>>>> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
>>>> index 76be4bbd2afb..c8d59d28c8ff 100644
>>>> --- a/drivers/clk/meson/Kconfig
>>>> +++ b/drivers/clk/meson/Kconfig
>>>> @@ -140,6 +140,19 @@ config COMMON_CLK_C3_PLL
>>>>            Say Y if you want the board to work, because PLLs are the parent of most
>>>>            peripherals.
>>>>
>>>> +config COMMON_CLK_C3_PERIPHERALS
>>>> +       tristate "Amlogic C3 peripherals clock controller"
>>>> +       default y
>>>
>>> Why are these default y? They should depend on something like ARM64 and
>>> even then I don't see why we want to enable them by default if we're
>>> building the ARM64 kernel.
>>
>> Should indeed depend on ARM64.
> 
> Cool. >
Will add depend on ARM64  in next version.
>>
>> Those are the main clock controllers. Like for other AML SoC families,
>> they are necessary to boot the device which is why they use 'default y'
>>
>> Is it a problem ?
>>
>> The whole meson directory depends on ARCH_MESON, so the drivers will go
>> away if Amlogic support is removed on ARM64.
> 
> No it isn't a problem if the entire section is implicitly depending on
> ARCH_MESON.