Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Mon, 16 Oct 2023 09:11:44 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the rtc tree
Message-ID: <20231016071144.7nklsco5tszvgotw@pengutronix.de>
References: <20231016151522.06839671@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="rvsjrlvlvktkge5m"
Content-Disposition: inline
In-Reply-To: <20231016151522.06839671@canb.auug.org.au>
Precedence: bulk


--rvsjrlvlvktkge5m
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Mon, Oct 16, 2023 at 03:15:22PM +1100, Stephen Rothwell wrote:
> After merging the rtc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>=20
> drivers/rtc/rtc-at91rm9200.c:561:13: error: 'at91_rtc_remove' defined but=
 not used [-Werror=3Dunused-function]
>   561 | static void at91_rtc_remove(struct platform_device *pdev)
>       |             ^~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>=20
> Caused by commit
>=20
>   48bc8830fbed ("rtc: at91rm9200: Convert to platform remove callback ret=
urning void")

Ah, yes, sorry I missed that. That's what my coccinelle patch does (for
reasons unknown to me). For some other patches I noticed that, but this
one slipped through.

> This function lost its __exit attribute (which includes a "used"
> attribute) and exit_p(x) is NULL when not being built with
> CONFIG_MODULE set.  This build has CONFIG_RTC_DRV_AT91RM9200=3Dy

The better fix is to add the __exit again and I see that's what
Alexandre did in his rtc-next already.

Thanks for cleaning up after me,
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--rvsjrlvlvktkge5m
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmUs4i8ACgkQj4D7WH0S
/k7hXwgArrKoKYfLJLvcl5mj5813lgHjY9Fy00tjhBTZ2Hj2bHx/8rAcECwg0cj1
R1FkqOgRC5NEfP6ubCt1a+1WmPYzJ20NiP2M2wWkpuXrR/6gHCb6Djs3xzQbC+Sb
n6s0Ij1iqylbCmoAtyNLNPbHs2igbXpmPItvdUTq0K22AF4oAnAifojTCC4bu/tr
3jsUORj4zWb4cZ1/Nr85yUgHZlzQ1BOWbrQ1bJATuHGG4LrtMQt5u/BIH0I8Ue5i
hv/FCPNxRLVbcTXwMIhZ35I7Qs2vzRo5qRZAm8SvRWCaIj0AnogAecOS0pl1zOZq
E8LKa/Zzbt0aWoMugAn2kZ7ygtgBrA==
=e5GS
-----END PGP SIGNATURE-----

--rvsjrlvlvktkge5m--