Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2329736rdg; Mon, 16 Oct 2023 00:14:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGEZXAQUDoy/nA49XyPgmBi/h94qunZ7jZJHoDoJcUCVKOqpy1R0i//JC4IuMSWM542xdN5 X-Received: by 2002:a05:6a00:1995:b0:6be:260e:a1da with SMTP id d21-20020a056a00199500b006be260ea1damr1380847pfl.21.1697440475718; Mon, 16 Oct 2023 00:14:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697440475; cv=none; d=google.com; s=arc-20160816; b=uiAs5bIP8ZQtCOaLNTEIJ+TYZpMLEd2EgNgx+/t42O51Flaf9rT4zky24a5fd52u6/ fzQV7rZ1Tyy1slnsVHY6e4HpYV4ogzF0f0n3vb88AH659qjrUV2XE5AAnE/AXhEW0fWt WpVfqGoDqt01hWlsXxiUtz6HPGjCCqwQckT6jFIAz9w2Q86hfPCYnzcaNe5qxUwMxJvN m8RJSM1Hh/Bcuuply3fNngW0X7aSMQDMnT0kRKMb8CnbYCmWuGCZTggQeptY4tPp2qsI l1v33e3HKCyO2HXHnbJ4+9iICBtntPQhiIXuXg2Mbds0gGdURUehxrE+hcYR4Uwrvw61 gymQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=LUr2o1si/SnskQFF5AYV1SV5bu+GcgWqJP7WDNSua8g=; fh=OYQKZ2AY9erPBJVbR+EvUglt7Z1HsafvSvE7UFw3wmQ=; b=jy+nDIxgulEzUJTqQ4bo3eE2Pu2C9bw25zRuV2ye3OKf+mAklrS3Iz+K1J0FKeI5L8 /R3C6BiwPOeb5kqCu9k+iXfBx9nAZxJzB8Cy/sZLsW/HP/rh9gFK3m2Z7/tWOSsYgl9O 3WurvwSLAY0av8yjX4TVwmN0sND3GZXAXpE0SblhZ0VtJGuXIoX8a9cy5WgZPqN5A5WV KJJB4RfZzF5nzVnPDxnqNBPqEaGwNJP5PMEOj8d6H2QHsvWoPg456G3Fjnn6D3RyvJly s3b01Wm8wHldUXt9eqJQ4I5rMMCCC9Ac1p2DZwLE5SeHte9947MuU30JxgPN/FuVOg8+ OGcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id b17-20020a056a000cd100b006bdb7c5f75dsi2789326pfv.357.2023.10.16.00.14.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 00:14:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 47D9B8031AFB; Mon, 16 Oct 2023 00:14:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232012AbjJPHOV (ORCPT + 99 others); Mon, 16 Oct 2023 03:14:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232114AbjJPHOE (ORCPT ); Mon, 16 Oct 2023 03:14:04 -0400 Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9E79F1; Mon, 16 Oct 2023 00:13:53 -0700 (PDT) Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1qsHnI-007WDP-7j; Mon, 16 Oct 2023 09:13:40 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qsHnH-00A6JI-D9; Mon, 16 Oct 2023 09:13:39 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 11C8C240052; Mon, 16 Oct 2023 09:13:39 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 5C94624004D; Mon, 16 Oct 2023 09:13:38 +0200 (CEST) Received: from localhost.localdomain (unknown [10.2.3.40]) by mail.dev.tdt.de (Postfix) with ESMTPSA id 27CD12BE05; Mon, 16 Oct 2023 09:13:38 +0200 (CEST) From: Florian Eckert To: Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, pavel@ucw.cz, lee@kernel.org, kabel@kernel.org, u.kleine-koenig@pengutronix.de Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-leds@vger.kernel.org, kernel test robot Subject: [PATCH v3 3/4] trigger: ledtrig-tty: move variable definition to the top Date: Mon, 16 Oct 2023 09:13:31 +0200 Message-ID: <20231016071332.597654-4-fe@dev.tdt.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231016071332.597654-1-fe@dev.tdt.de> References: <20231016071332.597654-1-fe@dev.tdt.de> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Content-Transfer-Encoding: quoted-printable X-purgate-type: clean X-purgate: clean X-purgate-ID: 151534::1697440420-076036AA-82120C7B/0/0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 16 Oct 2023 00:14:32 -0700 (PDT) Has complained about the following construct: drivers/leds/trigger/ledtrig-tty.c:362:3: error: a label can only be part of a statement and a declaration is not a statement Hence move the variable definition to the beginning of the function. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202309270440.IJB24Xap-lkp@i= ntel.com/ Signed-off-by: Florian Eckert --- drivers/leds/trigger/ledtrig-tty.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/leds/trigger/ledtrig-tty.c b/drivers/leds/trigger/le= dtrig-tty.c index 8ae0d2d284af..1c6fadf0b856 100644 --- a/drivers/leds/trigger/ledtrig-tty.c +++ b/drivers/leds/trigger/ledtrig-tty.c @@ -82,6 +82,7 @@ static void ledtrig_tty_work(struct work_struct *work) { struct ledtrig_tty_data *trigger_data =3D container_of(work, struct ledtrig_tty_data, dwork.work); + unsigned long interval =3D LEDTRIG_TTY_INTERVAL; struct serial_icounter_struct icount; int ret; =20 @@ -124,8 +125,6 @@ static void ledtrig_tty_work(struct work_struct *work= ) =20 if (icount.rx !=3D trigger_data->rx || icount.tx !=3D trigger_data->tx) { - unsigned long interval =3D LEDTRIG_TTY_INTERVAL; - led_blink_set_oneshot(trigger_data->led_cdev, &interval, &interval, 0); =20 --=20 2.30.2