Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2343541rdg; Mon, 16 Oct 2023 00:55:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlWofK3BP8V3iX1RN5gsglIgYgxjgYBTpQzbfQV9XAfe+Ji687wv7oSLYp29R98YDhsqq0 X-Received: by 2002:a05:6a20:3241:b0:174:327c:d9a4 with SMTP id hm1-20020a056a20324100b00174327cd9a4mr8788925pzc.61.1697442922890; Mon, 16 Oct 2023 00:55:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697442922; cv=none; d=google.com; s=arc-20160816; b=SRM9sVbKhvwxupmtXHf67hTW3xrHkGzijcQhyb3ig52Bo/dpYBbZT1xNdgTjQPzsMQ RJSfs7/O+xMwZBq827pa8URmYZXVDp6oFAnnnZ69D3YKa9gnjGYKGod8ylngCB0/GkVc xwQojve5VKV0kxwGCd6w25gUDvjE8yjQ8VzL7GaIfCHukq8iuRqWEZZDJgj5q/ZVDttO h7xvbawsdEaSg7M+DbqWCCpEpug8DZl0YENHaQ0jBZQ0kqbDGLV/SrX75zsNmo7Yhn8V TkKA9nBEGDw16KTorEnAHaBcf4/i9ukMjOnWsP+OJ4Du2uYTr2cB5uyFtdZs2R0hZqHp JdGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=5M8O1zNeRanGoSoTtH3IDw66Lx/GztB1CuLKWBrRnTs=; fh=HJk/5Hq1G+XGARbuIlY5w0N3BVB/k7ccPNyTiu/x3/A=; b=RPns1qW06JEOIx8hN/++p5scdRcROnGpivBktICrB7b8ubksvFaNar89hbUeafygJj m+Y0x1AA7hmycUNtGClzY5SUeLS4a8aNFRa1XSHx4B+AQm64ir+Obgng5MayDW/YauYv KRAx9trOa8C7/pWaRQYLXxFDrE160FCwUUbcCqqM23M9IdRk1/h5Tv0IF7rwMRCxHbWa G2H3GIOdgQSGNgG5PxGiUt2Z+cE6hg9lSbxqTRLA8CvlzF1KZ0n6A5NjBce6Vq81BRdV fH14Yiyl1L95YzGYPZjJPzu68c24mb1RICo02i0o0yKOgz+7trY22Uy565C8Pw+gmVAH hnfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=mGufDXs9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id h3-20020a170902f54300b001ca0b64f5a6si6866996plf.449.2023.10.16.00.55.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 00:55:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=mGufDXs9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 8E56680569B3; Mon, 16 Oct 2023 00:55:20 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230163AbjJPHzM (ORCPT + 99 others); Mon, 16 Oct 2023 03:55:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229621AbjJPHzL (ORCPT ); Mon, 16 Oct 2023 03:55:11 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A559AD for ; Mon, 16 Oct 2023 00:55:09 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 7F7A56607285; Mon, 16 Oct 2023 08:55:06 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1697442907; bh=Hw/1U1YBl+D02Eq2vlklAKGEowzhCs7qY+uoAbH7NQY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mGufDXs98MhuhzR+u3zf2PtniyqEwDciCV/Nzd2JHBNs/vsRNZrcECmmpYdiUoEk0 ml0xwaR2Y7J9Y5B90BokwGr4JxbJxZvc/cE6vkdcJ5Iuy/OsUvEUN/qzYyPpx4S9RD W3716ERYdtNQ6iucVEyDbS1V62+/m2GAEMtPjMfdDS82aBz9WCrSpMYWXcbVTbMX96 PPqdS7Xz3gupbI0Tg8SoIc66Brbe6nmhrJQtDgCc3MBqtqOtPXHd53209EmTf3jJjl VZO3wFrAoxcP+6t7eP1PwRCmulTmLhNp89j940cHO93H56J1+307T8s/JkmsG0NoZu zaJzLdZQxL2QA== Message-ID: <5b843706-8ec3-6de6-de24-ddde5349db57@collabora.com> Date: Mon, 16 Oct 2023 09:55:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v11 06/16] drm/mediatek: gamma: Use bitfield macros Content-Language: en-US To: =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , "chunkuang.hu@kernel.org" Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "wenst@chromium.org" , =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "kernel@collabora.com" , "daniel@ffwll.ch" , "p.zabel@pengutronix.de" , "dri-devel@lists.freedesktop.org" , "amergnat@baylibre.com" , "airlied@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "ehristev@collabora.com" , "nfraprado@collabora.com" References: <20231012095736.100784-1-angelogioacchino.delregno@collabora.com> <20231012095736.100784-7-angelogioacchino.delregno@collabora.com> <3399bf15a6e3d3d4ed5228c858b06c7b28b40aea.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <3399bf15a6e3d3d4ed5228c858b06c7b28b40aea.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 16 Oct 2023 00:55:20 -0700 (PDT) Il 13/10/23 06:00, CK Hu (胡俊光) ha scritto: > Hi, Angelo: > > On Thu, 2023-10-12 at 11:57 +0200, AngeloGioacchino Del Regno wrote: >> Make the code more robust and improve readability by using bitfield >> macros instead of open coding bit operations. >> While at it, also add a definition for LUT_BITS_DEFAULT. > > When I apply, I would remove the description of LUT_BITS_DEFAULT. > > Reviewed-by: CK Hu Sorry for forgetting about removing that from the commit description after removing it from the code. Thanks for removing it while applying, that simplifies my workflow. Cheers, Angelo