Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2347904rdg; Mon, 16 Oct 2023 01:06:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH/TsEpG0SOwLY5+RZW7dv2e0wZocLwdwFxX7PB9FPfatrhE3yGLZZ8GXKfXFFYgTZyGz7e X-Received: by 2002:a67:e197:0:b0:457:c4de:c048 with SMTP id e23-20020a67e197000000b00457c4dec048mr5966147vsl.24.1697443574487; Mon, 16 Oct 2023 01:06:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697443574; cv=none; d=google.com; s=arc-20160816; b=Bh0Z+HStUm/T9hJIrHCiAFyeNEnhmRqeaNfL19ofMd3F/lUGTKcLwKXn0wHKpmn4jl RnEHIaU8JGbAW9dO/wzAZifxoRzkR1W0rJwcmItkMr1oBSXoy9Mr66XQwA3wGjk7cLss zzXQfIObuxcs1QNb/f7yJWCJzYlAMsLdjVKDSXiFv7jkwDwNjUQ9VUTLGpLLcFWsfoNZ RrXE1aak7rAyoNw/QjHxgrqnOyNxGIyogNIonLnBjR4OqS3doW2ZZfZSYLihf0zwOpmP 1V2UY52K5r+OtNAnD1XY/XBsamsHe5BRO4IJLXdAf8oRCfrb5UwiOZr37+E5ZmuBP2un ouTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zOh5+Hvqm1TjtgtQRv2vFYzQB8/P7OPPw4knJn/RaTg=; fh=hpIJmcVMPhgkMjHRHKuCou5A5XsBlN3djdlNvZGY7TM=; b=d4p6nCKoJ9YEouQYL0EcKyjFyUo5XiVNCtAd3p2mljc28cAgB+NPFT1zq7QT1qfb+S uNOKNf6oPAtmklMHFkxIEXShiZirTjOs5IDZnS9EmaetYoCEcMZ+V9/wu6bb3UUgcCka DH/MbeHWkZEX4nu6BoOj30SP3/O5tKCfQ91e255ttlLL8Gk5f6LIt6klx6uCx6CjGcbk 0RH5ckk9+9Ck3/CZ7mAEpIgrPjmjs5CJnae8DZeYM0Y5jeTn89PMcS0235TfxHSGxkF6 XhEbM9ZqdvtmG0xLO38PnX7/mm9UlfDfUyAM6ikWYZT/RUT5EEVZ5T7+tOORoH7Loyrv qHiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id g6-20020a056a0023c600b00690c6da95c4si23358085pfc.273.2023.10.16.01.06.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 01:06:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 6202880BEF27; Mon, 16 Oct 2023 01:06:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231861AbjJPIGE (ORCPT + 99 others); Mon, 16 Oct 2023 04:06:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229621AbjJPIGC (ORCPT ); Mon, 16 Oct 2023 04:06:02 -0400 Received: from out28-218.mail.aliyun.com (out28-218.mail.aliyun.com [115.124.28.218]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B783DE; Mon, 16 Oct 2023 01:05:59 -0700 (PDT) X-Alimail-AntiSpam: AC=CONTINUE;BC=0.2612196|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_news_journal|0.0128076-0.000445282-0.986747;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047208;MF=wangweidong.a@awinic.com;NM=1;PH=DS;RN=27;RT=27;SR=0;TI=SMTPD_---.V04MZU._1697443545; Received: from ubuntu-VirtualBox..(mailfrom:wangweidong.a@awinic.com fp:SMTPD_---.V04MZU._1697443545) by smtp.aliyun-inc.com; Mon, 16 Oct 2023 16:05:53 +0800 From: wangweidong.a@awinic.com To: krzysztof.kozlowski@linaro.org Cc: 13916275206@139.com, alsa-devel@alsa-project.org, arnd@arndb.de, broonie@kernel.org, ckeepax@opensource.cirrus.com, colin.i.king@gmail.com, conor+dt@kernel.org, dan.carpenter@linaro.org, devicetree@vger.kernel.org, fido_max@inbox.ru, herve.codina@bootlin.com, krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, liweilei@awinic.com, perex@perex.cz, rf@opensource.cirrus.com, robh+dt@kernel.org, ryans.lee@analog.com, sebastian.reichel@collabora.com, shumingf@realtek.com, tiwai@suse.com, trix@redhat.com, wangweidong.a@awinic.com, yijiangtao@awinic.com Subject: Re: [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver Date: Mon, 16 Oct 2023 16:05:44 +0800 Message-ID: <20231016080544.45778-1-wangweidong.a@awinic.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <37a2d2d1-5ede-4f88-b4e7-d9750336465d@linaro.org> References: <37a2d2d1-5ede-4f88-b4e7-d9750336465d@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 16 Oct 2023 01:06:12 -0700 (PDT) Thank you very much for your review On 13/10/2023 13:50, +200 krzysztof.kozlowski@linaro.org wrote: > On 13/10/2023 12:42, wangweidong.a@awinic.com wrote: >> From: Weidong Wang >> >> Add i2c and amplifier registration for >> aw88399 and their associated operation functions. >> >> + >> +static void aw88399_hw_reset(struct aw88399 *aw88399) >> +{ >> + if (aw88399->reset_gpio) { >> + gpiod_set_value_cansleep(aw88399->reset_gpio, 0); >> + usleep_range(AW88399_1000_US, AW88399_1000_US + 10); >> + gpiod_set_value_cansleep(aw88399->reset_gpio, 1); > Why do you leave the device in reset state? I think you wanted these > reverted. our chip is reset at low level, So I'll change it to gpiod_set_value_cansleep(aw88399->reset_gpio, 1); usleep_range(AW88399_1000_US, AW88399_1000_US + 10); gpiod_set_value_cansleep(aw88399->reset_gpio, 0); usleep_range(AW88399_1000_US, AW88399_1000_US + 10); gpiod_set_value_cansleep(aw88399->reset_gpio, 1); Thanks again for your advice. Best regards, Weidong Wang