Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
To:     Justin Stitt <justinstitt@google.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-hardening@vger.kernel.org" <linux-hardening@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH v1 net-next 7/7] igc: replace deprecated
 strncpy with strscpy
Thread-Topic: [Intel-wired-lan] [PATCH v1 net-next 7/7] igc: replace
 deprecated strncpy with strscpy
Thread-Index: AQHZ/T+jVnib2VOsXUmx3jIDO1iTELBMHQTQ
Date:   Mon, 16 Oct 2023 08:37:49 +0000
Message-ID: <BL0PR11MB3122350138D0C03C3EA162C1BDD7A@BL0PR11MB3122.namprd11.prod.outlook.com>
References: <20231010-netdev-replace-strncpy-resend-as-series-v1-0-caf9f0f2f021@google.com>
 <20231010-netdev-replace-strncpy-resend-as-series-v1-7-caf9f0f2f021@google.com>
In-Reply-To: <20231010-netdev-replace-strncpy-resend-as-series-v1-7-caf9f0f2f021@google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AmxnJPUx9a9g1jRynpE581gVLSFPHD1MIpaLXFlh83JQhtPEzlSI0ZBDVg5Z?=
 =?us-ascii?Q?zxj94MV8r3Mu8tdKGeSkH+4TvRVEeFnl6w8C32Wqqcs2wNswXmetOFUBMwOa?=
 =?us-ascii?Q?8a/ytBsyBmqdKUCWePr7G6GwECimkHC/fgTanHPrV3r0GpRiCHS/vbe3p8yD?=
 =?us-ascii?Q?WZysa+cWXQBqfR2EZipvZSqlGc/ObbInSh7prYsBFgwizsu4DvkI87+WxfzG?=
 =?us-ascii?Q?769Lz9dlScMmjub0BBcYbdhCIMNdmICvLg3+sxxsp2YwksjR2DofyboxPRNK?=
 =?us-ascii?Q?Fzmx4yKo0cj8u//B20a1k7170npLeYVPvjctXLoRYGR9Aq5jAks/TBBqNbNb?=
 =?us-ascii?Q?ib3OX+BRFQRKwcJClsAzhrHdCwd+Xzp8rwgFov1/IqDz5ONoYwdP9sroVOSv?=
 =?us-ascii?Q?ygqR8ySLUlRlMKk8ABGngHay41vAbGl4sUjO07eVNcgWfajbnoHtG66e5trM?=
 =?us-ascii?Q?KOhMQHRZ7DbbfqE1ys+96YE8CHPweCNEsJSYIjIEkQSuP87agiw9cRXc9guV?=
 =?us-ascii?Q?gE0Doh/mGFEQtpxHymqoRlhB5oAM4EgugjfKZwYIlAgpgj6cE2OzMZrgE3CN?=
 =?us-ascii?Q?jKLUpemPHRwGqhATGE4w9zOqTQZiLgyewo+VbJu3z6rexwS0Ep2JA9QDedgX?=
 =?us-ascii?Q?P5Q65mbS+ixvKM5YUTMgTUW5vZZs3KuWmS4l1uARDm6YOGk0IiElihV/APc9?=
 =?us-ascii?Q?A0H19q57ucowQYWqGocMcG8UiLOp+1PO5Zdpw2LydXLEWY/PIpTkJlUAhEP+?=
 =?us-ascii?Q?RE/UHqRJBEDIVBxP6gbfFEAtIF78cb/VPjeP5rKYEnQE2ZDV+3puPOayLpP8?=
 =?us-ascii?Q?VjpPH+RuCU0DDSeHNJZeuABPy4zLfdg77qG5ykWpjpgKf1sqUtGNF3jXtnc0?=
 =?us-ascii?Q?RV61bk7mvVV+2j7tiKOUPd+nAkFX72Y1veISesWi5K/Py4W1w+amEIUuuH1g?=
 =?us-ascii?Q?LQ3WsHvTsK2TwZi9r9hC2OBMr6e5wO8qf1qFCxf86JCMCII+IDpX8qkA2f6v?=
 =?us-ascii?Q?S7S7cKe3z70mlUmiLk2hLawkgLK1rLSVgvmG6GuRZ1SfIF4XdxQeEU5RAVZz?=
 =?us-ascii?Q?PlpbPq8DGS6ljwiw4Dj4NwVU1YVQuCQP2E0D1H8XQbf5855f2nBZo527f3UZ?=
 =?us-ascii?Q?oqb+6v4yn+DDDVEbNYnbRuGnV33juipGfJIgf5ksIU3xhC7TRhJRi2o5X8Fh?=
 =?us-ascii?Q?mvTNnFYG593gpUrPJ/feTovmFlU9eZZrmSY3D7ctFqBRC/d//laj2TyJuBJT?=
 =?us-ascii?Q?ZM3t4pkVVBxp9rwmVXif7oFZZcX4wKzpycenTmIQ9+H70Epab7pB/Rt6nUS5?=
 =?us-ascii?Q?ctpo2WiLCV65b8nJ3OJy1+8uJj2tJj9OAiWh/aD5bjrLGHkKvRVCgEFaGBo/?=
 =?us-ascii?Q?DRMpLV9Sh00z0GYci+YZFJRXOSsbVOSg36rmex5OlwlcbXfdYymYqeNdJ53o?=
 =?us-ascii?Q?89Oc11ZyJ32TiGlH5QiZhsSz8gd34tKd8XyFbUKLPRP3iAQfMbvo18wo4Qfd?=
 =?us-ascii?Q?AgD5Th+07v6VN5cT4Ai+qDsxncNQavUnKAft7GwhV9LO9ElhZqo4XWkgJSkJ?=
 =?us-ascii?Q?iWL1hD7fytSOGCsMbAcGro6wi9fobB+/Ag/HV9HCvNtInXSnUfnwv5CfOw9A?=
 =?us-ascii?Q?Lw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3122.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf6de5ae-b15c-4dd5-88fa-08dbce232dda
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2023 08:37:49.1484
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6UjLviIXFVkxy+4LLHMcKU3wLeItfHZyozCEIY8JkHSF/bY5q/Pbue98QxK7ufkMmvUA79F5zD53miikjU3zeAY8+mno9UcJKkUGJyHQSrbxN6MF/6v4RbSFMHIxySPZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5582
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 16 Oct 2023 01:38:25 -0700 (PDT)

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of J=
ustin Stitt
> Sent: Wednesday, October 11, 2023 3:57 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <an=
thony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Duma=
zet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <p=
abeni@redhat.com>
> Cc: netdev@vger.kernel.org; Justin Stitt <justinstitt@google.com>; intel-=
wired-lan@lists.osuosl.org; linux-hardening@vger.kernel.org; linux-kernel@v=
ger.kernel.org
> Subject: [Intel-wired-lan] [PATCH v1 net-next 7/7] igc: replace deprecate=
d strncpy with strscpy
>
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We expect netdev->name to be NUL-terminated based on its use with format
> strings:
> |       if (q_vector->rx.ring && q_vector->tx.ring)
> |               sprintf(q_vector->name, "%s-TxRx-%u", netdev->name,
>
> Furthermore, we do not need NUL-padding as netdev is already
> zero-allocated:
> |       netdev =3D alloc_etherdev_mq(sizeof(struct igc_adapter),
> |                                  IGC_MAX_TX_QUEUES);
> ...
> alloc_etherdev() -> alloc_etherdev_mq() -> alloc_etherdev_mqs() ->
> alloc_netdev_mqs() ...
> |       p =3D kvzalloc(alloc_size, GFP_KERNEL_ACCOUNT | __GFP_RETRY_MAYFA=
IL);
>
> Considering the above, a suitable replacement is `strscpy` [2] due to
> the fact that it guarantees NUL-termination on the destination buffer
> without unnecessarily NUL-padding.
>
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strn=
cpy-on-nul-terminated-strings [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.h=
tml [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Justin Stitt <justinstitt@google.com>
>
> ---
> Note: build-tested only.
> ---
>  drivers/net/ethernet/intel/igc/igc_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Co=
ntingent worker at Intel)