Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
To:     Justin Stitt <justinstitt@google.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-hardening@vger.kernel.org" <linux-hardening@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH v1 net-next 6/7] igbvf: replace
 deprecated strncpy with strscpy
Thread-Topic: [Intel-wired-lan] [PATCH v1 net-next 6/7] igbvf: replace
 deprecated strncpy with strscpy
Thread-Index: AQHZ/T+nFgylK8wFBUmpNSCEvjYe8LBMHbNA
Date:   Mon, 16 Oct 2023 08:40:27 +0000
Message-ID: <BL0PR11MB3122358DE91FAE81F9852BC5BDD7A@BL0PR11MB3122.namprd11.prod.outlook.com>
References: <20231010-netdev-replace-strncpy-resend-as-series-v1-0-caf9f0f2f021@google.com>
 <20231010-netdev-replace-strncpy-resend-as-series-v1-6-caf9f0f2f021@google.com>
In-Reply-To: <20231010-netdev-replace-strncpy-resend-as-series-v1-6-caf9f0f2f021@google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IExhpO925X4YRiqnQMBiAOu8lp+qDpyzEphk/Pkyhj3NRgAejPzrFqVo3Lpo?=
 =?us-ascii?Q?sPbPTQLoCzCdfgZIyGrlsoGh1Wgir4zRzatEjaVyf1SFGBcyy5M0L9Cre5Dn?=
 =?us-ascii?Q?oNNRpwaM0Kg1RlhTn9HWQf7Rlqa8GLXGXysO/TfVBWAblThh7sMfjDSa5nJy?=
 =?us-ascii?Q?3Q+tINSzqWwd8LPFTvfM1uaYYGU10cyQQqgIdMcG+dN3ewnvE/E56MgKoSjj?=
 =?us-ascii?Q?Gli+7zuyr2JhmL9H4aYfYM5wlxAPaLQLhKVAk3cG6lxdU26aRgZSDZqeM+pd?=
 =?us-ascii?Q?E/6nkwe5YPhSFHwl452rGZ1HD8CjASHf5R28vTw9DZpiiKxlavZHPZCCMIhs?=
 =?us-ascii?Q?8xR6ZFMeuQ03goM5mKIr37xl1Xp/YkMF6PZWMOEpeR9AFXiARkkAPqUdspnh?=
 =?us-ascii?Q?K+G4WtyJAQQv2iV7ylc4s/e0jac4LzK81hkaLyrUDCwgkiemacDibf+d7GtT?=
 =?us-ascii?Q?bzcSyCcGDSrR7JgXBYUJ0GhB/XN5haATMS60EI3FqMz+fPNi/eyI1McWwj/y?=
 =?us-ascii?Q?hVkhxDtIAvXc2ga5gelxyzMDJpds/tGVzwBLoVlB/m3A1GSxqjVpkl14s3PX?=
 =?us-ascii?Q?ZSIKYDaL9p/Ie1k/5h9tFyS6ObdfNDYngNi3wmDQt3yedAIphRfQnWB81x0m?=
 =?us-ascii?Q?bIMDcAr8QjdeFxL2ZfyNsHhwSVXTxefLcU83ttNFumBy3EbHKbNuDMbeGQvx?=
 =?us-ascii?Q?dFx3fpk4PaSUArXi+Y9N6TCTtV2tZr5mL5NVUVPZuBJwlsqIsjlFIBoIc1BX?=
 =?us-ascii?Q?tD5SqGllpz+tcn8bkHhCxHRItF5/AZlKOYyIKd4zqWhDaCRRLA5BVgaGiLGA?=
 =?us-ascii?Q?8eRDab7hAFSImJ3Jvks7eYpCQ/K2gGkZoP0tL8rHl8l93NjMh1dO3ckPyCrD?=
 =?us-ascii?Q?b2DDwFt2o8F3kj1EdCCMFmcroFweogTrhqB7zgEl6B7510LPR4ZuCc7NIRxj?=
 =?us-ascii?Q?emC3KV1Mb/r0Efvax8MbcRwi3aJ+kekA+T6+yJQVmDKhDeVTrx+SHtem3eIe?=
 =?us-ascii?Q?5vQBddpZBzRgh9S5BfrG65xEbbMkZQ1c6MJyBIcP8DpUy3JdoLwB2bR95V9Q?=
 =?us-ascii?Q?p/i0hWanrIskZ7k+wCE34en1mPWUWTupjeSPNf8N93HzCZmvZtfyYhbiBr+u?=
 =?us-ascii?Q?IhUG3n9Qa1L2lvMehcC6aHLa23610DPQa7UC2FAFKoHbiyBVAOCVn5wcfhmY?=
 =?us-ascii?Q?dW+PEdA+P45rbXv6oCy25TsTqW4VD8W6c4txPMUYOSThMMKX8wTlvISEqRVg?=
 =?us-ascii?Q?R2VcKOVaRfdWz/NY8SC4f6CYe+aDHUtBAwBBkexPicUgB1rWNNAyZsOsK7NX?=
 =?us-ascii?Q?IBsnA3j0/4qvNpNWYk+f0dr0CfS+BW8Lf5gK2cBHIsjObGCubuumMJ7mXy1L?=
 =?us-ascii?Q?4HGKS9x+je3PAcQou76ynN7eD8cBk48F3WHz00lft7KKk+GJt4OS62Ov1ElN?=
 =?us-ascii?Q?tfPmhuok3bRlDyALe/aCtLinc0CbG+EH3pcoSxpeQ1EZe08FScLwRR1LbYP9?=
 =?us-ascii?Q?1NQxQgA0Tauzogqty6fh2QSn0MEYKiuEN4gH4coR0nFykQsQg7owuogaTf6N?=
 =?us-ascii?Q?Ule7OQV+t6qsqCjQukSc0xY3e8wNAcZalcH8pkyYtYe7B6n7hFjcB9RJSfNb?=
 =?us-ascii?Q?QA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3122.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b80bfa6-c886-4598-10b4-08dbce238c37
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2023 08:40:27.4238
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VSM4IzF8WFKjP7Jk2sk2cu0EFXJOJzupy1xQy4PhFro2fpLloKMqb1rNxSsVV42FL7/Q7qlSjzhZiJbKf2dcv07mprjql5vr/Y6VQKTnmIRACLxZnn47n4xbyYuJFYfh
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5582
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 16 Oct 2023 01:40:59 -0700 (PDT)

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of J=
ustin Stitt
> Sent: Wednesday, October 11, 2023 3:57 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <an=
thony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Duma=
zet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <p=
abeni@redhat.com>
> Cc: netdev@vger.kernel.org; Justin Stitt <justinstitt@google.com>; intel-=
wired-lan@lists.osuosl.org; linux-hardening@vger.kernel.org; linux-kernel@v=
ger.kernel.org
> Subject: [Intel-wired-lan] [PATCH v1 net-next 6/7] igbvf: replace depreca=
ted strncpy with strscpy
>
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We expect netdev->name to be NUL-terminated based on its usage with
> `strlen` and format strings:
> |       if (strlen(netdev->name) < (IFNAMSIZ - 5)) {
> |               sprintf(adapter->tx_ring->name, "%s-tx-0", netdev->name);
>
> Moreover, we do not need NUL-padding as netdev is already
> zero-allocated:
> |       netdev =3D alloc_etherdev(sizeof(struct igbvf_adapter));
> ...
> alloc_etherdev() -> alloc_etherdev_mq() -> alloc_etherdev_mqs() ->
> alloc_netdev_mqs() ...
> |       p =3D kvzalloc(alloc_size, GFP_KERNEL_ACCOUNT | __GFP_RETRY_MAYFA=
IL);
>
> Considering the above, a suitable replacement is `strscpy` [2] due to
> the fact that it guarantees NUL-termination on the destination buffer
> without unnecessarily NUL-padding.
>
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strn=
cpy-on-nul-terminated-strings [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.h=
tml [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Justin Stitt <justinstitt@google.com>
>
> ---
> Note: build-tested only.
> ---
>  drivers/net/ethernet/intel/igbvf/netdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Co=
ntingent worker at Intel)