Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
To:     Justin Stitt <justinstitt@google.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-hardening@vger.kernel.org" <linux-hardening@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH v1 net-next 5/7] igb: replace deprecated
 strncpy with strscpy
Thread-Topic: [Intel-wired-lan] [PATCH v1 net-next 5/7] igb: replace
 deprecated strncpy with strscpy
Thread-Index: AQHZ/T+bPCFv583f20G7YZ7XpIuXg7BMHmuQ
Date:   Mon, 16 Oct 2023 08:42:36 +0000
Message-ID: <BL0PR11MB31226EB326F7170325155973BDD7A@BL0PR11MB3122.namprd11.prod.outlook.com>
References: <20231010-netdev-replace-strncpy-resend-as-series-v1-0-caf9f0f2f021@google.com>
 <20231010-netdev-replace-strncpy-resend-as-series-v1-5-caf9f0f2f021@google.com>
In-Reply-To: <20231010-netdev-replace-strncpy-resend-as-series-v1-5-caf9f0f2f021@google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RLSPLCu/eH8ePT6PbcHI2CjkmKvM7quRxIiycbUgZCoGQIsiGGEFl3NAMQ6J?=
 =?us-ascii?Q?Lpf/QDS8TRYzJt5SHR9Ag6HJ84XqwnaAp8MhY0h5IMX/NpZqe30EI2/xJHDO?=
 =?us-ascii?Q?Pz3wUco8/+n2qd/lGXh0/qbfIZE59A8qjNOyj6BgbyR3xm4MlU66HJNJi/gf?=
 =?us-ascii?Q?atj1Q/+i5ck0oQPMOCfEAd7DSnM2pwBB9S6sG1CjRDWSV6m7NQyt6qGB2BYq?=
 =?us-ascii?Q?1T/vNCLHAx02j5bzE8xr6AXhbFb5AscaJ5FL2mNY+3LG2s592JL4/cTlVaVu?=
 =?us-ascii?Q?wq1snMdYxL0ECdXDuxGSsGzj/LBrpsnT6YGSqddXW+y4R5hboos9QBLLc9HR?=
 =?us-ascii?Q?9NhTKqiDelCHYGYY4ZbUqFA1ttSAu0y3sm4ZIkTOKH0xx4CCjyfsuPEzTl5g?=
 =?us-ascii?Q?gibHNV9GxeyEPYxQdlrdM05npPIfJPEtaxqlfZMHmJR2PeobPYLjsrlRc52B?=
 =?us-ascii?Q?WMrzOriwg3cLf75p3EdsoJHvoYBqwRjpsevwCknxP7w7xPvm0emNjXOMOm9B?=
 =?us-ascii?Q?xXhbNbHrXe7Olc1LpjmyACXgSW2eM5r/CpkxhQm9w8up+DSydWEx5koxVjUm?=
 =?us-ascii?Q?32yFTZXj0dDSUGJ2ZF9jpaksFEdQ5Z5LpiFRb23iP5CEckZPYXTw9Q1IGooo?=
 =?us-ascii?Q?f/qAXthLXMMk1ztBBbq/HWluCdl3QTAaqTY2/coaC4d1qvrpVvJ8yr68tc+T?=
 =?us-ascii?Q?6QGqvnXUj8t+WrLaM+5RlbLCnxBv/vQQGB/owG3VvzsUdxH+CpyPK0xieXMx?=
 =?us-ascii?Q?idD4qHZcmY0igcPrkctmNXwfwNismpNYqCYXjwdKmsdLR+1cK7HKIqfCnhbS?=
 =?us-ascii?Q?PPtUEPfP3lNKDeEq0dBWUUgr6D1oUXoau2otFfHQGyNUi+7bbJ1dvc+IAhnb?=
 =?us-ascii?Q?K35QdMevRUd0OwVjoYxZAm8hT5d+3597LQSg+LTQ41lZWlo1I/RvcnYIhPVX?=
 =?us-ascii?Q?xiPRNF80jGzFrqrAsoZCqB+eRvm4CQ+cZSdLHXF8fjXRfpxJwVp4OlBRzJ5b?=
 =?us-ascii?Q?wo9qvbr5BuMdn6Ifq4vdKyhMkI83B6vtLrLHEgGHnZcKnZrFf+tA+Bbsa2EU?=
 =?us-ascii?Q?K+hxH9OI6bWkeQir7pVK7xeH2XKPscKn0btTP1/9Y5OpFezEl2WCki4/S4i2?=
 =?us-ascii?Q?xU2BogNKYAr5EUCg6rl3xMNTePrgr3LBuKJyTQSydjED8ZzrSWkT7xP7hRK+?=
 =?us-ascii?Q?4ZSCbxNj4OQJieD8d1x9OlokZS6iAAzZIKtwLh7v3v98fD3HZ9IixupSgldh?=
 =?us-ascii?Q?PQ57I4fXReex4jLGhYmLNVhXvk3N9U0q41C/kOjfeEcJdVM0ZlCIfZqRO5oP?=
 =?us-ascii?Q?5vspqe40FX+V3MoKaTgH7U5eazPsjH/5LEJJGq02HGgJoKcnyjMfVLIyEGiX?=
 =?us-ascii?Q?EhZbqOCezEgxcbYzS5YLmpwDvddsuYDOo1z1+BWkeiXwBrfp6EGfYdiSzhDV?=
 =?us-ascii?Q?iq2UJc01DuZ2/9LYdMfZ7X13au6KbJFE7URysvghg/fs1B4ucDyDkeZmuoyG?=
 =?us-ascii?Q?MwXPJI/KQqHnVD18e6nxy/yBgWzcPrOajxU0hu2oq8jEGwqD9Ahc8qusAl2R?=
 =?us-ascii?Q?/iClTo3dDh6Zp7TqNg2E93BvBNwLPqu8DDvMuixs0D/kjLMQjUneACTK6rVk?=
 =?us-ascii?Q?IA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3122.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4298f313-bbd0-40d4-290f-08dbce23d967
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2023 08:42:36.9161
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /g3f/67YF9jdjVotD7Aj72KnRL9PLAE8WMNpfjP1UytDObPBKfSIrkoBAteNvWqYymytqu2nwIoXItWkRa+6D7EFqKaiuxg10vktK3yLvZVoqC5GPxHjg0/vfelvvasy
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5582
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 16 Oct 2023 01:42:49 -0700 (PDT)

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of J=
ustin Stitt
> Sent: Wednesday, October 11, 2023 3:57 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <an=
thony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Duma=
zet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <p=
abeni@redhat.com>
> Cc: netdev@vger.kernel.org; Justin Stitt <justinstitt@google.com>; intel-=
wired-lan@lists.osuosl.org; linux-hardening@vger.kernel.org; linux-kernel@v=
ger.kernel.org
> Subject: [Intel-wired-lan] [PATCH v1 net-next 5/7] igb: replace deprecate=
d strncpy with strscpy
>
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> We see that netdev->name is expected to be NUL-terminated based on its
> usage with format strings:
> |       sprintf(q_vector->name, "%s-TxRx-%u", netdev->name,
> |               q_vector->rx.ring->queue_index);
>
> Furthermore, NUL-padding is not required as netdev is already
> zero-allocated:
> |       netdev =3D alloc_etherdev_mq(sizeof(struct igb_adapter),
> |                                  IGB_MAX_TX_QUEUES);
> ...
> alloc_etherdev_mq() -> alloc_etherdev_mqs() -> alloc_netdev_mqs() ...
> |       p =3D kvzalloc(alloc_size, GFP_KERNEL_ACCOUNT | __GFP_RETRY_MAYFA=
IL);
>
> Considering the above, a suitable replacement is `strscpy` [2] due to
> the fact that it guarantees NUL-termination on the destination buffer
> without unnecessarily NUL-padding.
>
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strn=
cpy-on-nul-terminated-strings [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.h=
tml [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Justin Stitt <justinstitt@google.com>
>
> ---
> Note: build-tested only.
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Co=
ntingent worker at Intel)