Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@intel.com>
To:     Justin Stitt <justinstitt@google.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-hardening@vger.kernel.org" <linux-hardening@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH v1 net-next 4/7] i40e: use scnprintf
 over strncpy+strncat
Thread-Topic: [Intel-wired-lan] [PATCH v1 net-next 4/7] i40e: use scnprintf
 over strncpy+strncat
Thread-Index: AQHZ/T+Y8jlt2Vjx7Uex6MSFzmYz4bBMHy7Q
Date:   Mon, 16 Oct 2023 08:45:38 +0000
Message-ID: <BL0PR11MB3122A776FB2F62D5044B1D60BDD7A@BL0PR11MB3122.namprd11.prod.outlook.com>
References: <20231010-netdev-replace-strncpy-resend-as-series-v1-0-caf9f0f2f021@google.com>
 <20231010-netdev-replace-strncpy-resend-as-series-v1-4-caf9f0f2f021@google.com>
In-Reply-To: <20231010-netdev-replace-strncpy-resend-as-series-v1-4-caf9f0f2f021@google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2nFfsDy7LJwWwlx5fLKcImx1HChDyzOEdHySIdb77JnQJpnC4bTfX+g2HlXX?=
 =?us-ascii?Q?FRRY00wdAcghZzXek+N+5Zm4xNPr6dJYLIafPnwiRDVqEV6t9MRtNU23fwh8?=
 =?us-ascii?Q?6YwIfVp4DSFwc9XIhbrTs6fQOVPPh7aNRxOcrTLUh7FRnqT/hgyHD/EFfMXs?=
 =?us-ascii?Q?iVGgrtcrjBzEABZ3ZQvjsTinusuJskXfCQ/dWesuMgDHcbfXGOcujmdrMwcU?=
 =?us-ascii?Q?7YwEEeSv5PWkrH9al9rQJVmgB8+zTDEcfNi1V71pH15KUtD5yfGK7BwXoAG1?=
 =?us-ascii?Q?LxBHq9YjDShV/gud2ggfvbVfIncDjxeJonvIpTc3dT1rxJV5QmZWGzYPqgBl?=
 =?us-ascii?Q?NhB1few70+Eds2xUXRj8P+P/jg8EL+V/j7z4iy0Ne56MvOOyLD6Cfta7vSPQ?=
 =?us-ascii?Q?Y/Gdh7GBOXQgJg0hcQRIIGDWn2HnYvfqkVRmzwJcQA2AI0aNbyTG32/d/+fM?=
 =?us-ascii?Q?LoNcFGJWLxyUEtBRj0YnmA2nI2sIm0YPPg1Q+qvVg5y/tMPt1pGRl1t+jXSU?=
 =?us-ascii?Q?hvi4cQFjfKv9Ztcs9omGnHsJQgN6dvVU/uhEzqMiTz+LV0+ogWRR05UR7KYG?=
 =?us-ascii?Q?qmuV7apxQ7NbebsV4LM69rqOIekg/EZy4S7AqAxs4FZlbygMq+wPEmdk9hxq?=
 =?us-ascii?Q?ekObsCBtRDaeQC+NuHkH+umb+EEIaXrvirH6hZHYkEe0iCg0zYfZBGmxNGRg?=
 =?us-ascii?Q?bYi6VIPuwq/yNVywgr4D532PNRtyPJMPalivXwZAwk0ZbC7VPMIupv8dQGjm?=
 =?us-ascii?Q?jQdpHZyHU0xpNQcBSD4DgC4z0m3VJPGNHmVkKrvyILZQakAAnQ1TVs4YaY87?=
 =?us-ascii?Q?fGBl4LID645UJVHDJ+3DhJxKWwDBmgjM43+I4DyN3xa2esj1JDNafjtQLB5S?=
 =?us-ascii?Q?MMKU/rYZRdFzQY9K4899YX/8sWmA8bNiy2xtBdBdRvh8RFyYMP4FHXtk3eQO?=
 =?us-ascii?Q?p2j6hJuiCl6qW+TWjzcTOEAagPe3+GzccT9UaCiyKE3lZYMSGrK1XWfU2iPE?=
 =?us-ascii?Q?wFVIvfweZwAKZDhdOsmWX3aHH4PkzrzuIeH3SMRm7AKzFqIgUK7l9J1xhh81?=
 =?us-ascii?Q?XnXE73lyevNm+AStF3w//08lSAxNsupRVaYg0ZCWOal07lG67PRPtenadGcM?=
 =?us-ascii?Q?iztegDOz7fpOIIbVEe4vzX9b1RcJ8+qqx0IpAOj2SgrWaJDNf7G6+IC0+scF?=
 =?us-ascii?Q?R5vgugx8aopLrmCCZy5yN8bdVYypB3EfZiSvHCONlN9DU8mZVua/xvbqsSJJ?=
 =?us-ascii?Q?2o2fes/jaSsnh9ss2JZIVtkpwosdNTILbSAdMVc0q09Y8UtB5wLHL9r/kAdk?=
 =?us-ascii?Q?8XpuIh5VOZQyO0TytLjGhsTHFvjSwew5dOX9CfM9TlaP/btixbgr3Bx6lfcW?=
 =?us-ascii?Q?e80m94pP+mjr9wNpZxp6q/SjXltYX9fd1iLq2xp4Fp46FmeVWC+z4erJ9CzE?=
 =?us-ascii?Q?bDCjl4ayFY8EOIQHR/+QYEa3BEP1eixdxkrLK0+31RYJeiz834CkwC10irLi?=
 =?us-ascii?Q?7LzCehcykXjzSJ486q0ADxrmwFTKq6BGVpz9zULxowQjAPCb05vTU0zbPdSK?=
 =?us-ascii?Q?29uivkv0toOFdAgViLorEdaG+TzsiHCbJBtRPoyCUGiLOfpY7pJjL7k7dfkV?=
 =?us-ascii?Q?0g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3122.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c7823be9-0f01-4b2b-4add-08dbce24456d
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2023 08:45:38.1420
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5i92Jv7WbVSsT2jg6Q+lsE7xj+7CfzwFhPzNi2Ur05YRtd9LK/4jTvN5NqQ32pYoPTY/32tHVsDH9lo8xTzvc/WJ6X5qR5GsG/2dYToL644mlech92dxjQiy1Js2yroW
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5582
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 16 Oct 2023 01:46:06 -0700 (PDT)

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of J=
ustin Stitt
> Sent: Wednesday, October 11, 2023 3:57 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L <an=
thony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Eric Duma=
zet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <p=
abeni@redhat.com>
> Cc: netdev@vger.kernel.org; Justin Stitt <justinstitt@google.com>; intel-=
wired-lan@lists.osuosl.org; linux-hardening@vger.kernel.org; linux-kernel@v=
ger.kernel.org
> Subject: [Intel-wired-lan] [PATCH v1 net-next 4/7] i40e: use scnprintf ov=
er strncpy+strncat
>
> `strncpy` is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
>
> Moreover, `strncat` shouldn't really be used either as per
> fortify-string.h:
>  * Do not use this function. While FORTIFY_SOURCE tries to avoid
>  * read and write overflows, this is only possible when the sizes
>  * of @p and @q are known to the compiler. Prefer building the
>  * string with formatting, via scnprintf() or similar.
>
> Instead, use `scnprintf` with "%s%s" format string. This code is now
> more readable and robust.
>
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strn=
cpy-on-nul-terminated-strings [1]
> Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.h=
tml [2]
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Justin Stitt <justinstitt@google.com>
>
> ---
> Note: build-tested only.
> ---
>  drivers/net/ethernet/intel/i40e/i40e_ddp.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Co=
ntingent worker at Intel)