Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2361681rdg; Mon, 16 Oct 2023 01:46:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcNnU/g0aPVou5ivfJZYVBKQGAIP7APWSV6OffzX8eEcP5M5oFD9gc6NXsEBA+0iJSrKLW X-Received: by 2002:a17:90a:1988:b0:27d:8fbd:be8c with SMTP id 8-20020a17090a198800b0027d8fbdbe8cmr1616840pji.28.1697446014101; Mon, 16 Oct 2023 01:46:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697446014; cv=none; d=google.com; s=arc-20160816; b=fVRYG4LcPDcxLZPFBwL0NEMUmMOmc7Esn2BsYGg+jEDeKhcaOTSrPfz6BUP6JXce2l YucDfrk4pyd5gJHS6XcjfHX9JepSBWL6cNiRCAmGBSbTDZ1OSgSA8N16vVutfVcYJ2wp 1RizdOgmSX1ZimjX8Vvp2Lfb64Cap/T3ZsbIhnSpYt6UCNc+YTYVn54KhB7FIbiTMbqU +0pbayCSkIqX3JFbGJ0AIqI02tmPwsfN0oZz/TjmZmi9ZluuqQv5Hu5isHv6J1waBOyn jDayoeEjREhgmPIYRIJsKvUUDeHtxIAbWSKnN1YvLl9ZGZf1jt87t4qub1NQqzZrY92f v2jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Bx+1uK2uxz3AS67pDvs9fEtJH4P6/YIs+6GQTjHy+3o=; fh=cOckVxVjrM5jmf86/i5eTTw5wBLyeTzAmcCgKIUtB0I=; b=y28cEZEYlKYa/KoHtT5AhLfRfOw7MmDZ2DCjfjTWMERWtAkLRHtZg63Llbxu3OdouP 6Rcytv+fWlp1khk9ZsuoO2OIZzOvo3NQHmsGdpnl9OOaALCilzaT0poi3kOFVyAsK2C/ qgUodNnR6WcD0CQ1YmoQPn0k9BxO4frsz1/9+/xxZnxnxNnYj2je3tL1T62m73kLy7OD 8/fhabaCxdlSD3gOUQaz5/+Od8z5Q9bOpDvYpScSiyxt/pOomdOrqWeGWDYd89a0PJvU p66oOdzGWzNuc/Qxn/80u+5b7QTLoVUom4kmrgk0SzwUxJGueGzp16VSErHgVPjZOhtN mvDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HmYQSyZL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id mh5-20020a17090b4ac500b002774c17dd73si6210895pjb.11.2023.10.16.01.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 01:46:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HmYQSyZL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 468EB8045947; Mon, 16 Oct 2023 01:46:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232649AbjJPIqt (ORCPT + 99 others); Mon, 16 Oct 2023 04:46:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232693AbjJPIqr (ORCPT ); Mon, 16 Oct 2023 04:46:47 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82AEBED for ; Mon, 16 Oct 2023 01:46:45 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-40537481094so43315425e9.0 for ; Mon, 16 Oct 2023 01:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697446004; x=1698050804; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Bx+1uK2uxz3AS67pDvs9fEtJH4P6/YIs+6GQTjHy+3o=; b=HmYQSyZLFjtazJymlFDN2MQCBcnB7qnsEw2l3ofjG6tMad1ul8Qrf1vFaCeoRSUaIF y2YOyCidFlSIF4Kzp+Y0qeia8LeU5Lptzd1gCqFY+wt9ZPA5sz4YkoAC6yCCa/LLleZ5 0j+kbQuLFlJDl3g02k+UuLBh15ELyVai9gpczLhrGf0M6fJgRcWlVcf5kkxtoeNze4nw y8iHF5gxHJC+O7mOOvX7gPMkJLe/dGV5tZct/n+WXwjxJ0uu4ijJWq4AyjMIUW0mCGqp LXmCqA3FkBAD5UnSZ9mIns+XxKnCLOOcoQRsbNcqcAiJGsQA4O6dAHLR1aflIn/kpHuS BDgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697446004; x=1698050804; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bx+1uK2uxz3AS67pDvs9fEtJH4P6/YIs+6GQTjHy+3o=; b=ed/CPBDz5QC4qItSEAXpQCHiILq7iXI8assX+oV4YtEmUMIjqKzM83ZLEwxcOwMvGe JwS382AW8sWgv0zrWl/nkEY0FYAKcpZWHC0QwWitJG+DcE9nwpXIGbfnmNMlQw8lyYvf kPnfQgbEaRqg1r9hUEeFxuwGvnCDweOhT02oDJAjb6GJR5gI2loPYYSVOp3GXblb9Euy 3yGXm5KzR0IZ5pXzkR5FTno4PH2LKqXGDSeOWuCUWPmuaBQWCOB1zFE7AaaGOtpuaUC2 UR17/Opi5GrFucD3LjoXZn3484d629+dzl4oQmbiY2wDXU6d6d2gzkQ8RSVVKbULXlyz kWcw== X-Gm-Message-State: AOJu0YxvlWiOcmcaGmiqa/cqq/eAIJE/M5Gluk4OZ540OvsZ2pNgSBER fqkR7epZt71TlYIHjhr+72KuQh51UFJmG4OIj/0= X-Received: by 2002:a05:600c:600a:b0:406:eef6:3540 with SMTP id az10-20020a05600c600a00b00406eef63540mr24264663wmb.0.1697446003901; Mon, 16 Oct 2023 01:46:43 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id f12-20020a05600c4e8c00b0040772934b12sm6672102wmq.7.2023.10.16.01.46.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 01:46:43 -0700 (PDT) Date: Mon, 16 Oct 2023 11:46:40 +0300 From: Dan Carpenter To: Calvince Otieno Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Luke Koch , Bagas Sanjaya , Simon Horman , linux-staging@lists.linux.dev Subject: Re: [PATCH v2] staging: wlan-ng: remove helper function prism2sta_inf_handover() Message-ID: References: <67d90726-15b9-4d64-87c6-bfbf662cbe81@kadam.mountain> <4c29cb7a-3b24-4682-9211-09aff1e01360@kadam.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4c29cb7a-3b24-4682-9211-09aff1e01360@kadam.mountain> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 16 Oct 2023 01:46:53 -0700 (PDT) On Mon, Oct 16, 2023 at 07:40:57AM +0300, Dan Carpenter wrote: > On Fri, Oct 13, 2023 at 07:04:56PM +0300, Calvince Otieno wrote: > > On Fri, Oct 13, 2023 at 3:12 PM Dan Carpenter wrote: > > > > > > On Fri, Oct 13, 2023 at 01:50:23PM +0300, Calvince Otieno wrote: > > > > prism2sta_inf_handover() function basically calls pr_debug() to print > > > > a literal string. This can be done by the parent function directly. > > > > > > > > Signed-off-by: Calvince Otieno > > > > --- > > > > Patch version v2: > > > > - Replace pr_debug() utility function with the module specific netdev_dbg() > > > > > > This isn't a v2 patch, right? This patch assumes that we applied the > > > v1 patch... > > > > > > This patch is not white space damaged though so that's good. > > > > > > regards, > > > dan carpenter > > > > > > > > > > Hello Dan, > > Does this response mean that the patch was accepted? > > Ugh... No, sorry. I suck at emails. White space damaged is not good. > I left out the word not... :/ > > You need to figure out what's going on there. Some of your patches are > not white space damaged so sometimes you're doing it right but here the > spaces were replaced with tabs so it doesn't apply. Wow... I absolutely suck at writing emails and *reading emails*. This wasn't the white space damaged patch. This was the okay one. However you sent a v2 patch in the wrong way. You just posted a fixup instead of resending the patch. You've sent v2 patches before but let me send you my blog link anyway... https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ regards, dan carpenter