Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2370003rdg; Mon, 16 Oct 2023 02:08:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFfURuiW5zpk+l0FwB+9vXRIG3KOhxQhVoe4xNp4p8JbHNC1Ry3C+WAZgg8vbqyrjdhW3es X-Received: by 2002:a17:903:1245:b0:1c7:49dd:2df with SMTP id u5-20020a170903124500b001c749dd02dfmr32696969plh.32.1697447303525; Mon, 16 Oct 2023 02:08:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697447303; cv=none; d=google.com; s=arc-20160816; b=mo3ygnpBJpUW50uGe8wKEQ+cBq/R4Ah8bD5C45WirKcL/5JEDSkZ+1UES6Afmylv1z dFnNPW+JBtEUSxjjXAWDhpX3PphjTnw01F1a1psrsQghAkneszCimDUysguZp+/ZahAw pSJ+5r1CxW9pgxHOB7yn9d8v9zuQ2R1Xq+Mz0b2Dx5boGZs/KDfW/Vs30uYnDUsbMVIq tbB6syPGyHtQJh4hFEWn3XWiEDf/dD/soNbdQrI7HkD+NYi2vMMcKQ9ml9kwgpgm2VL2 AKI2/ptO+dUN0+RwOIe1EA4GGMIFhuxM0843R8RMUhETFek3j+3JnZ1Ns8wJdCFKUYEs veYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=wh2cu5UxtrevsSeIelVH97BO+rPgocToDZ3Jj9re29Q=; fh=D+aG0YlWNfHusaz0WCx+wVDk21rYm46Xb9/0ikyhdFU=; b=giNZZRyi6WHRWIVocL/dcX0k7WNzmtjYzD2qBWa3gvUVhNJ1gJQceOn36rVe2Dp2n2 +/r3+AoDXPwZAk1CJjmcQ2Ct8WdEzPh5YEebZM0JXDi5BfkvcoQJcvZUXHczBXrclhBS m1PTEXiiIazM/mYzTk3rmfGrwASW7SUZ+ZzeqV/d4RGdBJ+FNQ+1f1wqEZEmEe52Tgfb ACJWhkR4Gz6YcWj8OQebsRrSLl7m9dZ0yfLsRDuKPoW4eq/hSlTfK5SyuAi0POXATdfR U0by4y6eY9JDHcivWE39Jnabw2Q7lsK1R15fivsN21LLJBEW5drcqQLQuyUlNXmeE6e2 3fug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id u5-20020a170902e5c500b001ca0cf2582fsi7005395plf.410.2023.10.16.02.08.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 02:08:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id A430E805F49C; Mon, 16 Oct 2023 02:08:20 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230435AbjJPJIL (ORCPT + 99 others); Mon, 16 Oct 2023 05:08:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230177AbjJPJIK (ORCPT ); Mon, 16 Oct 2023 05:08:10 -0400 Received: from out28-5.mail.aliyun.com (out28-5.mail.aliyun.com [115.124.28.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB89AAB; Mon, 16 Oct 2023 02:08:07 -0700 (PDT) X-Alimail-AntiSpam: AC=CONTINUE;BC=0.06892163|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_system_inform|0.023128-0.00177961-0.975092;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047193;MF=wangweidong.a@awinic.com;NM=1;PH=DS;RN=26;RT=26;SR=0;TI=SMTPD_---.V08HDja_1697447275; Received: from ubuntu-VirtualBox..(mailfrom:wangweidong.a@awinic.com fp:SMTPD_---.V08HDja_1697447275) by smtp.aliyun-inc.com; Mon, 16 Oct 2023 17:08:03 +0800 From: wangweidong.a@awinic.com To: wangweidong.a@awinic.com Cc: 13916275206@139.com, alsa-devel@alsa-project.org, arnd@arndb.de, broonie@kernel.org, ckeepax@opensource.cirrus.com, colin.i.king@gmail.com, conor+dt@kernel.org, dan.carpenter@linaro.org, devicetree@vger.kernel.org, fido_max@inbox.ru, herve.codina@bootlin.com, krzysztof.kozlowski+dt@linaro.org, lgirdwood@gmail.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, liweilei@awinic.com, perex@perex.cz, rf@opensource.cirrus.com, robh+dt@kernel.org, ryans.lee@analog.com, sebastian.reichel@collabora.com, shumingf@realtek.com, tiwai@suse.com, trix@redhat.com, yijiangtao@awinic.com Subject: Re: [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver Date: Mon, 16 Oct 2023 17:07:54 +0800 Message-ID: <20231016090754.64363-1-wangweidong.a@awinic.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231016081017.46963-1-wangweidong.a@awinic.com> References: <20231016081017.46963-1-wangweidong.a@awinic.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 16 Oct 2023 02:08:20 -0700 (PDT) I'm very sorry that I misunderstood my last comment, correct it here.=0D Thank you again for you hard review.=0D =0D On Mon, Oct 16, 2023 at 16:10:17 +0800, wangweidong.a@awinic.com wrote=0D > On Fri, Oct 13, 2023 at 03:10:56 PM +0100, broonie@kernel.org wrote:=0D >> On Fri, Oct 13, 2023 at 06:42:20PM +0800, wangweidong.a@awinic.com wrote= :=0D =0D >> This looks good - some *very* minor comments below.=0D =0D =0D >>> +static int aw_dev_dsp_update_container(struct aw_device *aw_dev,=0D >>> + unsigned char *data, unsigned int len, unsigned short base)=0D >>> +{=0D >>> + int i, ret;=0D >>> +=0D >>> +#ifdef AW88399_DSP_I2C_WRITES=0D >>> + u32 tmp_len;=0D =0D >> This looks like debug code which can hopefully be removed in favour of=0D >> the regmap implementation?=0D =0D > Thank you very much, but this is not a debugging statement, This is desig= ned=0D > to be compatible with different platforms that may not support continuous= =0D > writing.=0D =0D I found "use_single_write" in regmap, I will remove "AW88399_DSP_I2C_WRITES= ".=0D =0D Best regards,=0D Weidong Wang=0D