Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2377964rdg; Mon, 16 Oct 2023 02:29:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF4KdoRfoFRy0lSAdjWI7AQ3bLfWbhs4UG5Sh6164iuyWbKVem5ddtZmQHtwdIC4a1ncfrX X-Received: by 2002:a05:6a21:4886:b0:174:2fe:f6f7 with SMTP id av6-20020a056a21488600b0017402fef6f7mr13057734pzc.60.1697448549941; Mon, 16 Oct 2023 02:29:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697448549; cv=none; d=google.com; s=arc-20160816; b=b6OeuuBsAPRBzpisOkJCQIC9AsxYq/wq59slf7mhjZKfCl9xc2dj/MPR90+CJ7RGUH NSsmJnW1m/J1bMlqMes91wLUbHPaNHYyGK7xr+YSUWUZJLp+XJNdvwBojEaWvSrPpxV4 syqEiGzHn5Kun5tjlxMJkWkIaPhrW5P4vilo767UyZizSHaCwTPF3DgEZI36iAewCYxw 1n9o5FqKRXg9pQldQ6rITA5QPez5hMlAlZ4+esVDXpNDylJ7VLTo8K/OQR+oEUNpQGIW i5Gg4M5mmMI94GGNsdmFzRLYWKKNNgB9AiIzAJuTV17/bue85qiL9eJjUYf5roxWNBEX U8uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=D/ny36PTyIOVrCHodnezxrX1n8CcGDnBOfmpYzvGvo4=; fh=cHMR5u2FarhxRsuyxxbrqVTL/NKz3hmxkQsc6oEpbAo=; b=NqwwHGDsN0BPVG9uAUr6DBlZ4mDtHT/cMczAUNpvSOj5uCwA3w9kAn7w4MciuiYfNm NYFgoShkkZiIoID0Un64MKOeh4Dbg8NMcRQtEXowhIAwBHE3t3PUiD1XAyqExOYT4HC7 1GFNlrOMhV6+rpChlpUwxSc9TuvmzUlXXcZVSYO3pl7tnD7ASXoxKX9hSxRu3lYXdN4G REE1JYdZh8FZsRsWsfzFuIXzu7d5W/JxJkHBexw5z8VOGptSd07lgde7ghnzsFdvLdJb F1wMXRS+Ub/eP0DotwnlMsJV19Qmv+7c/Ho/1lU79C7d3+05buWIetp1epKdNs5b2i3y Tm4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Vc+bNg4B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id m3-20020a170902bb8300b001c3323ff53asi8154786pls.139.2023.10.16.02.29.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 02:29:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Vc+bNg4B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 3913780A733D; Mon, 16 Oct 2023 02:29:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232905AbjJPJ2u (ORCPT + 99 others); Mon, 16 Oct 2023 05:28:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232327AbjJPJ2s (ORCPT ); Mon, 16 Oct 2023 05:28:48 -0400 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EF61E5 for ; Mon, 16 Oct 2023 02:28:46 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id C306EFF803; Mon, 16 Oct 2023 09:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1697448525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D/ny36PTyIOVrCHodnezxrX1n8CcGDnBOfmpYzvGvo4=; b=Vc+bNg4BLGnHTjzRzZDuWxsTnOh8QHkBO+O98swQCqKGQ+H2bE+mS3cRYx/yleQHf6yLFC YDJf6YqIe1IyC8gExtkQZZfw3Fk0m0hE7KAuy3ACmCL3B/UVFRqPAyWW3+cz/9zPDt2Xd2 aBJDckGvUzsRi7qzSEWUUMrEnI/zBMDh7Q/L2fIx2X/PflI6neRjEQyxKVs2lhO0JiVKvn NSTL50FZw/iyxiAKn6AbLZL1CMTEJHF3+n7NF1jKYYBS9fx1+/Zs9jrxIvLpLmZ3yLliP8 TxzD4IkPtyhsPTHz9Z126T5qgoykKrr1amEnMPt0kJyzNFUP7yEWS/1031Kiqg== From: Miquel Raynal To: ZhaoLong Wang , miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, chengzhihao1@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: Re: [PATCH -next] mtd: Add WARN_ON_ONCE() to mtd_read() to check the return value Date: Mon, 16 Oct 2023 11:28:44 +0200 Message-Id: <20231016092844.288967-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230926065733.3240322-1-wangzhaolong1@huawei.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b'0339f62a9a778bb7cd4f764cd4640cc89155177e' Content-Transfer-Encoding: 8bit X-GND-Sasl: miquel.raynal@bootlin.com X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 16 Oct 2023 02:29:07 -0700 (PDT) On Tue, 2023-09-26 at 06:57:33 UTC, ZhaoLong Wang wrote: > If the driver cannot read all the requested data, -EBADMSG or > -EUCLEAN should never be returned. > > Add a WARN_ON_ONCE() to help driver developers detect this error. > > Signed-off-by: ZhaoLong Wang Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel