Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
MIME-Version: 1.0
References: <cover.1697186772.git.viresh.kumar@linaro.org> <a5bd698a7a899fb63b4c5caec7068bf5a395165c.1697186772.git.viresh.kumar@linaro.org>
In-Reply-To: <a5bd698a7a899fb63b4c5caec7068bf5a395165c.1697186772.git.viresh.kumar@linaro.org>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Mon, 16 Oct 2023 12:11:45 +0200
Message-ID: <CAPDyKFpHy-32h+yu4X-psGqpaqFNpY0CgveHgd_3Zu57KPg3Dw@mail.gmail.com>
Subject: Re: [PATCH 3/5] OPP: Reorder code in _opp_set_required_opps_genpd()
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
        Stephen Boyd <sboyd@kernel.org>, linux-pm@vger.kernel.org,
        Vincent Guittot <vincent.guittot@linaro.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 13 Oct 2023 at 10:48, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> Reorder code in _opp_set_required_opps_genpd() to reduce duplicate code.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  drivers/opp/core.c | 34 +++++++++++++++++++---------------
>  1 file changed, 19 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/opp/core.c b/drivers/opp/core.c
> index f42b663a4d8b..3516e79cf743 100644
> --- a/drivers/opp/core.c
> +++ b/drivers/opp/core.c
> @@ -1076,7 +1076,18 @@ static int _opp_set_required_opps_genpd(struct device *dev,
>  {
>         struct device **genpd_virt_devs =
>                 opp_table->genpd_virt_devs ? opp_table->genpd_virt_devs : &dev;
> -       int i, ret = 0;
> +       int index, target, delta, ret;
> +
> +       /* Scaling up? Set required OPPs in normal order, else reverse */
> +       if (!scaling_down) {
> +               index = 0;
> +               target = opp_table->required_opp_count;
> +               delta = 1;
> +       } else {
> +               index = opp_table->required_opp_count - 1;
> +               target = -1;
> +               delta = -1;
> +       }
>
>         /*
>          * Acquire genpd_virt_dev_lock to make sure we don't use a genpd_dev
> @@ -1084,24 +1095,17 @@ static int _opp_set_required_opps_genpd(struct device *dev,
>          */
>         mutex_lock(&opp_table->genpd_virt_dev_lock);
>
> -       /* Scaling up? Set required OPPs in normal order, else reverse */
> -       if (!scaling_down) {
> -               for (i = 0; i < opp_table->required_opp_count; i++) {
> -                       ret = _set_performance_state(dev, genpd_virt_devs[i], opp, i);
> -                       if (ret)
> -                               break;
> -               }
> -       } else {
> -               for (i = opp_table->required_opp_count - 1; i >= 0; i--) {
> -                       ret = _set_performance_state(dev, genpd_virt_devs[i], opp, i);
> -                       if (ret)
> -                               break;
> -               }
> +       while (index != target) {
> +               ret = _set_performance_state(dev, genpd_virt_devs[index], opp, index);
> +               if (ret)
> +                       break;
> +
> +               index += delta;
>         }
>
>         mutex_unlock(&opp_table->genpd_virt_dev_lock);
>
> -       return ret;
> +       return 0;

Why always return 0 and not the error code anymore?

[...]

Kind regards
Uffe