Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2421825rdg; Mon, 16 Oct 2023 04:13:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTdjmXWUlcklseTbjC3G43VdnQHmpksEmje27DijpZyWJui1HyiGh9abUEzl/iD/okkOPv X-Received: by 2002:a05:6a20:5485:b0:143:f4dd:dfae with SMTP id i5-20020a056a20548500b00143f4dddfaemr44120689pzk.43.1697454806123; Mon, 16 Oct 2023 04:13:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697454806; cv=none; d=google.com; s=arc-20160816; b=M2rRZN5xBqAjr4Rns1Qwwid8iZQDat71shGe4hTaVUT3W2o6UBcAUMWNtbOvWdh5L0 jxIiHYO5AEwak+SV3zc9130Sq7wfs/f3XcrUR04thUDKHP+WDa2IYRckMYogfxoFKnIO ++KCwF4vNAHqWNM2Lom1f0d+dO5NJkMWS9OkufLG4eLKUP0q69eEMMdd6iemCnf8Ib4y lhgANUSICIx1oxdgf+SbAcmY16mDqzyBGiSxzUefemTlx0QBJGdkdbZXU/YGNTY+HNpW /ShYDvPnEKTBVOi0y1tqZQ2zJbBGC27gqnHN70RMftfnR9hEMbYJQd+JJpV2a3kLqNhP 5Szg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=6sfeRXUx1JjAoM62Ln+bzKnT6EnmDV/jDObz4ujSzy4=; fh=cf6RFI5LKpfJORfMW+tzY8K6DkVx3xaueUwn4LeVYOE=; b=uL9sGobN6DHlNZb0fYzC3Qde0Ch8Y8rd6rjacL810kWkf9XIMtWht8nt6ICfdF8ckg WchS9I3B0VuhyFHI6rMGEpu0+abv5tH7rGcp78ihlEkQd6VUPZ4TWysHj8x7SmgypzOr uyECJGdI9R6wNdvZdAaWOwkk2btGyPIOMyCZcEI0Ll3RJufWy/b/eZLMJAzxqflgibzU 0wJ5pqlSCBjGW3FynsCB+D5ruA7UCJhe4E6+2Sn7WaWwnriP6R/ncO1N+cEkHI5S6YIu P20Bv/JnQr5uRT18xhrNNK1kSZJgctzYBfQn/h3zcBRnAKlQlcleIvV//6u+EPE1NUHA /bwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YAqoi0iU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id o6-20020a639206000000b0058ae63187e5si8957970pgd.830.2023.10.16.04.13.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 04:13:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YAqoi0iU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 8ED9880A68A6; Mon, 16 Oct 2023 04:13:23 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232630AbjJPLNL (ORCPT + 99 others); Mon, 16 Oct 2023 07:13:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230116AbjJPLNK (ORCPT ); Mon, 16 Oct 2023 07:13:10 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 221B283; Mon, 16 Oct 2023 04:13:09 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE142C433CB; Mon, 16 Oct 2023 11:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697454788; bh=UAUugA1TRH3GNFHUIn31bVskNVQzeqghhP8ABGtukvE=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=YAqoi0iUbfPDUjpjVXO6wBfsmdA54PwDqLnlg/LzHbRnh41ED/N+x3X8P2cJ74Znt xi4jBbxym5JSYILiAXV3+mnyBwcrIKqXyRYQJK5zBax2zMJ0pllHT+nN8R09wIItqv edhkwzj2RH8z1Dcd3uFtC66uCpCcit/6Kbuq3ls+7HqxWwjKrPjOoZVE5Fswi5SWWd RkSfNglzLl/VHogRcITq0Jk3+9cfRjVpOG9tUwHzca6gLLNAwWPqs8pyjR/fqB6zdX oLtvR9mvjdu3grHwTTTUroGDWT3BNnOzCXG2XuKuAs3MnxhMp5C4zBsmi66yo8Nu2d E60hGccgKUtWw== From: Vinod Koul To: Maxime Coquelin , Alexandre Torgue , M'boumba Cedric Madianga , Pierre-Yves MORDRET , Amelie Delaunay Cc: Alain Volmat , stable@vger.kernel.org, dmaengine@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org In-Reply-To: <20231009082450.452877-1-amelie.delaunay@foss.st.com> References: <20231009082450.452877-1-amelie.delaunay@foss.st.com> Subject: Re: [PATCH] dmaengine: stm32-mdma: correct desc prep when channel running Message-Id: <169745478541.211836.5231413059323245231.b4-ty@kernel.org> Date: Mon, 16 Oct 2023 16:43:05 +0530 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 16 Oct 2023 04:13:23 -0700 (PDT) On Mon, 09 Oct 2023 10:24:50 +0200, Amelie Delaunay wrote: > In case of the prep descriptor while the channel is already running, the > CCR register value stored into the channel could already have its EN bit > set. This would lead to a bad transfer since, at start transfer time, > enabling the channel while other registers aren't yet properly set. > To avoid this, ensure to mask the CCR_EN bit when storing the ccr value > into the mdma channel structure. > > [...] Applied, thanks! [1/1] dmaengine: stm32-mdma: correct desc prep when channel running commit: 03f25d53b145bc2f7ccc82fc04e4482ed734f524 Best regards, -- ~Vinod