Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Mon, 16 Oct 2023 12:58:21 +0100
From:   Mark Brown <broonie@kernel.org>
To:     wangweidong.a@awinic.com
Cc:     13916275206@139.com, alsa-devel@alsa-project.org, arnd@arndb.de,
        ckeepax@opensource.cirrus.com, colin.i.king@gmail.com,
        conor+dt@kernel.org, dan.carpenter@linaro.org,
        devicetree@vger.kernel.org, fido_max@inbox.ru,
        herve.codina@bootlin.com, krzysztof.kozlowski+dt@linaro.org,
        lgirdwood@gmail.com, linus.walleij@linaro.org,
        linux-kernel@vger.kernel.org, liweilei@awinic.com, perex@perex.cz,
        rf@opensource.cirrus.com, robh+dt@kernel.org, ryans.lee@analog.com,
        sebastian.reichel@collabora.com, shumingf@realtek.com,
        tiwai@suse.com, trix@redhat.com, yijiangtao@awinic.com
Subject: Re: [PATCH V1 3/3] ASoC: codecs: Add aw88399 amplifier driver
Message-ID: <38cab9a5-4fdf-4b50-b4e0-6a63beacab11@sirena.org.uk>
References: <ZSlP8GvTAOe35peC@finisterre.sirena.org.uk>
 <20231016081017.46963-1-wangweidong.a@awinic.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="I2KqOEZVLNH8WqF7"
Content-Disposition: inline
In-Reply-To: <20231016081017.46963-1-wangweidong.a@awinic.com>
Precedence: bulk


--I2KqOEZVLNH8WqF7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Oct 16, 2023 at 04:10:17PM +0800, wangweidong.a@awinic.com wrote:
> On Fri, Oct 13, 2023 at 03:10:56 PM +0100, broonie@kernel.org wrote:

> >> +static int aw_dev_dsp_update_container(struct aw_device *aw_dev,
> >> +			unsigned char *data, unsigned int len, unsigned short base)
> >> +{
> >> +	int i, ret;
> >> +
> >> +#ifdef AW88399_DSP_I2C_WRITES
> >> +	u32 tmp_len;

> > This looks like debug code which can hopefully be removed in favour of
> > the regmap implementation?

> Thank you very much, but this is not a debugging statement, This is designed
> to be compatible with different platforms that may not support continuous
> writing.

If this is needed for platform comaptibility then it needs to be
something selected at runtime, ideally regmap would be able to hide
whatever's going on but perhaps the register address loading complicates
things there.

--I2KqOEZVLNH8WqF7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmUtJVwACgkQJNaLcl1U
h9DeUAf9GxJLIrDPtoBWNfziL7xDN8MMHR4vboUOGd/9/eMsg6et0MCSu+5QzwaZ
oTvhMCnN1w5fQjm182eLWMKbnZ/NeuwVfsgyqaGEuP8JW/2+Tct7ag8LEZadlpcz
fnPjeDA5YMMTeVeNplkojJmFfaJjLuggt7o6xwKp36/ZV6AJlhj29y+LK+snV8eL
77jQR75a+ZU2OYdy8GAUaN8HS4cv8ln6U0YcGxlNjrF+VLOqfy7d2abbdBYPRkis
arUpxgW+qXYLpR53CyZGQnbWGXMpWyEZBiIGWNXuxq+IFstrOTyIUp/K4FWJ5t2A
YBUyyUaSuiFQNQGYb2V3IaV2khuftg==
=tkTS
-----END PGP SIGNATURE-----

--I2KqOEZVLNH8WqF7--