Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Mon, 16 Oct 2023 09:04:54 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
Cc:     Yi Liu <yi.l.liu@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "kevin.tian@intel.com" <kevin.tian@intel.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "zhenzhong.duan@intel.com" <zhenzhong.duan@intel.com>,
        "joao.m.martins@oracle.com" <joao.m.martins@oracle.com>
Subject: Re: [PATCH v2 1/6] iommu: Add new iommu op to create domains owned
 by userspace
Message-ID: <20231016120454.GS3952@nvidia.com>
References: <20230928071528.26258-1-yi.l.liu@intel.com>
 <20230928071528.26258-2-yi.l.liu@intel.com>
 <ZSuROTyaxePoVFA+@Asurada-Nvidia>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZSuROTyaxePoVFA+@Asurada-Nvidia>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OsPIdv6fOvrB/wWly+wS22jA1YtkIc00UTSNIEDZQzGkshX0+XmuqaXREvZY?=
 =?us-ascii?Q?cqBo5R+bI06EKEkOHba3ZGp7d3mmacWxIpiFS5L/buTMeZpJUVUHSnrUKu8O?=
 =?us-ascii?Q?BSgr5atAp6nh77T4xnk5SjzXmTXDk8C9F+S1hSdm2gSPk1rRqvnaDFfmowKy?=
 =?us-ascii?Q?L45dcGsG9+I0TdiZ+ll1O/iOW8KREcFWzbFaqJJm3WUREDEJRMh3WD1yEZUD?=
 =?us-ascii?Q?lRZzl6KUILdOKVf04UmG4qq8CsKdapPx2jp9cM1Obrj2Vfo4EO+J5hk05+BV?=
 =?us-ascii?Q?Vf2plxqnxiCXUxHPyAS6yWZko9LNP9chyoi0jPARH163BLQNiKWl0SHxn4JP?=
 =?us-ascii?Q?n0MfBszEfIbWZ3dpWzV52Pp1JK9ABhmK7VpSmNYSASa8NAK2K/Q7Z3mpO45C?=
 =?us-ascii?Q?PLFu9R/MONFZAgcW7OpGSNtoZ2SN57a9J+w4+tXfst9tCvYI9mlA29ydg31a?=
 =?us-ascii?Q?uBZCG7QeDcQs4ANcWPdot/GSw4plKkvEQ4iLNNoyvrTb9GqHvwFHv+e2ftDN?=
 =?us-ascii?Q?cF2lTgY2Aee8I0sY0gXKhOGLCZcHgJFjJUaR7Ww+2rMaSrvIQAsf4r8sZMor?=
 =?us-ascii?Q?CznMYvg2TO7mBsgTVky19LSiP6PShZhWTURm6xXxyF56WDJWCARhKza07JXI?=
 =?us-ascii?Q?TqdR2d21cLAhj8j7crLtRPMy2vXggktqup/SuNhxH8m/iR1z12O5WlY3oC4P?=
 =?us-ascii?Q?cKpmx2lTD5nSyiP3B0aEs2JAbT4OuuoiTlIWKstKtXhYQmgO8DCVu+Hi51pb?=
 =?us-ascii?Q?+dUlUxj9NnVVwvp3Y5eTCbpKEGSLOXH0AbCDNBMrUrPhzNNjyjFiYluut5l/?=
 =?us-ascii?Q?ZWH01x916OVF1Yc/09dl9JK485diZQTwpO7oNW88hSYs6gDy8HVnGMnHsnP/?=
 =?us-ascii?Q?JzzT/QokmuN5YYmePIVwDEGnQTnRR3T+pdGz52M6CeyD0uQSLj/o9QofvRqe?=
 =?us-ascii?Q?9JJqohVV7B+YAaoKzcSDlfj9qG+KgV1zJznIAzcDr7zdrxWV46an92tBGRAq?=
 =?us-ascii?Q?gribG/wlevIHq79bcigQZHyycgzyoVHBBPK7+NA5s0ANidTL5aEKJotpOtQZ?=
 =?us-ascii?Q?KGVhUhHtFyztFMqmj5yesq5b2+SdoUO4/1Uw23OIgqOZnoH+J67T59eEuzNY?=
 =?us-ascii?Q?+aW3Nf03E8cwl0Euj3E+4Mi6Hc/6k/w8J1A81B8YnP+ulUi9RqQnuZmmb5m6?=
 =?us-ascii?Q?s3ueSkaHoFdUhiCsztDuIhjPbHBGvaYF3XIdfxSySxiYcZiVKSf1fm+y3Brv?=
 =?us-ascii?Q?SmTlfcROpKd28NMeDjPx51LTbdTWt/e8X/auH97Ye9V9J9EfY5YzIyj9iE6O?=
 =?us-ascii?Q?dRnWSTvT67pQLAzCH1S2DJaL9o9bg1tSDKDnpF1DAwJDkZADSJNIZBoD7His?=
 =?us-ascii?Q?2D0Xs68pdNE4qtrHlCwambXyrA9RYnySZe69qEx+nF1cMtQPBj/tmYZZ590o?=
 =?us-ascii?Q?9QMDE/gID3T9Fgbqjm8UgzcBuK4ydLq6uQpXjGHTN6K1PfjTjPOBcBUKj8G+?=
 =?us-ascii?Q?TdQfrfxSqHuc7Naa36TtpMYOuHdlfu7S+QhMiSlxywGr1r1GAbv9QibJMy4G?=
 =?us-ascii?Q?PHSwNLEtxzdF8MUl+gK9ReLItb0mWeCYELI037rY?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb0c1aad-f645-4a1f-3e5c-08dbce401c3d
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 12:04:55.1422
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YYGWNAHbF+DdybVHlSmusXav3GDgz5FCW3+TUwihkHWbzmS0a9MN2FGpj2wPuZOi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8920
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 16 Oct 2023 05:05:16 -0700 (PDT)

On Sun, Oct 15, 2023 at 12:14:01AM -0700, Nicolin Chen wrote:
> On Thu, Sep 28, 2023 at 12:15:23AM -0700, Yi Liu wrote:
> 
> > diff --git a/include/uapi/linux/iommufd.h b/include/uapi/linux/iommufd.h
> > index b4ba0c0cbab6..4a7c5c8fdbb4 100644
> > --- a/include/uapi/linux/iommufd.h
> > +++ b/include/uapi/linux/iommufd.h
> > @@ -347,10 +347,20 @@ struct iommu_vfio_ioas {
> >  };
> >  #define IOMMU_VFIO_IOAS _IO(IOMMUFD_TYPE, IOMMUFD_CMD_VFIO_IOAS)
> > 
> > +/**
> > + * enum iommufd_hwpt_alloc_flags - Flags for HWPT allocation
> > + * @IOMMU_HWPT_ALLOC_NEST_PARENT: If set, allocate a domain which can serve
> > + *                                as the parent domain in the nesting
> > + *                                configuration.
> 
> I just noticed a nit here: we should probably align with other
> parts of this file by using "HWPT" v.s. "domain"? I.e.
> 
> + * @IOMMU_HWPT_ALLOC_NEST_PARENT: If set, allocate a HWPT which can serve
> + *                                as the parent HWPT in the nesting
> + *                                configuration.

Yes

Jason