Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp2483396rdg; Mon, 16 Oct 2023 06:06:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHUo1uGneDKlc4wLOKnM5AoLiw+3lMLBbdwB8CpogOSidC95L7/zSp5M/FrpZZfg3D3Xv3v X-Received: by 2002:aa7:9689:0:b0:6b6:7a04:6f9 with SMTP id f9-20020aa79689000000b006b67a0406f9mr5072995pfk.28.1697461565649; Mon, 16 Oct 2023 06:06:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697461565; cv=none; d=google.com; s=arc-20160816; b=z+4Oo6TVkTOnbAplMo5BR8Ri+dbqNu3nw9FCKoh00Qk7tOOf6wccux04H7zazm9NlX cFpaGvpZGIIvUoOAofKw82qPYrVE0kFfolgEr8ggz9JfgYBa9n2TBv+bTSLZV3+wX7W/ nw1py87tqjyaJLbHq8QNGxkXkid7YaKdHTZ0RC4o91g4BUS28S8juDzWlMdIzNOR1tED MYE+IS8RtdDsCTTFHSeiVFGfZdSWoyP6iTo92wK7mGr83qzwOrtbbsIAX3L1SdYcG/bZ OS2FOlUNlmHB+0vD1NlI1Fy0MXWmuD4GrfC1H1lzoiqK/ovZjn2XgjpDpZeUSGpAfLfy rg1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=cJsAHCPmeTcWxlrPmDpsQqa7FzCD0MySS7pCOVITrbI=; fh=3oUSWWYQ0rMHaNqDlm8j09K7pkfJE062n+5jIRWafQ4=; b=m4rEttnPWix9fhiJv6kOA+G0EZ6h8wkOdtGIevRmG7P1Lm0gSwwrliJxDebv+tFZbd z2tu4UKAY/jiVwjMkRsWPL7sGObDtukOKYRzQSi/9UGCvCwSDSYJwlc8pSlyldFy5KVH S0RLw/VAg0eyhaa0hM19iW/is1wPg5cDYZeWGyNipSgCp2fas4imH3kquEZOo6NU6MbI ge8R2OrAuVJu39ZVodnBOnJJe67+ioM+D8h2sO32CnFMno5gD4xrtyH64Jw/EDs8fkwm sUkITO/rBr5R6DkG2c/lx9jajoJd0VF2Pw8E0fTL4zIQKATu1ODE7+svnpRJFBspdOUv U3tg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id w14-20020aa7954e000000b006ba82adb9acsi5123172pfq.332.2023.10.16.06.06.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 06:06:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id C6BF9806045A; Mon, 16 Oct 2023 06:06:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233466AbjJPNF4 (ORCPT + 99 others); Mon, 16 Oct 2023 09:05:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231508AbjJPNFx (ORCPT ); Mon, 16 Oct 2023 09:05:53 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 988F1B4 for ; Mon, 16 Oct 2023 06:05:51 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 77F9821C54; Mon, 16 Oct 2023 13:05:49 +0000 (UTC) Received: from suse.cz (pmladek.udp.ovpn2.prg.suse.de [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id E838F2CB8B; Mon, 16 Oct 2023 13:05:48 +0000 (UTC) Date: Mon, 16 Oct 2023 15:05:48 +0200 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH printk v2 1/4] printk: For @suppress_panic_printk check other panic Message-ID: References: <20231013204340.1112036-1-john.ogness@linutronix.de> <20231013204340.1112036-2-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231013204340.1112036-2-john.ogness@linutronix.de> X-Spamd-Bar: +++++++++++++++++++++ Authentication-Results: smtp-out1.suse.de; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=suse.com (policy=quarantine); spf=fail (smtp-out1.suse.de: domain of pmladek@suse.com does not designate 149.44.160.134 as permitted sender) smtp.mailfrom=pmladek@suse.com X-Rspamd-Server: rspamd2 X-Spamd-Result: default: False [21.10 / 50.00]; ARC_NA(0.00)[]; R_SPF_FAIL(1.00)[-all]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(1.59)[0.795]; MIME_GOOD(-0.10)[text/plain]; RWL_MAILSPIKE_GOOD(0.00)[149.44.160.134:from]; RCPT_COUNT_FIVE(0.00)[5]; DMARC_POLICY_QUARANTINE(1.50)[suse.com : No valid SPF, No valid DKIM,quarantine]; VIOLATED_DIRECT_SPF(3.50)[]; MX_GOOD(-0.01)[]; NEURAL_SPAM_LONG(3.00)[1.000]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; R_DKIM_NA(0.20)[]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-1.99)[95.02%] X-Spam-Score: 21.10 X-Rspamd-Queue-Id: 77F9821C54 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 16 Oct 2023 06:06:02 -0700 (PDT) On Fri 2023-10-13 22:49:37, John Ogness wrote: > Currently @suppress_panic_printk is checked along with > non-matching @panic_cpu and current CPU. This works > because @suppress_panic_printk is only set when > panic_in_progress() is true. > > Rather than relying on the @suppress_panic_printk semantics, > use the concise helper function other_cpu_in_progress(). The > helper function exists to avoid open coding such tests. > > Signed-off-by: John Ogness Reviewed-by: Petr Mladek Best Regards, Petr