Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <ecb37173-4b49-466b-b92d-4ff710eee998@daynix.com>
Date:   Mon, 16 Oct 2023 22:08:21 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH bpf-next v3] selftests/bpf: Use pkg-config to determine ld
 flags
To:     Daniel Borkmann <daniel@iogearbox.net>
Cc:     Andrii Nakryiko <andrii@kernel.org>,
        Mykola Lysenko <mykolal@fb.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>,
        Yonghong Song <yonghong.song@linux.dev>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Shuah Khan <shuah@kernel.org>, Nick Terrell <terrelln@fb.com>,
        bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20231016124313.60220-1-akihiko.odaki@daynix.com>
 <f44993c9-1934-746f-aa3a-a1005459320a@iogearbox.net>
Content-Language: en-US
From:   Akihiko Odaki <akihiko.odaki@daynix.com>
In-Reply-To: <f44993c9-1934-746f-aa3a-a1005459320a@iogearbox.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/10/16 21:52, Daniel Borkmann wrote:
> On 10/16/23 2:43 PM, Akihiko Odaki wrote:
>> When linking statically, libraries may require other dependencies to be
>> included to ld flags. In particular, libelf may require libzstd. Use
>> pkg-config to determine such dependencies.
>>
>> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>> ---
>> V2 -> V3: Added missing "echo".
>> V1 -> V2: Implemented fallback, referring to HOSTPKG_CONFIG.
> 
> Same issue in v3. Please don't resend your patches too quickly, but 
> properly set up an
> environment where you can test that this fallback works first :
> 
> https://github.com/kernel-patches/bpf/actions/runs/6533309175/job/17738285759

I think you are looking at a wrong run. The run checks out:
https://github.com/kernel-patches/bpf/commit/0c184cb0b561d2fb60b2dc79c2917cd7ff8cd8a2

This is v2. I think the correct one is:
https://github.com/kernel-patches/bpf/actions/runs/6533797864

That said, I found spurious error messages with the run. I tested it by 
setting PKG_CONFIG=false, but I should have tested it with 
PKG_CONFIG=a-command-that-does-not-exist. Now I sent v4, which does no 
longer emit noisy error messages and is properly tested.